Skip to content

[8.17] [Observability Nav] [Serverless Nav] remove apm link from application nav section (#230152) #230434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
baileycash-elastic wants to merge 1 commit into from
Closed

[8.17] [Observability Nav] [Serverless Nav] remove apm link from application nav section (#230152) #230434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion x-pack/plugins/observability_solution/observability/public/navigation_tree.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,13 +88,15 @@ export function createNavTree(pluginsStart: ObservabilityPublicPluginsStart) {
spaceBefore: 'm',
},
{
id: 'apm',
id: 'applications',
title: i18n.translate('xpack.observability.obltNav.applications', {
defaultMessage: 'Applications',
}),
renderAs: 'panelOpener',
children: [
{
id: 'apm',
link: 'apm:services',
children: [
{
link: 'apm:services',
Expand Down
10 changes: 5 additions & 5 deletions x-pack/test/functional_solution_sidenav/tests/observability_sidenav.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,16 +49,16 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
deepLinkId: 'observabilityOnboarding',
});

// open apm (Application) panel using the link button (not the button icon)
await solutionNavigation.sidenav.openPanel('apm', { button: 'link' });
// open application panel
await solutionNavigation.sidenav.openPanel('applications');
{
const isOpen = await solutionNavigation.sidenav.isPanelOpen('apm');
const isOpen = await solutionNavigation.sidenav.isPanelOpen('applications');
expect(isOpen).to.be(true);
}

await solutionNavigation.sidenav.closePanel('apm', { button: 'link' });
await solutionNavigation.sidenav.closePanel('applications');
{
const isOpen = await solutionNavigation.sidenav.isPanelOpen('apm');
const isOpen = await solutionNavigation.sidenav.isPanelOpen('applications');
expect(isOpen).to.be(false);
}

Expand Down