Skip to content

[8.17] [Snapshot and restore] Display snapshot searchbar even if snapshots request fails (#229698) #230432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
damian-polewski merged 1 commit into from
Aug 5, 2025
Merged

[8.17] [Snapshot and restore] Display snapshot searchbar even if snapshots request fails (#229698) #230432

damian-polewski merged 1 commit into from
Aug 5, 2025

Conversation

@damian-polewski
Copy link
Contributor

@damian-polewski damian-polewski commented Aug 4, 2025

Backport

This will backport the following commits from main to 8.17:

Questions ?

Please refer to the Backport tool documentation

@damian-polewski
[Snapshot and restore] Display snapshot searchbar even if snapshots r…
49cd55f 
…equest fails (elastic#229698)

Closes elastic#225935

## Summary

This PR fixes an issue where after request to load snapshots fails, e.g.
due to one of repositories misconfiguration, user was not able to use
search bar to change query to access snapshots from different
repositories.

(cherry picked from commit 3d9c2bf)

# Conflicts:
#	src/plugins/es_ui_shared/__packages_do_not_import__/authorization/types.ts
#	x-pack/plugins/snapshot_restore/public/application/constants/index.ts
@damian-polewski damian-polewski added the backport This PR is a backport of another PR label Aug 4, 2025
@damian-polewski damian-polewski enabled auto-merge (squash) August 4, 2025 14:37
@damian-polewski damian-polewski mentioned this pull request Aug 4, 2025
Merged
8 tasks
@elasticmachine
Copy link
Contributor

elasticmachine commented Aug 4, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #21 / alerting api integration security and spaces enabled - Group 3 Maintenance Window - Group 3 maintenance window findMaintenanceWindow global_read at space1 should handle find maintenance window request with pagination

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
esUiShared 97 99 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
snapshotRestore 254.1KB 254.4KB +352.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
snapshotRestore 25.3KB 25.4KB +34.0B
Unknown metric groups

API count

id before after diff
esUiShared 99 101 +2

@damian-polewski damian-polewski merged commit 99fc13c into elastic:8.17 Aug 5, 2025
11 checks passed
@damian-polewski damian-polewski deleted the backport/8.17/pr-229698 branch August 5, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SoniaSanzV SoniaSanzV SoniaSanzV approved these changes

@kibanamachine kibanamachine Awaiting requested review from kibanamachine kibanamachine is a code owner

Assignees

No one assigned

Labels

backport This PR is a backport of another PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@damian-polewski @elasticmachine @SoniaSanzV