[Workspace Chrome] Clean up some of EUI hacks #230419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dosant
added
release_note:skip
Contributor
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
tsullivan
requested changes
Aug 5, 2025
Member
tsullivan
left a comment
tsullivan
left a comment
There was a problem hiding this comment.
Request a change to a comment that took me awhile to understand
src/platform/packages/shared/react/kibana_context/root/eui_provider.tsx
Outdated
Show resolved
Hide resolved
…vider.tsx Co-authored-by: Tim Sullivan <[email protected]>
tsullivan
approved these changes
Aug 5, 2025
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Public APIs missing comments
Count of Enzyme imports
Page load bundle
History
|
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
Aug 5, 2025
## Summary We introduced some EUI related hacks for flyouts for grid layout. After contributing some improvements to EUI we can clean the hacks up: - elastic/eui#8872 - this cleans up a hack to resize the push flyout using new exposed css variable - elastic/eui#8849 This allows us to specify which elements should be included in the flyout focus trap by default. Previously, it was the EUI fixed header, but in the grid layout, we don't have a fixed header. So, we need to tell EUI which elements to include: our header and sidenav. - Small unzyme --------- Co-authored-by: Tim Sullivan <[email protected]>
NicholasPeretti
pushed a commit
to NicholasPeretti/kibana
that referenced
this pull request
Aug 18, 2025
## Summary We introduced some EUI related hacks for flyouts for grid layout. After contributing some improvements to EUI we can clean the hacks up: - elastic/eui#8872 - this cleans up a hack to resize the push flyout using new exposed css variable - elastic/eui#8849 This allows us to specify which elements should be included in the flyout focus trap by default. Previously, it was the EUI fixed header, but in the grid layout, we don't have a fixed header. So, we need to tell EUI which elements to include: our header and sidenav. - Small unzyme --------- Co-authored-by: Tim Sullivan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We introduced some EUI related hacks for flyouts for grid layout. After contributing some improvements to EUI we can clean the hacks up:
includeSelectorInFocusTrapeui#8849 This allows us to specify which elements should be included in the flyout focus trap by default. Previously, it was the EUI fixed header, but in the grid layout, we don't have a fixed header. So, we need to tell EUI which elements to include: our header and sidenav.