Skip to content

[OneChat] Conversation Response Cancellation#230328

Merged
zacharyparikh merged 9 commits intoelastic:mainfrom
zacharyparikh:conversation/response/cancellation
Aug 5, 2025
Merged

[OneChat] Conversation Response Cancellation#230328
zacharyparikh merged 9 commits intoelastic:mainfrom
zacharyparikh:conversation/response/cancellation

Conversation

@zacharyparikh
Copy link
Contributor

@zacharyparikh zacharyparikh commented Aug 1, 2025 •
edited
Loading

Summary

Adds functionality for cancelling a conversation round while the response is being streamed in.

Conversation.Response.Cancellation.mov

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.

Identify risks

  • There may be some time that it is possible for the user to cancel the round, but the server persists the round before the message abort is delivered. May need some more testing around this.

@zacharyparikh zacharyparikh force-pushed the conversation/response/cancellation branch from 04cc3aa to f0db2ce Compare August 1, 2025 23:56
@zacharyparikh
Copy link
Contributor Author

zacharyparikh commented Aug 4, 2025

@elasticmachine merge upstream

@zacharyparikh zacharyparikh added backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes labels Aug 4, 2025
@zacharyparikh zacharyparikh marked this pull request as ready for review August 4, 2025 14:40
@zacharyparikh zacharyparikh requested a review from a team as a code owner August 4, 2025 14:40
zacharyparikh and others added 2 commits August 5, 2025 08:25
@zacharyparikh @joemcelroy
Remove inline callback for onRetry prop
8359817 
Co-authored-by: Joe McElroy <joseph.mcelroy@elastic.co>
@zacharyparikh
Fix typo
03e3ba5
joemcelroy
joemcelroy approved these changes Aug 5, 2025
View reviewed changes
Copy link
Member

@joemcelroy joemcelroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works well!

Only thing that could be nicer is the previous incomplete message stays in the UI (in client side memory) but we can consider that in future.

@elasticmachine
Copy link
Contributor

elasticmachine commented Aug 5, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #130 / Alerting getActionErrorLog get and filter action error logs for rules with multiple action errors
  • [job] [logs] Jest Tests #7 / EQL Tab rendering pagination should load notes for current page only
  • [job] [logs] FTR Configs #22 / Fleet Endpoints fleet policy secrets fleet server version requirements "after each" hook for "should not store secrets if there are no fleet servers"

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
onechat 415 416 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
onechat 595.5KB 596.3KB +797.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
onechat 12.7KB 12.2KB -457.0B

History

@zacharyparikh zacharyparikh merged commit 832aae4 into elastic:main Aug 5, 2025
12 checks passed
delanni pushed a commit to delanni/kibana that referenced this pull request Aug 5, 2025
@zacharyparikh @elasticmachine
@kibanamachine @joemcelroy @delanni
[OneChat] Conversation Response Cancellation (elastic#230328)
070d9e0 
## Summary

Adds functionality for cancelling a conversation round while the
response is being streamed in.


https://github.com/user-attachments/assets/318c8325-32c8-4ca8-90f5-561edcaf1442


### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [ ] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.

### Identify risks

- [ ] There may be some time that it is possible for the user to cancel
the round, but the server persists the round before the message abort is
delivered. May need some more testing around this.

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Joe McElroy <joseph.mcelroy@elastic.co>
@wildemat wildemat mentioned this pull request Aug 7, 2025
Closed
10 tasks
NicholasPeretti pushed a commit to NicholasPeretti/kibana that referenced this pull request Aug 18, 2025
@zacharyparikh @elasticmachine
@kibanamachine @joemcelroy @NicholasPeretti
[OneChat] Conversation Response Cancellation (elastic#230328)
5daa33e 
## Summary

Adds functionality for cancelling a conversation round while the
response is being streamed in.


https://github.com/user-attachments/assets/318c8325-32c8-4ca8-90f5-561edcaf1442


### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [ ] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.

### Identify risks

- [ ] There may be some time that it is possible for the user to cancel
the round, but the server persists the round before the message abort is
delivered. May need some more testing around this.

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Joe McElroy <joseph.mcelroy@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joemcelroy joemcelroy joemcelroy approved these changes

@jedrazb jedrazb Awaiting requested review from jedrazb

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes v9.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zacharyparikh @elasticmachine @joemcelroy @kibanamachine