[Dashboard] Remove unncessary promises #230313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickpeihl
added
release_note:fix
Team:Presentation
Contributor
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
nreese
approved these changes
Aug 1, 2025
Contributor
nreese
left a comment
nreese
left a comment
There was a problem hiding this comment.
LGTM - thanks for moving this into is own PR
code review only
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
|
Contributor
|
Starting backport for target branches: 8.17, 8.18, 8.19, 9.0, 9.1 https://github.com/elastic/kibana/actions/runs/16732202585 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 4, 2025
## Summary Removes unnecessary promises in DashboardStorage class. All of the functions are synchronous so we don't need to await or wrap in Promise.all. (cherry picked from commit edb3fa8)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 4, 2025
## Summary Removes unnecessary promises in DashboardStorage class. All of the functions are synchronous so we don't need to await or wrap in Promise.all. (cherry picked from commit edb3fa8)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
nickpeihl
added
backport:version
Contributor
|
Starting backport for target branches: 8.19, 9.1 https://github.com/elastic/kibana/actions/runs/16733311989 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 4, 2025
## Summary Removes unnecessary promises in DashboardStorage class. All of the functions are synchronous so we don't need to await or wrap in Promise.all. (cherry picked from commit edb3fa8)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 4, 2025
## Summary Removes unnecessary promises in DashboardStorage class. All of the functions are synchronous so we don't need to await or wrap in Promise.all. (cherry picked from commit edb3fa8)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
This was referenced Aug 4, 2025
kibanamachine
added a commit
that referenced
this pull request
Aug 4, 2025
# Backport This will backport the following commits from `main` to `9.1`: - [[Dashboard] Remove unncessary promises (#230313)](#230313) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Nick Peihl","email":"nick.peihl@elastic.co"},"sourceCommit":{"committedDate":"2025-08-04T19:21:20Z","message":"[Dashboard] Remove unncessary promises (#230313)\n\n## Summary\n\nRemoves unnecessary promises in DashboardStorage class. \n\nAll of the functions are synchronous so we don't need to await or wrap\nin Promise.all.","sha":"edb3fa8fcf8ec473e061a90305e9f222ecaa2715","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","backport:all-open","v9.2.0"],"title":"[Dashboard] Remove unncessary promises","number":230313,"url":"https://github.com/elastic/kibana/pull/230313","mergeCommit":{"message":"[Dashboard] Remove unncessary promises (#230313)\n\n## Summary\n\nRemoves unnecessary promises in DashboardStorage class. \n\nAll of the functions are synchronous so we don't need to await or wrap\nin Promise.all.","sha":"edb3fa8fcf8ec473e061a90305e9f222ecaa2715"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/230313","number":230313,"mergeCommit":{"message":"[Dashboard] Remove unncessary promises (#230313)\n\n## Summary\n\nRemoves unnecessary promises in DashboardStorage class. \n\nAll of the functions are synchronous so we don't need to await or wrap\nin Promise.all.","sha":"edb3fa8fcf8ec473e061a90305e9f222ecaa2715"}}]}] BACKPORT--> Co-authored-by: Nick Peihl <nick.peihl@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Aug 4, 2025
# Backport This will backport the following commits from `main` to `8.19`: - [[Dashboard] Remove unncessary promises (#230313)](#230313) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Nick Peihl","email":"nick.peihl@elastic.co"},"sourceCommit":{"committedDate":"2025-08-04T19:21:20Z","message":"[Dashboard] Remove unncessary promises (#230313)\n\n## Summary\n\nRemoves unnecessary promises in DashboardStorage class. \n\nAll of the functions are synchronous so we don't need to await or wrap\nin Promise.all.","sha":"edb3fa8fcf8ec473e061a90305e9f222ecaa2715","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","backport:all-open","v9.2.0"],"title":"[Dashboard] Remove unncessary promises","number":230313,"url":"https://github.com/elastic/kibana/pull/230313","mergeCommit":{"message":"[Dashboard] Remove unncessary promises (#230313)\n\n## Summary\n\nRemoves unnecessary promises in DashboardStorage class. \n\nAll of the functions are synchronous so we don't need to await or wrap\nin Promise.all.","sha":"edb3fa8fcf8ec473e061a90305e9f222ecaa2715"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/230313","number":230313,"mergeCommit":{"message":"[Dashboard] Remove unncessary promises (#230313)\n\n## Summary\n\nRemoves unnecessary promises in DashboardStorage class. \n\nAll of the functions are synchronous so we don't need to await or wrap\nin Promise.all.","sha":"edb3fa8fcf8ec473e061a90305e9f222ecaa2715"}}]}] BACKPORT--> Co-authored-by: Nick Peihl <nick.peihl@elastic.co>
szaffarano
pushed a commit
to szaffarano/kibana
that referenced
this pull request
Aug 5, 2025
## Summary Removes unnecessary promises in DashboardStorage class. All of the functions are synchronous so we don't need to await or wrap in Promise.all.
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
Aug 5, 2025
## Summary Removes unnecessary promises in DashboardStorage class. All of the functions are synchronous so we don't need to await or wrap in Promise.all.
NicholasPeretti
pushed a commit
to NicholasPeretti/kibana
that referenced
this pull request
Aug 18, 2025
## Summary Removes unnecessary promises in DashboardStorage class. All of the functions are synchronous so we don't need to await or wrap in Promise.all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes unnecessary promises in DashboardStorage class.
All of the functions are synchronous so we don't need to await or wrap in Promise.all.