[ES|QL] treat time_duration and date_period separately
#230276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewdaemon
commented
Aug 1, 2025
| evalExpectErrors(`from a_index | eval col0 = dateField - 1 ${unit.toUpperCase()}`, []); | ||
| evalExpectErrors(`from a_index | eval col0 = dateField - 1 ${capitalize(unit)}`, []); | ||
| evalExpectErrors(`from a_index | eval col0 = dateField + 1 ${unit}`, []); | ||
| evalExpectErrors(`from a_index | eval 1 ${unit} + 1 year`, []); |
Contributor
Author
There was a problem hiding this comment.
This is cool... with the old logic, we were incorrectly allowing this case. But now that we've tightened up the typing, the validator correctly flagged it based on the + function definition
drewdaemon
commented
Aug 1, 2025
| }); | ||
| }); | ||
|
|
||
| describe('time interval', () => { |
Contributor
Author
There was a problem hiding this comment.
No longer a special case!
drewdaemon
added
release_note:skip
drewdaemon
changed the title
time_duration and date_period correctlytime_duration and date_period separately
8 tasks
Contributor
|
Pinging @elastic/kibana-esql (Team:ESQL) |
stratoula
approved these changes
Aug 4, 2025
Contributor
stratoula
left a comment
stratoula
left a comment
There was a problem hiding this comment.
LGTM, code review only!
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
History
|
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
Aug 5, 2025
…30276) ## Summary Closes elastic#223037 The main change here is changing the "timeInterval" AST item to be two types of new literal items that share mostly the same structure as the other literals and no longer require special handling during validation! A few validation checks around these were also removed. More about that in the comments. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
NicholasPeretti
pushed a commit
to NicholasPeretti/kibana
that referenced
this pull request
Aug 18, 2025
…30276) ## Summary Closes elastic#223037 The main change here is changing the "timeInterval" AST item to be two types of new literal items that share mostly the same structure as the other literals and no longer require special handling during validation! A few validation checks around these were also removed. More about that in the comments. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #223037
The main change here is changing the "timeInterval" AST item to be two types of new literal items that share mostly the same structure as the other literals and no longer require special handling during validation!
A few validation checks around these were also removed. More about that in the comments.
Checklist