Skip to content

[Synthetics] Fix global params sync for non default private locations !!#230157

Merged
shahzad31 merged 4 commits intoelastic:mainfrom
shahzad31:fix-global-sync
Aug 4, 2025
Merged

[Synthetics] Fix global params sync for non default private locations !!#230157
shahzad31 merged 4 commits intoelastic:mainfrom
shahzad31:fix-global-sync

Conversation

@shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Aug 1, 2025

Summary

Fix global params sync for non default private locations !!

Make sure in sync task when querying for locations it uses all spaces.

Fixes #230366

API tests

i have added e2e tests to make sure it covers the use-case

@github-actions github-actions bot added the author:obs-ux-management PRs authored by the obs ux management team label Aug 1, 2025
@shahzad31 shahzad31 marked this pull request as ready for review August 4, 2025 09:01
@shahzad31 shahzad31 requested review from a team as code owners August 4, 2025 09:01
@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels v9.0.5 v9.1.1 v8.18.5 v8.19.1 release_note:fix and removed release_note:skip Skip the PR/issue when compiling release notes labels Aug 4, 2025
Copy link
Contributor

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/platform/packages/shared/kbn-test/src/kbn_client/kbn_client_saved_objects.ts changes LGTM

@botelastic botelastic bot added the Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. label Aug 4, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

Copy link
Contributor

@cesco-f cesco-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shahzad31 and others added 2 commits August 4, 2025 12:43
…etics/sync_global_params_spaces.ts

Co-authored-by: Francesco Fagnani <fagnani.francesco@gmail.com>
…etics/sync_global_params_spaces.ts

Co-authored-by: Francesco Fagnani <fagnani.francesco@gmail.com>
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #129 / Air-gapped environment with pre-bundled packages @ess @serverless @skipInServerlessMKI Install bundled package should install prebuilt rules from the package that comes bundled with Kibana

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
@kbn/test-suites-xpack-observability 15 14 -1

Total ESLint disabled count

id before after diff
@kbn/test-suites-xpack-observability 18 17 -1

History

@shahzad31 shahzad31 merged commit b7ada92 into elastic:main Aug 4, 2025
12 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.18, 8.19, 9.0, 9.1

https://github.com/elastic/kibana/actions/runs/16722971576

@shahzad31 shahzad31 removed the v8.18.5 label Aug 4, 2025
@shahzad31 shahzad31 deleted the fix-global-sync branch August 4, 2025 12:24
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 4, 2025
… !! (elastic#230157)

## Summary

Fix global params sync for non default private locations !!

Make sure in sync task when querying for locations it uses all spaces.

Fixes elastic#230366

### API tests
i have added e2e tests to make sure it covers the use-case

---------

Co-authored-by: Francesco Fagnani <fagnani.francesco@gmail.com>
(cherry picked from commit b7ada92)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 4, 2025
… !! (elastic#230157)

## Summary

Fix global params sync for non default private locations !!

Make sure in sync task when querying for locations it uses all spaces.

Fixes elastic#230366

### API tests
i have added e2e tests to make sure it covers the use-case

---------

Co-authored-by: Francesco Fagnani <fagnani.francesco@gmail.com>
(cherry picked from commit b7ada92)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
8.18 Backport failed because of merge conflicts
8.19
9.0 Backport failed because of merge conflicts
9.1

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 230157

Questions ?

Please refer to the Backport tool documentation

@shahzad31 shahzad31 removed the v9.0.5 label Aug 4, 2025
kibanamachine added a commit that referenced this pull request Aug 4, 2025
…cations !! (#230157) (#230405)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[Synthetics] Fix global params sync for non default private locations
!! (#230157)](#230157)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT
[{"author":{"name":"Shahzad","email":"shahzad31comp@gmail.com"},"sourceCommit":{"committedDate":"2025-08-04T12:20:28Z","message":"[Synthetics]
Fix global params sync for non default private locations !!
(#230157)\n\n## Summary\n\nFix global params sync for non default
private locations !!\n\nMake sure in sync task when querying for
locations it uses all spaces.\n\nFixes
https://github.com/elastic/kibana/issues/230366\n\n\n### API tests\ni
have added e2e tests to make sure it covers the
use-case\n\n---------\n\nCo-authored-by: Francesco Fagnani
<fagnani.francesco@gmail.com>","sha":"b7ada9298135853afdf571705b203add45d4b445","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:obs-ux-management","backport:version","author:obs-ux-management","v9.2.0","v9.0.5","v9.1.1","v8.18.5","v8.19.1"],"title":"[Synthetics]
Fix global params sync for non default private locations
!!","number":230157,"url":"https://github.com/elastic/kibana/pull/230157","mergeCommit":{"message":"[Synthetics]
Fix global params sync for non default private locations !!
(#230157)\n\n## Summary\n\nFix global params sync for non default
private locations !!\n\nMake sure in sync task when querying for
locations it uses all spaces.\n\nFixes
https://github.com/elastic/kibana/issues/230366\n\n\n### API tests\ni
have added e2e tests to make sure it covers the
use-case\n\n---------\n\nCo-authored-by: Francesco Fagnani
<fagnani.francesco@gmail.com>","sha":"b7ada9298135853afdf571705b203add45d4b445"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","9.1","8.18","8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/230157","number":230157,"mergeCommit":{"message":"[Synthetics]
Fix global params sync for non default private locations !!
(#230157)\n\n## Summary\n\nFix global params sync for non default
private locations !!\n\nMake sure in sync task when querying for
locations it uses all spaces.\n\nFixes
https://github.com/elastic/kibana/issues/230366\n\n\n### API tests\ni
have added e2e tests to make sure it covers the
use-case\n\n---------\n\nCo-authored-by: Francesco Fagnani
<fagnani.francesco@gmail.com>","sha":"b7ada9298135853afdf571705b203add45d4b445"}},{"branch":"9.0","label":"v9.0.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Shahzad <shahzad31comp@gmail.com>
Co-authored-by: Francesco Fagnani <fagnani.francesco@gmail.com>
szaffarano pushed a commit to szaffarano/kibana that referenced this pull request Aug 5, 2025
… !! (elastic#230157)

## Summary

Fix global params sync for non default private locations !!

Make sure in sync task when querying for locations it uses all spaces.

Fixes elastic#230366


### API tests
i have added e2e tests to make sure it covers the use-case

---------

Co-authored-by: Francesco Fagnani <fagnani.francesco@gmail.com>
kibanamachine added a commit that referenced this pull request Aug 5, 2025
…ations !! (#230157) (#230406)

# Backport

This will backport the following commits from `main` to `9.1`:
- [[Synthetics] Fix global params sync for non default private locations
!! (#230157)](#230157)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT
[{"author":{"name":"Shahzad","email":"shahzad31comp@gmail.com"},"sourceCommit":{"committedDate":"2025-08-04T12:20:28Z","message":"[Synthetics]
Fix global params sync for non default private locations !!
(#230157)\n\n## Summary\n\nFix global params sync for non default
private locations !!\n\nMake sure in sync task when querying for
locations it uses all spaces.\n\nFixes
https://github.com/elastic/kibana/issues/230366\n\n\n### API tests\ni
have added e2e tests to make sure it covers the
use-case\n\n---------\n\nCo-authored-by: Francesco Fagnani
<fagnani.francesco@gmail.com>","sha":"b7ada9298135853afdf571705b203add45d4b445","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:obs-ux-management","backport:version","author:obs-ux-management","v9.2.0","v9.0.5","v9.1.1","v8.18.5","v8.19.1"],"title":"[Synthetics]
Fix global params sync for non default private locations
!!","number":230157,"url":"https://github.com/elastic/kibana/pull/230157","mergeCommit":{"message":"[Synthetics]
Fix global params sync for non default private locations !!
(#230157)\n\n## Summary\n\nFix global params sync for non default
private locations !!\n\nMake sure in sync task when querying for
locations it uses all spaces.\n\nFixes
https://github.com/elastic/kibana/issues/230366\n\n\n### API tests\ni
have added e2e tests to make sure it covers the
use-case\n\n---------\n\nCo-authored-by: Francesco Fagnani
<fagnani.francesco@gmail.com>","sha":"b7ada9298135853afdf571705b203add45d4b445"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","9.1","8.18","8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/230157","number":230157,"mergeCommit":{"message":"[Synthetics]
Fix global params sync for non default private locations !!
(#230157)\n\n## Summary\n\nFix global params sync for non default
private locations !!\n\nMake sure in sync task when querying for
locations it uses all spaces.\n\nFixes
https://github.com/elastic/kibana/issues/230366\n\n\n### API tests\ni
have added e2e tests to make sure it covers the
use-case\n\n---------\n\nCo-authored-by: Francesco Fagnani
<fagnani.francesco@gmail.com>","sha":"b7ada9298135853afdf571705b203add45d4b445"}},{"branch":"9.0","label":"v9.0.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Shahzad <shahzad31comp@gmail.com>
Co-authored-by: Francesco Fagnani <fagnani.francesco@gmail.com>
delanni pushed a commit to delanni/kibana that referenced this pull request Aug 5, 2025
… !! (elastic#230157)

## Summary

Fix global params sync for non default private locations !!

Make sure in sync task when querying for locations it uses all spaces.

Fixes elastic#230366


### API tests
i have added e2e tests to make sure it covers the use-case

---------

Co-authored-by: Francesco Fagnani <fagnani.francesco@gmail.com>
@wildemat wildemat mentioned this pull request Aug 7, 2025
10 tasks
@mistic mistic added v9.1.2 and removed v9.1.1 labels Aug 7, 2025
NicholasPeretti pushed a commit to NicholasPeretti/kibana that referenced this pull request Aug 18, 2025
… !! (elastic#230157)

## Summary

Fix global params sync for non default private locations !!

Make sure in sync task when querying for locations it uses all spaces.

Fixes elastic#230366


### API tests
i have added e2e tests to make sure it covers the use-case

---------

Co-authored-by: Francesco Fagnani <fagnani.francesco@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author:obs-ux-management PRs authored by the obs ux management team backport:version Backport to applied version labels release_note:fix Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. v8.19.1 v9.1.2 v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Synthetics] Global params sync is broken for non default spaces

6 participants