-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Observability Nav] [Serverless Nav] remove apm link from application nav section #230152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Observability Nav] [Serverless Nav] remove apm link from application nav section #230152
Conversation
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
ab687fb to
3e95c79
Compare
|
In the All Apps screenshot, we are missing Uptime, i guess that's because Uptime was not enabled but just want to confirm |
kdelemme
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally on stateful and works as expected
⏳ Build in-progress
History
|
|
Starting backport for target branches: 8.17, 8.18, 8.19, 9.0, 9.1 https://github.com/elastic/kibana/actions/runs/16687582513 |
… nav section (elastic#230152) (cherry picked from commit 066e673)
… nav section (elastic#230152) (cherry picked from commit 066e673)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
…cation nav section (#230152) (#230330) # Backport This will backport the following commits from `main` to `9.1`: - [[Observability Nav] [Serverless Nav] remove apm link from application nav section (#230152)](#230152) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Bailey Cash","email":"bailey.cash@elastic.co"},"sourceCommit":{"committedDate":"2025-08-02T00:07:44Z","message":"[Observability Nav] [Serverless Nav] remove apm link from application nav section (#230152)","sha":"066e673bad504351006a45e069b802f42dbcdd73","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","ci:project-deploy-observability","Team:obs-ux-management","backport:version","author:obs-ux-management","v9.2.0","v9.0.5","v9.1.1","v8.17.10","v8.18.5","v8.19.1"],"title":"[Observability Nav] [Serverless Nav] remove apm link from application nav section","number":230152,"url":"https://github.com/elastic/kibana/pull/230152","mergeCommit":{"message":"[Observability Nav] [Serverless Nav] remove apm link from application nav section (#230152)","sha":"066e673bad504351006a45e069b802f42dbcdd73"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","9.1","8.17","8.18","8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/230152","number":230152,"mergeCommit":{"message":"[Observability Nav] [Serverless Nav] remove apm link from application nav section (#230152)","sha":"066e673bad504351006a45e069b802f42dbcdd73"}},{"branch":"9.0","label":"v9.0.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.10","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Bailey Cash <bailey.cash@elastic.co>
… nav section (elastic#230152) (cherry picked from commit 066e673) # Conflicts: # x-pack/solutions/observability/plugins/observability/public/navigation_tree.ts # x-pack/solutions/observability/plugins/serverless_observability/public/navigation_tree.ts # x-pack/test/functional_solution_sidenav/tests/observability_sidenav.ts
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
… nav section (elastic#230152) (cherry picked from commit 066e673) # Conflicts: # x-pack/solutions/observability/plugins/observability/public/navigation_tree.ts # x-pack/solutions/observability/plugins/serverless_observability/public/navigation_tree.ts # x-pack/test/functional_solution_sidenav/tests/observability_sidenav.ts
… nav section (elastic#230152) (cherry picked from commit 066e673) # Conflicts: # x-pack/plugins/observability_solution/observability/public/navigation_tree.ts # x-pack/solutions/observability/plugins/serverless_observability/public/navigation_tree.ts # x-pack/test/functional_solution_sidenav/tests/observability_sidenav.ts
…ication nav section (#230152) (#230329) # Backport This will backport the following commits from `main` to `8.19`: - [[Observability Nav] [Serverless Nav] remove apm link from application nav section (#230152)](#230152) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Bailey Cash","email":"bailey.cash@elastic.co"},"sourceCommit":{"committedDate":"2025-08-02T00:07:44Z","message":"[Observability Nav] [Serverless Nav] remove apm link from application nav section (#230152)","sha":"066e673bad504351006a45e069b802f42dbcdd73","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","ci:project-deploy-observability","Team:obs-ux-management","backport:version","author:obs-ux-management","v9.2.0","v9.0.5","v9.1.1","v8.17.10","v8.18.5","v8.19.1"],"title":"[Observability Nav] [Serverless Nav] remove apm link from application nav section","number":230152,"url":"https://github.com/elastic/kibana/pull/230152","mergeCommit":{"message":"[Observability Nav] [Serverless Nav] remove apm link from application nav section (#230152)","sha":"066e673bad504351006a45e069b802f42dbcdd73"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","9.1","8.17","8.18","8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/230152","number":230152,"mergeCommit":{"message":"[Observability Nav] [Serverless Nav] remove apm link from application nav section (#230152)","sha":"066e673bad504351006a45e069b802f42dbcdd73"}},{"branch":"9.0","label":"v9.0.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.10","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Bailey Cash <bailey.cash@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
I'm removing the backports for 8.17, 8.18, and 9.0 due to discrepancies with the nav structure and rendering. Providing the application section with the same id rendered different components than in 8.19 and 9.1. This may explain why links were added to the code to tie the section to |

Summary
Closes #227833
Fix: The entire applications section of the observability solution nav was tied to the apm feature capability. I moved the link to the apm child.