Skip to content

Conversation

@baileycash-elastic
Copy link
Contributor

@baileycash-elastic baileycash-elastic commented Aug 1, 2025

Summary

Closes #227833

Fix: The entire applications section of the observability solution nav was tied to the apm feature capability. I moved the link to the apm child.

Screenshot 2025-07-31 at 11 13 45 PM Screenshot 2025-07-31 at 11 14 27 PM Screenshot 2025-07-31 at 11 15 26 PM Screenshot 2025-07-31 at 11 28 33 PM

@baileycash-elastic baileycash-elastic added release_note:skip Skip the PR/issue when compiling release notes Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. labels Aug 1, 2025
@baileycash-elastic baileycash-elastic requested a review from a team as a code owner August 1, 2025 03:19
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Aug 1, 2025
@github-actions github-actions bot added the author:obs-ux-management PRs authored by the obs ux management team label Aug 1, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2025

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@baileycash-elastic baileycash-elastic changed the title remove apm link from application nav section [Observability Nav] [Serverless Nav] remove apm link from application nav section Aug 1, 2025
@baileycash-elastic baileycash-elastic requested a review from a team August 1, 2025 03:26
@kdelemme
Copy link
Contributor

kdelemme commented Aug 1, 2025

In the All Apps screenshot, we are missing Uptime, i guess that's because Uptime was not enabled but just want to confirm

@baileycash-elastic
Copy link
Contributor Author

baileycash-elastic commented Aug 1, 2025

In the All Apps screenshot, we are missing Uptime, i guess that's because Uptime was not enabled but just want to confirm

Great callout. I did check, it's unchanged from main. I'm assuming it has to do with the way superuser permissions are setup

Screenshot 2025-08-01 at 10 06 07 AM

Copy link
Contributor

@kdelemme kdelemme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally on stateful and works as expected

@elasticmachine
Copy link
Contributor

⏳ Build in-progress

  • Buildkite Build
  • Commit: 89a16d8
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-230152-89a16d8cd6b7

History

@baileycash-elastic baileycash-elastic merged commit 066e673 into elastic:main Aug 2, 2025
12 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.17, 8.18, 8.19, 9.0, 9.1

https://github.com/elastic/kibana/actions/runs/16687582513

@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
8.17 Backport failed because of merge conflicts
8.18 Backport failed because of merge conflicts
8.19
9.0 Backport failed because of merge conflicts
9.1

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 230152

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Aug 2, 2025
…cation nav section (#230152) (#230330)

# Backport

This will backport the following commits from `main` to `9.1`:
- [[Observability Nav] [Serverless Nav] remove apm link from application
nav section (#230152)](#230152)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Bailey
Cash","email":"bailey.cash@elastic.co"},"sourceCommit":{"committedDate":"2025-08-02T00:07:44Z","message":"[Observability
Nav] [Serverless Nav] remove apm link from application nav section
(#230152)","sha":"066e673bad504351006a45e069b802f42dbcdd73","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","ci:project-deploy-observability","Team:obs-ux-management","backport:version","author:obs-ux-management","v9.2.0","v9.0.5","v9.1.1","v8.17.10","v8.18.5","v8.19.1"],"title":"[Observability
Nav] [Serverless Nav] remove apm link from application nav
section","number":230152,"url":"https://github.com/elastic/kibana/pull/230152","mergeCommit":{"message":"[Observability
Nav] [Serverless Nav] remove apm link from application nav section
(#230152)","sha":"066e673bad504351006a45e069b802f42dbcdd73"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","9.1","8.17","8.18","8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/230152","number":230152,"mergeCommit":{"message":"[Observability
Nav] [Serverless Nav] remove apm link from application nav section
(#230152)","sha":"066e673bad504351006a45e069b802f42dbcdd73"}},{"branch":"9.0","label":"v9.0.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.10","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Bailey Cash <bailey.cash@elastic.co>
baileycash-elastic added a commit to baileycash-elastic/kibana that referenced this pull request Aug 4, 2025
… nav section (elastic#230152)

(cherry picked from commit 066e673)

# Conflicts:
#	x-pack/solutions/observability/plugins/observability/public/navigation_tree.ts
#	x-pack/solutions/observability/plugins/serverless_observability/public/navigation_tree.ts
#	x-pack/test/functional_solution_sidenav/tests/observability_sidenav.ts
@baileycash-elastic
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
9.0
8.18
8.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

baileycash-elastic added a commit to baileycash-elastic/kibana that referenced this pull request Aug 4, 2025
… nav section (elastic#230152)

(cherry picked from commit 066e673)

# Conflicts:
#	x-pack/solutions/observability/plugins/observability/public/navigation_tree.ts
#	x-pack/solutions/observability/plugins/serverless_observability/public/navigation_tree.ts
#	x-pack/test/functional_solution_sidenav/tests/observability_sidenav.ts
baileycash-elastic added a commit to baileycash-elastic/kibana that referenced this pull request Aug 4, 2025
… nav section (elastic#230152)

(cherry picked from commit 066e673)

# Conflicts:
#	x-pack/plugins/observability_solution/observability/public/navigation_tree.ts
#	x-pack/solutions/observability/plugins/serverless_observability/public/navigation_tree.ts
#	x-pack/test/functional_solution_sidenav/tests/observability_sidenav.ts
kibanamachine added a commit that referenced this pull request Aug 4, 2025
…ication nav section (#230152) (#230329)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[Observability Nav] [Serverless Nav] remove apm link from application
nav section (#230152)](#230152)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Bailey
Cash","email":"bailey.cash@elastic.co"},"sourceCommit":{"committedDate":"2025-08-02T00:07:44Z","message":"[Observability
Nav] [Serverless Nav] remove apm link from application nav section
(#230152)","sha":"066e673bad504351006a45e069b802f42dbcdd73","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","ci:project-deploy-observability","Team:obs-ux-management","backport:version","author:obs-ux-management","v9.2.0","v9.0.5","v9.1.1","v8.17.10","v8.18.5","v8.19.1"],"title":"[Observability
Nav] [Serverless Nav] remove apm link from application nav
section","number":230152,"url":"https://github.com/elastic/kibana/pull/230152","mergeCommit":{"message":"[Observability
Nav] [Serverless Nav] remove apm link from application nav section
(#230152)","sha":"066e673bad504351006a45e069b802f42dbcdd73"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","9.1","8.17","8.18","8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/230152","number":230152,"mergeCommit":{"message":"[Observability
Nav] [Serverless Nav] remove apm link from application nav section
(#230152)","sha":"066e673bad504351006a45e069b802f42dbcdd73"}},{"branch":"9.0","label":"v9.0.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.10","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Bailey Cash <bailey.cash@elastic.co>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 5, 2025
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @baileycash-elastic

szaffarano pushed a commit to szaffarano/kibana that referenced this pull request Aug 5, 2025
@baileycash-elastic baileycash-elastic added v9.1.1 and removed v9.1.1 v8.17.10 v8.18.5 backport missing Added to PRs automatically when the are determined to be missing a backport. v9.0.5 labels Aug 5, 2025
@baileycash-elastic
Copy link
Contributor Author

baileycash-elastic commented Aug 5, 2025

I'm removing the backports for 8.17, 8.18, and 9.0 due to discrepancies with the nav structure and rendering. Providing the application section with the same id rendered different components than in 8.19 and 9.1. This may explain why links were added to the code to tie the section to apm:services.

delanni pushed a commit to delanni/kibana that referenced this pull request Aug 5, 2025
@wildemat wildemat mentioned this pull request Aug 7, 2025
10 tasks
NicholasPeretti pushed a commit to NicholasPeretti/kibana that referenced this pull request Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author:obs-ux-management PRs authored by the obs ux management team backport:version Backport to applied version labels ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. v8.19.1 v9.1.1 v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Observability] [Stateful Solution Nav] [Serverless] "Applications" link is missing for user with only Synthetics privileges

4 participants