Skip to content

[Defend Workflows][Policy Details] Fix padding on settings cards #230124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
parkiino merged 3 commits into from
Aug 4, 2025
Merged

[Defend Workflows][Policy Details] Fix padding on settings cards #230124

parkiino merged 3 commits into from
Aug 4, 2025

Conversation

@parkiino
Copy link
Contributor

@parkiino parkiino commented Jul 31, 2025 •
edited by kibanamachine
Loading

Summary

  • Fixes a bug in the policy details page where some cards didn't have the proper spacing between the bottom card border and the last bit of content

Screenshots

image image

The cards that originally did not have spacing issues still look the same
image

@parkiino parkiino requested a review from a team as a code owner July 31, 2025 18:57
@parkiino parkiino added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution labels Jul 31, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 31, 2025

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

@parkiino parkiino added v9.2.0 backport:version Backport to applied version labels v9.1.0 labels Jul 31, 2025
gergoabraham
gergoabraham approved these changes Aug 4, 2025
View reviewed changes
Copy link
Contributor

@gergoabraham gergoabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks for the changes! 🚀

@elasticmachine
Copy link
Contributor

elasticmachine commented Aug 4, 2025

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 10.3MB 10.3MB -136.0B

History

@parkiino parkiino merged commit 32e9c29 into elastic:main Aug 4, 2025
12 checks passed
@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 4, 2025

Starting backport for target branches: 9.1

https://github.com/elastic/kibana/actions/runs/16731905138

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 4, 2025
@parkiino
[Defend Workflows][Policy Details] Fix padding on settings cards (ela…
77396f0 
…stic#230124)

## Summary

- [x] Fixes a bug in the policy details page where some cards didn't
have the proper spacing between the bottom card border and the last bit
of content

# Screenshots

<img width="1777" height="909" alt="image"
src="https://github.com/user-attachments/assets/83b7c4c3-8b24-4854-a207-c3078fcd4c22"
/>
<img width="1665" height="872" alt="image"
src="https://github.com/user-attachments/assets/a42e31bd-226c-40a7-88dd-484196f34910"
/>

The cards that originally did not have spacing issues still look the
same
<img width="1269" height="780" alt="image"
src="https://github.com/user-attachments/assets/1fd28a16-01c7-403e-9c08-c8f71cee502a"
/>

(cherry picked from commit 32e9c29)
@kibanamachine kibanamachine mentioned this pull request Aug 4, 2025
Merged
@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 4, 2025

💚 All backports created successfully

Status Branch Result
✅ 9.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Aug 4, 2025
@kibanamachine @parkiino
[9.1] [Defend Workflows][Policy Details] Fix padding on settings cards (
78dc035 
#230124) (#230464)

# Backport

This will backport the following commits from `main` to `9.1`:
- [[Defend Workflows][Policy Details] Fix padding on settings cards
(#230124)](#230124)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Candace
Park","email":"56409205+parkiino@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-08-04T19:06:17Z","message":"[Defend
Workflows][Policy Details] Fix padding on settings cards (#230124)\n\n##
Summary\n\n- [x] Fixes a bug in the policy details page where some cards
didn't\nhave the proper spacing between the bottom card border and the
last bit\nof content\n\n# Screenshots\n\n<img width=\"1777\"
height=\"909\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/83b7c4c3-8b24-4854-a207-c3078fcd4c22\"\n/>\n<img
width=\"1665\" height=\"872\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/a42e31bd-226c-40a7-88dd-484196f34910\"\n/>\n\nThe
cards that originally did not have spacing issues still look
the\nsame\n<img width=\"1269\" height=\"780\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/1fd28a16-01c7-403e-9c08-c8f71cee502a\"\n/>","sha":"32e9c29b14c8af81b2609402df46578d1ce2b9a5","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend
Workflows","backport:version","v9.1.0","v9.2.0"],"title":"[Defend
Workflows][Policy Details] Fix padding on settings
cards","number":230124,"url":"https://github.com/elastic/kibana/pull/230124","mergeCommit":{"message":"[Defend
Workflows][Policy Details] Fix padding on settings cards (#230124)\n\n##
Summary\n\n- [x] Fixes a bug in the policy details page where some cards
didn't\nhave the proper spacing between the bottom card border and the
last bit\nof content\n\n# Screenshots\n\n<img width=\"1777\"
height=\"909\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/83b7c4c3-8b24-4854-a207-c3078fcd4c22\"\n/>\n<img
width=\"1665\" height=\"872\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/a42e31bd-226c-40a7-88dd-484196f34910\"\n/>\n\nThe
cards that originally did not have spacing issues still look
the\nsame\n<img width=\"1269\" height=\"780\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/1fd28a16-01c7-403e-9c08-c8f71cee502a\"\n/>","sha":"32e9c29b14c8af81b2609402df46578d1ce2b9a5"}},"sourceBranch":"main","suggestedTargetBranches":["9.1"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/230124","number":230124,"mergeCommit":{"message":"[Defend
Workflows][Policy Details] Fix padding on settings cards (#230124)\n\n##
Summary\n\n- [x] Fixes a bug in the policy details page where some cards
didn't\nhave the proper spacing between the bottom card border and the
last bit\nof content\n\n# Screenshots\n\n<img width=\"1777\"
height=\"909\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/83b7c4c3-8b24-4854-a207-c3078fcd4c22\"\n/>\n<img
width=\"1665\" height=\"872\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/a42e31bd-226c-40a7-88dd-484196f34910\"\n/>\n\nThe
cards that originally did not have spacing issues still look
the\nsame\n<img width=\"1269\" height=\"780\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/1fd28a16-01c7-403e-9c08-c8f71cee502a\"\n/>","sha":"32e9c29b14c8af81b2609402df46578d1ce2b9a5"}}]}]
BACKPORT-->

Co-authored-by: Candace Park <56409205+parkiino@users.noreply.github.com>
@parkiino parkiino deleted the bug/policy-details-spacing branch August 4, 2025 21:08
szaffarano pushed a commit to szaffarano/kibana that referenced this pull request Aug 5, 2025
@parkiino @szaffarano
[Defend Workflows][Policy Details] Fix padding on settings cards (ela…
a150cc4 
…stic#230124)

## Summary

- [x] Fixes a bug in the policy details page where some cards didn't
have the proper spacing between the bottom card border and the last bit
of content

# Screenshots

<img width="1777" height="909" alt="image"
src="https://github.com/user-attachments/assets/83b7c4c3-8b24-4854-a207-c3078fcd4c22"
/>
<img width="1665" height="872" alt="image"
src="https://github.com/user-attachments/assets/a42e31bd-226c-40a7-88dd-484196f34910"
/>

The cards that originally did not have spacing issues still look the
same
<img width="1269" height="780" alt="image"
src="https://github.com/user-attachments/assets/1fd28a16-01c7-403e-9c08-c8f71cee502a"
/>
delanni pushed a commit to delanni/kibana that referenced this pull request Aug 5, 2025
@parkiino @delanni
[Defend Workflows][Policy Details] Fix padding on settings cards (ela…
8f19fae 
…stic#230124)

## Summary

- [x] Fixes a bug in the policy details page where some cards didn't
have the proper spacing between the bottom card border and the last bit
of content

# Screenshots

<img width="1777" height="909" alt="image"
src="https://github.com/user-attachments/assets/83b7c4c3-8b24-4854-a207-c3078fcd4c22"
/>
<img width="1665" height="872" alt="image"
src="https://github.com/user-attachments/assets/a42e31bd-226c-40a7-88dd-484196f34910"
/>

The cards that originally did not have spacing issues still look the
same
<img width="1269" height="780" alt="image"
src="https://github.com/user-attachments/assets/1fd28a16-01c7-403e-9c08-c8f71cee502a"
/>
@wildemat wildemat mentioned this pull request Aug 7, 2025
Closed
10 tasks
NicholasPeretti pushed a commit to NicholasPeretti/kibana that referenced this pull request Aug 18, 2025
@parkiino @NicholasPeretti
[Defend Workflows][Policy Details] Fix padding on settings cards (ela…
ed96b15 
…stic#230124)

## Summary

- [x] Fixes a bug in the policy details page where some cards didn't
have the proper spacing between the bottom card border and the last bit
of content

# Screenshots

<img width="1777" height="909" alt="image"
src="https://github.com/user-attachments/assets/83b7c4c3-8b24-4854-a207-c3078fcd4c22"
/>
<img width="1665" height="872" alt="image"
src="https://github.com/user-attachments/assets/a42e31bd-226c-40a7-88dd-484196f34910"
/>

The cards that originally did not have spacing issues still look the
same
<img width="1269" height="780" alt="image"
src="https://github.com/user-attachments/assets/1fd28a16-01c7-403e-9c08-c8f71cee502a"
/>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gergoabraham gergoabraham gergoabraham approved these changes

@tomsonpl tomsonpl Awaiting requested review from tomsonpl tomsonpl is a code owner automatically assigned from elastic/security-defend-workflows

Assignees

No one assigned

Labels

backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v9.1.0 v9.1.1 v9.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@parkiino @elasticmachine @kibanamachine @gergoabraham