[ES|QL] Incorrect filtering logic when removing comment field #230116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartoval
added
release_note:fix
backport:skip
Contributor
|
Pinging @elastic/kibana-esql (Team:ESQL) |
bartoval
force-pushed
the
esql_fix_wrong_comment_filter
branch
from
ab7140c to
1123e07
Compare
stratoula
approved these changes
Aug 1, 2025
szaffarano
pushed a commit
to szaffarano/kibana
that referenced
this pull request
Aug 5, 2025
…c#230116) ## Summary The previous implementation incorrectly used .filter() resulting in no actual filtering of the comment field but every row. Replaced with .map() to properly exclude comment and return a correctly typed object. test: - remove the autogenerated file `src/platform/packages/shared/kbn-esql-ast/src/definitions/generated/commands/commands.ts` - then run the script - a new file commands file will be created
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
Aug 5, 2025
…c#230116) ## Summary The previous implementation incorrectly used .filter() resulting in no actual filtering of the comment field but every row. Replaced with .map() to properly exclude comment and return a correctly typed object. test: - remove the autogenerated file `src/platform/packages/shared/kbn-esql-ast/src/definitions/generated/commands/commands.ts` - then run the script - a new file commands file will be created
NicholasPeretti
pushed a commit
to NicholasPeretti/kibana
that referenced
this pull request
Aug 18, 2025
…c#230116) ## Summary The previous implementation incorrectly used .filter() resulting in no actual filtering of the comment field but every row. Replaced with .map() to properly exclude comment and return a correctly typed object. test: - remove the autogenerated file `src/platform/packages/shared/kbn-esql-ast/src/definitions/generated/commands/commands.ts` - then run the script - a new file commands file will be created
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The previous implementation incorrectly used .filter() resulting in no actual filtering of the comment field but every row.
Replaced with .map() to properly exclude comment and return a correctly typed object.
test:
src/platform/packages/shared/kbn-esql-ast/src/definitions/generated/commands/commands.ts