Fix for Distribution Bar Filter Segments #230084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
animehart
added
Team:Cloud Security
Contributor
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
opauloh
reviewed
Jul 31, 2025
Contributor
opauloh
left a comment
opauloh
left a comment
There was a problem hiding this comment.
Nice work, just a few suggestions
| const parts = stats.map((stat) => { | ||
|
|
||
| const [hoveredKey, setHoveredKey] = useState<string | null>(null); | ||
| const hasCurrentFilter = stats.some((item) => item.isCurrentFilter === true); |
Contributor
There was a problem hiding this comment.
nit: add useMemo to prevent recalculating on every render.:
Suggested change
| const hasCurrentFilter = stats.some((item) => item.isCurrentFilter === true); | |
| const hasCurrentFilter = useMemo( | |
| () => stats.some((item) => item.isCurrentFilter), | |
| [stats] | |
| ); | |
Comment on lines
151
to
155
| // Only show tooltip for segments thats hovered OR Set as Filter OR Last | ||
| const showTooltip = | ||
| isHovered || | ||
| (!hoveredKey && | ||
| ((stat.isCurrentFilter ?? false) || (!hideLastTooltip && !hasCurrentFilter && isLast))); |
Contributor
There was a problem hiding this comment.
So the complexity grew here and there are a few business logic in these lines, I suggest splitting into a separate function with each condition split into variables, example (feel free to improve):
// Only show tooltip for segments thats hovered OR Set as Filter OR Last
const shouldShowTooltip = ({
isHovered,
isCurrentFilter,
isLast,
hasFilterActive,
hideLastTooltip,
isHoveringAnyStatsBar,
}: {
isHovered: boolean;
isCurrentFilter: boolean;
isLast: boolean;
hasFilterActive: boolean;
hideLastTooltip?: boolean;
isHoveringAnyStatsBar: boolean;
}) => {
if (isHovered) return true;
const shouldShowBecauseOfFilter = isCurrentFilter;
const shouldShowBecauseItIsLast = isLast && !hideLastTooltip && !hasFilterActive;
return !isHoveringAnyStatsBar && (shouldShowBecauseOfFilter || shouldShowBecauseItIsLast);
};usage
const isCurrentFilter = stat.isCurrentFilter ?? false;
const showTooltip = shouldShowTooltip({
isHovered,
isCurrentFilter,
isLast,
hasFilterActive: hasCurrentFilter,
hideLastTooltip,
isHoveringAnyStatsBar: Boolean(hoveredKey),
});…bana into fix-distribution-bar-filter
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
szaffarano
pushed a commit
to szaffarano/kibana
that referenced
this pull request
Aug 5, 2025
## Summary This PR addresses the Issue where after user clicks on Distribution bar segments to filter data, the tooltips defaults to Last Segment instead of Chosen filter (It should only default to Last segment IF there are no filter) https://github.com/user-attachments/assets/c3dbc3ac-846d-41ea-8a9a-6b05c53a7cab
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
Aug 5, 2025
## Summary This PR addresses the Issue where after user clicks on Distribution bar segments to filter data, the tooltips defaults to Last Segment instead of Chosen filter (It should only default to Last segment IF there are no filter) https://github.com/user-attachments/assets/c3dbc3ac-846d-41ea-8a9a-6b05c53a7cab
NicholasPeretti
pushed a commit
to NicholasPeretti/kibana
that referenced
this pull request
Aug 18, 2025
## Summary This PR addresses the Issue where after user clicks on Distribution bar segments to filter data, the tooltips defaults to Last Segment instead of Chosen filter (It should only default to Last segment IF there are no filter) https://github.com/user-attachments/assets/c3dbc3ac-846d-41ea-8a9a-6b05c53a7cab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the Issue where after user clicks on Distribution bar segments to filter data, the tooltips defaults to Last Segment instead of Chosen filter (It should only default to Last segment IF there are no filter)
Screen.Recording.2025-07-30.at.8.11.25.PM.mov