[ResponseOps][Rules] Prevent internally managed rule types to be created from the Rule Create API #230066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnasikas
added
Feature:Alerting
release_note:skip
cnasikas
added
backport:skip
Contributor
|
Pinging @elastic/response-ops (Team:ResponseOps) |
cnasikas
changed the title
adcoelho
approved these changes
Aug 1, 2025
Member
Author
|
@elasticmachine merge upstream |
js-jankisalvi
approved these changes
Aug 4, 2025
…sikas/kibana into prevent_creation_internal_rule_types
jcger
reviewed
Aug 4, 2025
| const ruleType = ruleTypes.get(createRuleData.rule_type_id); | ||
|
|
||
| /** | ||
| * Throws a bad request (400) if the rule type is internallyManaged |
Contributor
There was a problem hiding this comment.
why 400? I think 403 would be more fitting:
In https://www.rfc-editor.org/rfc/rfc9110#status.403
However, a request might be forbidden for reasons unrelated to the credentials.
| if (ruleType?.internallyManaged) { | ||
| return res.badRequest({ | ||
| body: { | ||
| message: `Cannot create rule of type "${createRuleData.rule_type_id}" because it is internally managed.`, |
Contributor
There was a problem hiding this comment.
shouldn't this message be translated? or is it only messages we show in the ui? nvm
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
cc @cnasikas |
szaffarano
pushed a commit
to szaffarano/kibana
that referenced
this pull request
Aug 5, 2025
…ted from the Rule Create API (elastic#230066) ## Summary This PR prevents internally managed rule types from being created through the Rule Create API. The prevention logic is on he route level because we want to support creating internally managed rules from the alerts client. Fixes: elastic#221382 ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
Aug 5, 2025
…ted from the Rule Create API (elastic#230066) ## Summary This PR prevents internally managed rule types from being created through the Rule Create API. The prevention logic is on he route level because we want to support creating internally managed rules from the alerts client. Fixes: elastic#221382 ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
NicholasPeretti
pushed a commit
to NicholasPeretti/kibana
that referenced
this pull request
Aug 18, 2025
…ted from the Rule Create API (elastic#230066) ## Summary This PR prevents internally managed rule types from being created through the Rule Create API. The prevention logic is on he route level because we want to support creating internally managed rules from the alerts client. Fixes: elastic#221382 ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR prevents internally managed rule types from being created through the Rule Create API. The prevention logic is on he route level because we want to support creating internally managed rules from the alerts client.
Fixes: #221382
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.