Skip to content

🌊 Streams: Fix classic streams ingest pipeline manipulation #230053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
flash1293 merged 4 commits into from
Jul 31, 2025
Merged

🌊 Streams: Fix classic streams ingest pipeline manipulation #230053

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
db6effa
strip out keys that are not allowed
flash1293 Jul 31, 2025
aec23a0
Merge remote-tracking branch 'upstream/main' into flash1293/fix-strea…
flash1293 Jul 31, 2025
6285a55
improve fix
flash1293 Jul 31, 2025
e87ad5a
fix
flash1293 Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion x-pack/platform/plugins/private/translations/translations/de-DE.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28368,7 +28368,6 @@
"xpack.ml.overview.nodesPanel.ariaLabel": "Überblick-Panel",
"xpack.ml.overview.nodesPanel.header": "Knoten",
"xpack.ml.overview.nodesPanel.totalNodesLabel": "Insgesamt",
"xpack.ml.overview.nodesPanel.viewNodeLink": "Knoten anzeigen",
"xpack.ml.overview.overviewLabel": "Überblick",
"xpack.ml.overview.statsBar.failedAnalyticsLabel": "Fehlgeschlagen",
"xpack.ml.overview.statsBar.runningAnalyticsLabel": "Wird ausgeführt",
Expand Down
4 changes: 4 additions & 0 deletions ...streams/state_management/execution_plan/translate_classic_stream_pipeline_actions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -703,6 +703,10 @@ describe('translateClassicStreamPipelineActions', () => {
.mockImplementationOnce(async () => {
return {
'my-template-pipeline': {
created_date_millis: 123456789,
created_date: '2023-10-01T00:00:00.000Z',
modified_date_millis: 123456789,
modified_date: '2023-10-01T00:00:00.000Z',
processors: [
{
set: {
Expand Down
34 changes: 24 additions & 10 deletions .../lib/streams/state_management/execution_plan/translate_classic_stream_pipeline_actions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import type { IngestPipeline } from '@elastic/elasticsearch/lib/api/types';
import type { IScopedClusterClient } from '@kbn/core/server';
import { isNotFoundError } from '@kbn/es-errors';
import { castArray, groupBy, uniq } from 'lodash';
import { castArray, groupBy, omit, uniq } from 'lodash';
import { ASSET_VERSION } from '../../../../../common/constants';
import type {
ActionsByType,
Expand Down Expand Up @@ -330,15 +330,29 @@ async function findPipelineToModify(
}

async function getPipeline(id: string, scopedClusterClient: IScopedClusterClient) {
return scopedClusterClient.asCurrentUser.ingest
.getPipeline({ id })
.then((response) => response[id])
.catch((error) => {
if (isNotFoundError(error)) {
return undefined;
}
throw error;
});
return (
scopedClusterClient.asCurrentUser.ingest
.getPipeline({ id })
// some keys on the pipeline can't be modified, so we need to clean them up
// to avoid errors when updating the pipeline
.then((response) => {
if (!response[id]) {
return undefined;
}
return omit(response[id], [
'created_date_millis',
'created_date',
'modified_date_millis',
'modified_date',
]);
})
.catch((error) => {
if (isNotFoundError(error)) {
return undefined;
}
throw error;
})
);
}

async function getIndexTemplate(name: string, scopedClusterClient: IScopedClusterClient) {
Expand Down