Dataset quality: Fix failure store test #230050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash1293
added
release_note:skip
Contributor
|
Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs) |
yngrdyn
approved these changes
Jul 31, 2025
…1293/kibana into flash1293/fix-dataset-quality-test
Contributor
💚 Build Succeeded
The CI Stats report is too large to be displayed here, check out the CI build annotation for this information. History
|
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
Aug 5, 2025
We enabled failure store by default for `logs-*-*`. This will break the test we have for the dataset quality page API, since it relies on the default being "no failure store". This PR is fixing this by explicitly configuring both cases - this should keep the test stable no matter what we decide next on the Elasticsearch level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We enabled failure store by default for
logs-*-*. This will break the test we have for the dataset quality page API, since it relies on the default being "no failure store".This PR is fixing this by explicitly configuring both cases - this should keep the test stable no matter what we decide next on the Elasticsearch level.