Skip to content

[6.4] [uiBundles/resetBundleDir] force del() if bundleDir is outside cwd (#22981) #23003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spalger merged 1 commit into from
Sep 13, 2018
Merged

[6.4] [uiBundles/resetBundleDir] force del() if bundleDir is outside cwd (#22981) #23003

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/ui/ui_bundles/ui_bundles_controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,12 @@ export class UiBundlesController {
await mkdirpAsync(this._workingDir);
} else {
// delete all children of the working directory
await del(this.resolvePath('*'));
await del(this.resolvePath('*'), {
// since we know that `this.resolvePath()` is going to return an absolute path based on the `optimize.bundleDir`
// and since we don't want to require that users specify a bundleDir that is within the cwd or limit the cwd
// directory used to run Kibana in any way we use force here
force: true
});
}

// write the entry/style files for each bundle
Expand Down