[ES Query] Fix loading saved query's query in the rule definition #229964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
author:obs-ux-management
maryam-saeidi
changed the title
cnasikas
approved these changes
Jul 31, 2025
Member
There was a problem hiding this comment.
Could you please add a unit test for the fix in x-pack/platform/plugins/shared/stack_alerts/public/rule_types/es_query/expression/search_source_expression.test.tsx?
Member
Author
There was a problem hiding this comment.
Discussed offline, everything is mocked in that test, so we cannot test this logic there.
cnasikas
added
the
Team:ResponseOps
Contributor
|
Pinging @elastic/response-ops (Team:ResponseOps) |
szaffarano
pushed a commit
to szaffarano/kibana
that referenced
this pull request
Aug 5, 2025
…astic#229964) ## Summary I noticed that the query field is not loaded correctly when we use a saved query in the ES Query rule type, as shown below: ### Before https://github.com/user-attachments/assets/379e1da2-ab4b-4358-b43d-2079fcb6c90c ### After https://github.com/user-attachments/assets/6e44d2d4-a1de-4c9e-aba0-a39690617379
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
Aug 5, 2025
…astic#229964) ## Summary I noticed that the query field is not loaded correctly when we use a saved query in the ES Query rule type, as shown below: ### Before https://github.com/user-attachments/assets/379e1da2-ab4b-4358-b43d-2079fcb6c90c ### After https://github.com/user-attachments/assets/6e44d2d4-a1de-4c9e-aba0-a39690617379
NicholasPeretti
pushed a commit
to NicholasPeretti/kibana
that referenced
this pull request
Aug 18, 2025
…astic#229964) ## Summary I noticed that the query field is not loaded correctly when we use a saved query in the ES Query rule type, as shown below: ### Before https://github.com/user-attachments/assets/379e1da2-ab4b-4358-b43d-2079fcb6c90c ### After https://github.com/user-attachments/assets/6e44d2d4-a1de-4c9e-aba0-a39690617379
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I noticed that the query field is not loaded correctly when we use a saved query in the ES Query rule type, as shown below:
Before
Screen.Recording.2025-07-30.at.15.25.13.mov
After
Screen.Recording.2025-07-30.at.15.30.03.mov