-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Synthetics] Add recovery mode switch for status alerts #229962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
pmuellr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ResponseOps changes LGTM. Thanks for the feature flag / intermediate release aspects!
I'm not sure of OAS docs need to be changed because of this, I think I do often see changes there ...
895c506 to
7cb2c47
Compare
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#8947[❌] x-pack/solutions/observability/test/api_integration_deployment_agnostic/feature_flag_configs/serverless/oblt.serverless.config.ts: 0/25 tests passed. |
|
I don't think the failed flaky test run has something to do with changes in this PR. |
src/platform/packages/shared/response-ops/rule_params/synthetics_monitor_status/v1.ts
Outdated
Show resolved
Hide resolved
23431cd to
6a264ec
Compare
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
|
shahzad31
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !!!
@drewpost should this be true by default?
This PR is to improve how we recover monitor status alerts, issue elastic#193613 . It does not close the issue, it is currently disabled because of the [intermediate release process](https://docs.google.com/document/d/1mU5jlIfCKyXdDPtEzAz1xTpFXFCWxqdO5ldYRVO_hgM). [This commit](elastic@dc00912) has to be reverted to enable the feature and it will be done in a separate PR. The user will now be able to select how they want to recover the alert, either when the monitor is back up or when the condition is no longer met. For example, with the current implementation if the rule is "is down 1 time in the past 24 hours" it won't recover until there are 0 downs in the past 24 hours. Enabling this option will make the monitor recover as soon as a UP monitor is received. **Acceptance criteria:** Users have the option where to specify when the recovery should occur: - The first UP test comes in ✅ - The alert condition is no longer met ✅ - Default is the first UP test ✅ **Screenshot:** <img width="1512" height="825" alt="Screenshot 2025-07-30 at 15 06 46" src="https://github.com/user-attachments/assets/110ca4ac-e259-4bdf-9c41-b55feda95aed" /> **Video:** https://github.com/user-attachments/assets/5c0f6d10-caf8-47e7-a206-fe616f130fca --------- Co-authored-by: Shahzad <shahzad31comp@gmail.com>
This PR is to improve how we recover monitor status alerts, issue elastic#193613 . It does not close the issue, it is currently disabled because of the [intermediate release process](https://docs.google.com/document/d/1mU5jlIfCKyXdDPtEzAz1xTpFXFCWxqdO5ldYRVO_hgM). [This commit](elastic@dc00912) has to be reverted to enable the feature and it will be done in a separate PR. The user will now be able to select how they want to recover the alert, either when the monitor is back up or when the condition is no longer met. For example, with the current implementation if the rule is "is down 1 time in the past 24 hours" it won't recover until there are 0 downs in the past 24 hours. Enabling this option will make the monitor recover as soon as a UP monitor is received. **Acceptance criteria:** Users have the option where to specify when the recovery should occur: - The first UP test comes in ✅ - The alert condition is no longer met ✅ - Default is the first UP test ✅ **Screenshot:** <img width="1512" height="825" alt="Screenshot 2025-07-30 at 15 06 46" src="https://github.com/user-attachments/assets/110ca4ac-e259-4bdf-9c41-b55feda95aed" /> **Video:** https://github.com/user-attachments/assets/5c0f6d10-caf8-47e7-a206-fe616f130fca --------- Co-authored-by: Shahzad <shahzad31comp@gmail.com>
…elastic#231091) This PR is a follow up of elastic#229962 and it closes elastic#193613 . It can be merged only after [this commit](elastic@933d2ba) has been included in a serverless release.

This PR is to improve how we recover monitor status alerts, issue #193613 .
It does not close the issue, it is currently disabled because of the intermediate release process.
This commit has to be reverted to enable the feature and it will be done in a separate PR.
The user will now be able to select how they want to recover the alert, either when the monitor is back up or when the condition is no longer met.
For example, with the current implementation if the rule is "is down 1 time in the past 24 hours" it won't recover until there are 0 downs in the past 24 hours.
Enabling this option will make the monitor recover as soon as a UP monitor is received.
Acceptance criteria:
Users have the option where to specify when the recovery should occur:
Screenshot:

Video:
Screen.Recording.2025-07-29.at.16.24.20.mov