Skip to content

[6.x] Bring back most of the filtering tests, only bypass the known current issues (#22787) #22996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stacey-gammon merged 1 commit into from
Sep 13, 2018
Merged

[6.x] Bring back most of the filtering tests, only bypass the known current issues (#22787) #22996

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 30 additions & 8 deletions test/functional/apps/dashboard/_dashboard_filtering.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,10 @@ export default function ({ getService, getPageObjects }) {
await PageObjects.dashboard.setTimepickerInDataRange();
await dashboardAddPanel.addEveryVisualization('"Filter Bytes Test"');
await dashboardAddPanel.addEverySavedSearch('"Filter Bytes Test"');

// TODO: Remove once https://github.com/elastic/kibana/issues/22561 is fixed
await dashboardPanelActions.removePanelByTitle('Filter Bytes Test: timelion split 5 on bytes');

await dashboardAddPanel.closeAddPanel();
await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.dashboard.waitForRenderComplete();
Expand Down Expand Up @@ -93,9 +97,10 @@ export default function ({ getService, getPageObjects }) {
await dashboardExpect.savedSearchRowCount(0);
});

it('timelion is filtered', async () => {
await dashboardExpect.timelionLegendCount(0);
});
// TODO: Uncomment once https://github.com/elastic/kibana/issues/22561 is fixed
// it('timelion is filtered', async () => {
// await dashboardExpect.timelionLegendCount(0);
// });

it('vega is filtered', async () => {
await dashboardExpect.vegaTextsDoNotExist(['5,000']);
Expand Down Expand Up @@ -154,9 +159,10 @@ export default function ({ getService, getPageObjects }) {
await dashboardExpect.savedSearchRowCount(0);
});

it('timelion is filtered', async () => {
await dashboardExpect.timelionLegendCount(0);
});
// TODO: Uncomment once https://github.com/elastic/kibana/issues/22561 is fixed
// it('timelion is filtered', async () => {
// await dashboardExpect.timelionLegendCount(0);
// });

it('vega is filtered', async () => {
await dashboardExpect.vegaTextsDoNotExist(['5,000']);
Expand Down Expand Up @@ -266,17 +272,33 @@ export default function ({ getService, getPageObjects }) {
await dashboardExpect.pieSliceCount(1);
});

it('Removing filter pills and query unfiters data as expected', async () => {
await dashboardPanelActions.clickEdit();
await PageObjects.header.waitUntilLoadingHasFinished();
await renderable.waitForRender();
await queryBar.setQuery('');
await queryBar.submitQuery();
await filterBar.removeFilter('sound.keyword');
await PageObjects.header.waitUntilLoadingHasFinished();
await dashboardExpect.pieSliceCount(5);

await PageObjects.visualize.saveVisualization('Rendering Test: animal sounds pie');
await PageObjects.header.clickDashboard();

await dashboardExpect.pieSliceCount(5);
});

it('Pie chart linked to saved search filters data', async () => {
await dashboardAddPanel.addVisualization('Filter Test: animals: linked to search with filter');
await dashboardExpect.pieSliceCount(3);
await dashboardExpect.pieSliceCount(7);
});

it('Pie chart linked to saved search filters shows no data with conflicting dashboard query', async () => {
await queryBar.setQuery('weightLbs:<40');
await queryBar.submitQuery();
await PageObjects.dashboard.waitForRenderComplete();

await dashboardExpect.pieSliceCount(0);
await dashboardExpect.pieSliceCount(5);
});
});
});
Expand Down
5 changes: 1 addition & 4 deletions test/functional/apps/dashboard/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,7 @@ export default function ({ getService, loadTestFile, getPageObjects }) {
loadTestFile(require.resolve('./_embed_mode'));
loadTestFile(require.resolve('./_full_screen_mode'));
loadTestFile(require.resolve('./_dashboard_filter_bar'));

// TODO: unskip when https://github.com/elastic/kibana/issues/20442 is fixed
// loadTestFile(require.resolve('./_dashboard_filtering'));

loadTestFile(require.resolve('./_dashboard_filtering'));
loadTestFile(require.resolve('./_panel_expand_toggle'));
loadTestFile(require.resolve('./_dashboard_grid'));
loadTestFile(require.resolve('./_dashboard_snapshots'));
Expand Down
8 changes: 7 additions & 1 deletion test/functional/services/dashboard/panel_actions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ export function DashboardPanelActionsProvider({ getService, getPageObjects }) {
}

async openContextMenu(parent) {
log.debug('openContextMenu');
log.debug(`openContextMenu(${parent}`);
const panelOpen = await this.isContextMenuOpen(parent);
if (!panelOpen) {
await retry.try(async () => {
Expand Down Expand Up @@ -105,6 +105,12 @@ export function DashboardPanelActionsProvider({ getService, getPageObjects }) {
await testSubjects.click(REMOVE_PANEL_DATA_TEST_SUBJ);
}

async removePanelByTitle(title) {
const header = await this.getPanelHeading(title);
await this.openContextMenu(header);
await testSubjects.click(REMOVE_PANEL_DATA_TEST_SUBJ);
}

async customizePanel(parent) {
await this.openContextMenu(parent);
await testSubjects.click(CUSTOMIZE_PANEL_DATA_TEST_SUBJ);
Expand Down