-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[1chat] Evaluation Suite #229929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[1chat] Evaluation Suite #229929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joemcelroy
approved these changes
Jul 30, 2025
…t --include-path /api/status --include-path /api/alerting/rule/ --include-path /api/alerting/rules --include-path /api/actions --include-path /api/security/role --include-path /api/spaces --include-path /api/streams --include-path /api/fleet --include-path /api/dashboards --include-path /api/saved_objects/_import --include-path /api/saved_objects/_export --include-path /api/maintenance_window --update'
44038bc to
b3f01f0
Compare
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
|
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
Aug 5, 2025
## Summary Relates to: elastic#227997 Adding a new `@kbn/evals-suite-onechat` package that provides automated evaluation testing for OneChat functionality. The suite is built on top of the existing `@kbn/evals` framework to use Phoenix/Playwright for evaluations and follows the same patterns as other evaluation packages (`@kbn/evals-suite-obs-ai-assistant`). Besides the boilerplate evaluation framework setup, this change adds the following: - OneChat API Client: API client for handling chat interactions and conversation management (using sync API) - Evaluation: Playwright test extension with OneChat-specific fixture and a first, very basic response evaluator. - Sample Test Suite: Example evaluation tests for KB tests (from this [doc](https://docs.google.com/document/d/1dG4dsImCtTEHeiqXxuC6wXDj497X_fmhJtJnF-jKmQ8/edit?tab=t.0)) What's not added (yet) - Dataset loading. Knowledge base tests currently don't preload datasets, this should be addressed in a follow-up as it requires configuration of the OneChat HF datasets within out data loaders package. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
NicholasPeretti
pushed a commit
to NicholasPeretti/kibana
that referenced
this pull request
Aug 18, 2025
## Summary Relates to: elastic#227997 Adding a new `@kbn/evals-suite-onechat` package that provides automated evaluation testing for OneChat functionality. The suite is built on top of the existing `@kbn/evals` framework to use Phoenix/Playwright for evaluations and follows the same patterns as other evaluation packages (`@kbn/evals-suite-obs-ai-assistant`). Besides the boilerplate evaluation framework setup, this change adds the following: - OneChat API Client: API client for handling chat interactions and conversation management (using sync API) - Evaluation: Playwright test extension with OneChat-specific fixture and a first, very basic response evaluator. - Sample Test Suite: Example evaluation tests for KB tests (from this [doc](https://docs.google.com/document/d/1dG4dsImCtTEHeiqXxuC6wXDj497X_fmhJtJnF-jKmQ8/edit?tab=t.0)) What's not added (yet) - Dataset loading. Knowledge base tests currently don't preload datasets, this should be addressed in a follow-up as it requires configuration of the OneChat HF datasets within out data loaders package. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This PR does not require backporting
backport:version
Backport to applied version labels
release_note:skip
Skip the PR/issue when compiling release notes
v9.2.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Relates to: #227997
Adding a new
@kbn/evals-suite-onechatpackage that provides automated evaluation testing for OneChat functionality.The suite is built on top of the existing
@kbn/evalsframework to use Phoenix/Playwright for evaluations and follows the same patterns as other evaluation packages (@kbn/evals-suite-obs-ai-assistant).Besides the boilerplate evaluation framework setup, this change adds the following:
What's not added (yet)
How it looks:
Running the test suite (screenshot below). Experiment results available in Phoenix (link). Note: Scores are low as the dataset loading is still not happening. Therefore the model can't respond to any data related questions.

Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:*label is applied per the guidelines