[core/public/chrome] migrate controls, theme, and visibility apis

[spalger]

Another part of #19992, moved over the ui/chrome apis that control the theme (dark mode, custom home logo), visibility (embed mode), and controls (collapsed state) to a core.chrome service. All of the original APIs are unchanged. This primary things to test are the collapse/expand button in the navigation, full screen mode in dashboard, the format of PDFs, and dashboard light/dark mode switching.

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request

[azasypkin]

ack: will get to this PR tomorrow morning.

[azasypkin]

Code LGTM, thanks for adding tests! Testing locally at the moment.

[azasypkin]

question: mostly to widen my RxJS horizons :) What issues we'd have if we use something like this instead?

FORCE_HIDDEN ? of(false) : isVisible$.pipe(takeUntil(this.stop$))

With the current implementation if FORCE_HIDDEN === true then next on getIsVisible$ will always be called with false whenever setIsVisible is called and hence any external code that relies on this observable will be called as well .

Kind of related question, should we next in setIsVisible and setIsCollapsed if value hasn't changed or it should be responsibility of the consumer to use or not distinct*?

Not a big deal, just curious what you think.

[spalger]

I think something like FORCE_HIDDEN ? of(false) : ... would be fine, but I'm kind of concerned about the difference in lifecycle between the two return values, it probably wouldn't be a big deal, and since it really can't change it is "complete", but I'd have to think through how that might impact consumers. As for deduping here rather than in consumers, I originally had more dedupe logic in here, but felt like it didn't really add anything to do the extra work of deduping notifications. It might turn out that it's a lot nicer to consume an API that properly dedupes notifications, but I'm not sure about that... So I left it out for now.

[azasypkin]

Tested Kibana in embedded and full screen modes, generated PDF, etc. - everything looked good!

[cjcenizal]

Is there an advantage to using toMatchInlineSnapshot over toEqual? Personally I would find the latter more readable:

      await expect(promise).resolves.toEqual([
        {},
        {
          logo: "big logo",
          smallLogo: "not so big logo",
        },
        {
          logo: "big logo without small logo",
          smallLogo: undefined,
        },
      ]);

[spalger]

Mostly maintenance, being able to update the snapshots with -u and automatically update them with --watch are pretty huge benefits to me

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request

[spalger]

6.5/6.x: e33cba3