Skip to content

[Fleet] Use EuiFlexGrid instead of EuiFlexGroup in integrations grid#229837

Merged
juliaElastic merged 1 commit intoelastic:mainfrom
kpollich:fix-integration-grid
Jul 30, 2025
Merged

[Fleet] Use EuiFlexGrid instead of EuiFlexGroup in integrations grid#229837
juliaElastic merged 1 commit intoelastic:mainfrom
kpollich:fix-integration-grid

Conversation

@kpollich
Copy link
Member

Summary

Closes #229818

Aligns the grid implementation across empty states + the virtualized list to show cards in a consistently sized grid.

Screen recording

Screen.Recording.2025-07-29.at.11.03.03.AM.mov

Note the max height difference is currently expected behavior on main. I didn't attempt to fix the nonuniform card height due to text content differences.

@kpollich kpollich self-assigned this Jul 29, 2025
@kpollich kpollich requested a review from a team as a code owner July 29, 2025 15:05
@kpollich kpollich added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team:Fleet Team label for Observability Data Collection Fleet team labels Jul 29, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 2.1MB 2.1MB +52.0B

cc @kpollich

@kpollich
Copy link
Member Author

Screen.Recording.2025-07-29.at.12.59.17.PM.mov

Doublechecking the integration grid in the security onboarding flow looks good to me. I do see the padding issue that @spong mentioned, but IMO there should be an EuiSpacer under the top callouts in that particular usage of this component.

@juliaElastic juliaElastic merged commit a9fac39 into elastic:main Jul 30, 2025
21 checks passed
VladimirFilonov pushed a commit to VladimirFilonov/kibana that referenced this pull request Jul 30, 2025
…rid (elastic#229837)

## Summary

Closes elastic#229818

Aligns the grid implementation across empty states + the virtualized
list to show cards in a consistently sized grid.

## Screen recording


https://github.com/user-attachments/assets/926ff910-07a3-494f-9e4b-f2226a6d41b9

Note the max height difference is currently expected behavior on `main`.
I didn't attempt to fix the nonuniform card height due to text content
differences.
delanni pushed a commit to delanni/kibana that referenced this pull request Aug 5, 2025
…rid (elastic#229837)

## Summary

Closes elastic#229818

Aligns the grid implementation across empty states + the virtualized
list to show cards in a consistently sized grid.

## Screen recording


https://github.com/user-attachments/assets/926ff910-07a3-494f-9e4b-f2226a6d41b9

Note the max height difference is currently expected behavior on `main`.
I didn't attempt to fix the nonuniform card height due to text content
differences.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Fleet] Integrations browse page formatting issues

4 participants