[Cases] Remove minor layout shift for comment image paste progress bar#229808
Merged
justinkambic merged 2 commits intoelastic:mainfrom Jul 31, 2025
Merged
Conversation
Contributor
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
|
michaelolo24
approved these changes
Jul 31, 2025
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
1 similar comment
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
Aug 5, 2025
elastic#229808) ## Summary We recently merged image paste functionality to the comment editor in Cases. One iterative fix I committed to was removing a very small layout shift that takes place when the upload progress bar is conditionally rendered. This patch will change it so the progress bar is always rendered, and only its visibility is toggled by the loading state. ### Before  ### After 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We recently merged image paste functionality to the comment editor in Cases. One iterative fix I committed to was removing a very small layout shift that takes place when the upload progress bar is conditionally rendered.
This patch will change it so the progress bar is always rendered, and only its visibility is toggled by the loading state.
Before
After