Skip to content

[Cases] Remove minor layout shift for comment image paste progress bar#229808

Merged
justinkambic merged 2 commits intoelastic:mainfrom
justinkambic:fix-layout-shift-for-screenshot-paste-loading
Jul 31, 2025
Merged

[Cases] Remove minor layout shift for comment image paste progress bar#229808
justinkambic merged 2 commits intoelastic:mainfrom
justinkambic:fix-layout-shift-for-screenshot-paste-loading

Conversation

@justinkambic
Copy link
Contributor

Summary

We recently merged image paste functionality to the comment editor in Cases. One iterative fix I committed to was removing a very small layout shift that takes place when the upload progress bar is conditionally rendered.

This patch will change it so the progress bar is always rendered, and only its visibility is toggled by the loading state.

Before

20250729091542

After

20250729091431

@justinkambic justinkambic self-assigned this Jul 29, 2025
@justinkambic justinkambic requested a review from a team as a code owner July 29, 2025 13:17
@justinkambic justinkambic added release_note:skip Skip the PR/issue when compiling release notes Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. backport:version Backport to applied version labels v9.2.0 labels Jul 29, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@github-actions github-actions bot added the author:obs-ux-management PRs authored by the obs ux management team label Jul 29, 2025
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 1.3MB 1.3MB +52.0B

cc @justinkambic

@justinkambic justinkambic merged commit a4d90ae into elastic:main Jul 31, 2025
12 checks passed
@justinkambic justinkambic deleted the fix-layout-shift-for-screenshot-paste-loading branch July 31, 2025 14:19
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 4, 2025
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 229808 locally
cc: @justinkambic

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 229808 locally
cc: @justinkambic

delanni pushed a commit to delanni/kibana that referenced this pull request Aug 5, 2025
elastic#229808)

## Summary

We recently merged image paste functionality to the comment editor in
Cases. One iterative fix I committed to was removing a very small layout
shift that takes place when the upload progress bar is conditionally
rendered.

This patch will change it so the progress bar is always rendered, and
only its visibility is toggled by the loading state.

### Before


![20250729091542](https://github.com/user-attachments/assets/8761be1e-a068-4ee3-8ea0-1f0f4e8602a9)


### After


![20250729091431](https://github.com/user-attachments/assets/290a6231-33ef-4bd6-8e0d-27682adcd89c)
@justinkambic justinkambic added backport:skip This PR does not require backporting and removed backport:version Backport to applied version labels labels Aug 6, 2025
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 6, 2025
@wildemat wildemat mentioned this pull request Aug 7, 2025
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author:obs-ux-management PRs authored by the obs ux management team backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants