[Streams] Implement Routing UI + Data retention e2e tests #229791

tonyghiani · 2025-07-29T12:32:33Z

📓 Summary

Part of #245

This PR introduces a comprehensive Scout test suite for the Stream Routing UI.
The tests cover key workflow areas, including creating, editing, reordering routing rules, error handling and recovery scenarios, and preview panel behavior with generated synthetic data.

🧪 Test Suite

Stream data routing
├─ Creating New routing rules
│  ├─ should create a new routing rule successfully
│  ├─ should cancel creating new routing rule
│  ├─ should not let creating new routing rule while one is in progress
│  ├─ should show validation errors for invalid stream names
│  └─ should handle insufficient privileges gracefully
│
├─ Editing existing routing rules
│  ├─ should edit an existing routing rule
│  ├─ should cancel editing routing rule
│  ├─ should switch between editing different rules
│  ├─ should remove routing rule with confirmation
│  └─ should cancel rule removal
│
├─ Reordering routing rules
│  ├─ should reorder routing rules via drag and drop
│  ├─ should cancel reordering
│  └─ should handle multiple reorder operations
│
├─ Error handling and recovery
│  ├─ should handle network failures during rule creation
│  └─ should recover from API errors during rule updates
│
└─ Preview panel
   ├─ should show the preview data during rule creation
   ├─ should update the preview data when the condition changes
   └─ should show no matches when the condition matches nothing

Stream data retention
└─ Updating data retention
   ├─ should update a stream data retention policy successfully
   └─ should reset a stream data retention policy successfully

…no-cache --fix'

tonyghiani · 2025-07-30T07:26:23Z

/ci

elasticmachine · 2025-07-30T08:23:05Z

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

...atform/plugins/shared/streams_app/test/scout/ui/tests/data_management/data_retention.spec.ts

x-pack/platform/plugins/shared/streams_app/test/scout/ui/fixtures/page_objects/streams_app.ts

This reverts commit 98b8ff7.

dmlemeshko

LGTM, thanks a lot for update 🚀

flash1293 · 2025-07-31T11:03:49Z

Pretty neat, however I think it would be great to add a test for the syntax-based condition editor.

tonyghiani · 2025-08-01T07:48:43Z

@flash1293 Added a test for the syntax editor to verify changes are reflected on the preview outcome, this should be ready for another look.

flash1293

LGTM, thanks for adding that. Just one last request :)

...ed/streams_app/test/scout/ui/tests/data_management/data_routing/routing_data_preview.spec.ts

elasticmachine · 2025-08-04T13:04:17Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: f6d3a2f

Failed CI Steps

FTR Configs #125

Test Failures

[job] [logs] FTR Configs #125 / Fleet Endpoints fleet policy secrets fleet server version requirements "after each" hook for "should convert plain text values to secrets once fleet server requirements are met"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`streamsApp`	615.9KB	616.3KB	+321.0B

Unknown metric groups

ESLint disabled in files

id	before	after	diff
`streamsApp`	4	7	+3

Total ESLint disabled count

id	before	after	diff
`streamsApp`	12	15	+3

History

💔 Build #325910 failed 9d34ff9
💛 Build #325412 was flaky 395d2e9
💚 Build #324788 succeeded c96fb58
💚 Build #324681 succeeded b5830e2
💚 Build #324650 succeeded 98b8ff7

…9791) ## 📓 Summary Part of [elastic#245](elastic/logs-dev#245) This PR introduces a comprehensive Scout test suite for the **Stream Routing UI**. The tests cover key workflow areas, including creating, editing, reordering routing rules, error handling and recovery scenarios, and preview panel behavior with generated synthetic data. ## 🧪 Test Suite ``` Stream data routing ├─ Creating New routing rules │ ├─ should create a new routing rule successfully │ ├─ should cancel creating new routing rule │ ├─ should not let creating new routing rule while one is in progress │ ├─ should show validation errors for invalid stream names │ └─ should handle insufficient privileges gracefully │ ├─ Editing existing routing rules │ ├─ should edit an existing routing rule │ ├─ should cancel editing routing rule │ ├─ should switch between editing different rules │ ├─ should remove routing rule with confirmation │ └─ should cancel rule removal │ ├─ Reordering routing rules │ ├─ should reorder routing rules via drag and drop │ ├─ should cancel reordering │ └─ should handle multiple reorder operations │ ├─ Error handling and recovery │ ├─ should handle network failures during rule creation │ └─ should recover from API errors during rule updates │ └─ Preview panel ├─ should show the preview data during rule creation ├─ should update the preview data when the condition changes └─ should show no matches when the condition matches nothing Stream data retention └─ Updating data retention ├─ should update a stream data retention policy successfully └─ should reset a stream data retention policy successfully ``` --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

tonyghiani added 2 commits July 28, 2025 17:37

tests(streams): wip on partitioning tests

092935f

tests(streams): add baseline test suite routing UI

c3c8253

tonyghiani changed the title ~~282 improve routing testing~~ [Streams] Implement Routing UI e2e tests Jul 29, 2025

tonyghiani and others added 5 commits July 29, 2025 14:35

Merge branch 'main' into 282-improve-routing-testing

164b94c

[CI] Auto-commit changed files from 'node scripts/yarn_deduplicate'

34ee3e7

tests(streams): remove previous placeholder tests

5361499

tests(streams): fix streams test

e1075d0

tests(streams): re-add data retention tests

5235bd6

tonyghiani changed the title ~~[Streams] Implement Routing UI e2e tests~~ [Streams] Implement Routing UI + Data retention e2e tests Jul 29, 2025

kibanamachine and others added 2 commits July 29, 2025 15:26

[CI] Auto-commit changed files from 'node scripts/eslint_all_files --…

8d4c26c

…no-cache --fix'

Merge branch 'main' into 282-improve-routing-testing

d3f621c

tonyghiani marked this pull request as ready for review July 30, 2025 08:21

tonyghiani requested review from a team as code owners July 30, 2025 08:21

dmlemeshko self-requested a review July 30, 2025 08:22

tonyghiani added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team:obs-onboarding Observability Onboarding Team Feature:Streams This is the label for the Streams Project labels Jul 30, 2025

dmlemeshko reviewed Jul 30, 2025

View reviewed changes

...atform/plugins/shared/streams_app/test/scout/ui/tests/data_management/data_retention.spec.ts Outdated Show resolved Hide resolved

dmlemeshko reviewed Jul 30, 2025

View reviewed changes

x-pack/platform/plugins/shared/streams_app/test/scout/ui/fixtures/page_objects/streams_app.ts Show resolved Hide resolved

tonyghiani added 2 commits July 30, 2025 10:46

tests(streams): add check for closed modal

83c046b

tests(streams): TOREVERT - flaky test runner workaround

98b8ff7

tonyghiani requested a review from a team as a code owner July 30, 2025 09:50

Revert "tests(streams): TOREVERT - flaky test runner workaround"

b5830e2

This reverts commit 98b8ff7.

tonyghiani removed the request for review from a team July 30, 2025 11:09

refactor(streams): split testing files

c96fb58

dmlemeshko approved these changes Jul 30, 2025

View reviewed changes

tonyghiani added 2 commits August 1, 2025 09:47

test(streams): add test for syntax editor

62324f3

Merge branch 'main' into 282-improve-routing-testing

395d2e9

Merge branch 'main' into 282-improve-routing-testing

dab30c9

flash1293 approved these changes Aug 4, 2025

View reviewed changes

...ed/streams_app/test/scout/ui/tests/data_management/data_routing/routing_data_preview.spec.ts Show resolved Hide resolved

tonyghiani added 2 commits August 4, 2025 11:34

Merge branch 'main' into 282-improve-routing-testing

85d15a7

test(streams): udpate syntax condition

9d34ff9

tonyghiani enabled auto-merge (squash) August 4, 2025 09:37

test(streams): remove exclusive test

f6d3a2f

tonyghiani merged commit b0b021c into elastic:main Aug 4, 2025
12 checks passed

kibanamachine added the v9.2.0 label Aug 4, 2025

tonyghiani deleted the 282-improve-routing-testing branch August 7, 2025 06:55

wildemat mentioned this pull request Aug 7, 2025

pr 230826 #231022

Closed

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Streams] Implement Routing UI + Data retention e2e tests #229791

[Streams] Implement Routing UI + Data retention e2e tests #229791

Uh oh!

tonyghiani commented Jul 29, 2025 •

edited

Loading

Uh oh!

tonyghiani commented Jul 30, 2025

Uh oh!

elasticmachine commented Jul 30, 2025

Uh oh!

Uh oh!

Uh oh!

dmlemeshko left a comment

Uh oh!

flash1293 commented Jul 31, 2025

Uh oh!

tonyghiani commented Aug 1, 2025

Uh oh!

flash1293 left a comment

Uh oh!

Uh oh!

Uh oh!

elasticmachine commented Aug 4, 2025

ESLint disabled in files

Total ESLint disabled count

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

[Streams] Implement Routing UI + Data retention e2e tests #229791

[Streams] Implement Routing UI + Data retention e2e tests #229791

Uh oh!

Conversation

tonyghiani commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📓 Summary

🧪 Test Suite

Uh oh!

tonyghiani commented Jul 30, 2025

Uh oh!

elasticmachine commented Jul 30, 2025

Uh oh!

Uh oh!

Uh oh!

dmlemeshko left a comment

Choose a reason for hiding this comment

Uh oh!

flash1293 commented Jul 31, 2025

Uh oh!

tonyghiani commented Aug 1, 2025

Uh oh!

flash1293 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

elasticmachine commented Aug 4, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Async chunks

ESLint disabled in files

Total ESLint disabled count

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tonyghiani commented Jul 29, 2025 •

edited

Loading