Skip to content

add kibana.alert.grouping in apm rule types #229769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mgiota wants to merge 2 commits into from
Closed

add kibana.alert.grouping in apm rule types #229769

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
157809c
add kibana.alert.grouping in apm rule types
mgiota Jul 29, 2025
f4ab959
Merge branch 'main' of github.com:elastic/kibana into apm_alert_grouping
mgiota Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion x-pack/solutions/observability/plugins/apm/server/routes/alerts/register_apm_rule_types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,21 @@ export const apmRuleTypeAlertFieldMap = {
// Defines which alerts-as-data index alerts will use
export const ApmRuleTypeAlertDefinition: IRuleTypeAlerts<ObservabilityApmAlert> = {
context: APM_RULE_TYPE_ALERT_CONTEXT,
mappings: { fieldMap: apmRuleTypeAlertFieldMap },
mappings: {
fieldMap: apmRuleTypeAlertFieldMap,
dynamicTemplates: [
{
strings_as_keywords: {
path_match: 'kibana.alert.grouping.*',
match_mapping_type: 'string',
mapping: {
type: 'keyword',
ignore_above: 1024,
},
},
},
],
},
useLegacyAlerts: true,
shouldWrite: true,
};
Expand Down
2 changes: 2 additions & 0 deletions ...plugins/apm/server/routes/alerts/rule_types/error_count/register_error_count_rule_type.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ import {
ALERT_EVALUATION_VALUE,
ALERT_REASON,
ALERT_RULE_PARAMETERS,
ALERT_GROUPING,
ApmRuleType,
} from '@kbn/rule-data-utils';
import type { ObservabilityApmAlert } from '@kbn/alerts-as-data-utils';
Expand Down Expand Up @@ -251,6 +252,7 @@ export function registerErrorCountRuleType({
[ALERT_EVALUATION_THRESHOLD]: ruleParams.threshold,
[ERROR_GROUP_ID]: ruleParams.errorGroupingKey,
[ALERT_REASON]: alertReason,
[ALERT_GROUPING]: groupingObject,
...sourceFields,
...groupByFields,
};
Expand Down
4 changes: 3 additions & 1 deletion .../routes/alerts/rule_types/transaction_duration/register_transaction_duration_rule_type.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ import {
ALERT_EVALUATION_VALUE,
ALERT_REASON,
ALERT_RULE_PARAMETERS,
ALERT_GROUPING,
ApmRuleType,
} from '@kbn/rule-data-utils';
import type { ObservabilityApmAlert } from '@kbn/alerts-as-data-utils';
Expand Down Expand Up @@ -321,6 +322,7 @@ export function registerTransactionDurationRuleType({
[ALERT_EVALUATION_VALUE]: transactionDuration,
[ALERT_EVALUATION_THRESHOLD]: thresholdMicroseconds,
[ALERT_REASON]: reason,
[ALERT_GROUPING]: groupingObject,
...sourceFields,
...groupByFields,
};
Expand Down Expand Up @@ -383,7 +385,7 @@ export function registerTransactionDurationRuleType({
threshold: ruleParams.threshold,
triggerValue: transactionDurationFormatted,
viewInAppUrl,
grouping: groupingObject,
grouping: alertHits?.[ALERT_GROUPING],
...groupByActionVariables,
};

Expand Down
4 changes: 3 additions & 1 deletion ...tes/alerts/rule_types/transaction_error_rate/register_transaction_error_rate_rule_type.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ import {
ALERT_EVALUATION_VALUE,
ALERT_REASON,
ALERT_RULE_PARAMETERS,
ALERT_GROUPING,
ApmRuleType,
} from '@kbn/rule-data-utils';
import type { ObservabilityApmAlert } from '@kbn/alerts-as-data-utils';
Expand Down Expand Up @@ -301,6 +302,7 @@ export function registerTransactionErrorRateRuleType({
[ALERT_EVALUATION_VALUE]: errorRate,
[ALERT_EVALUATION_THRESHOLD]: ruleParams.threshold,
[ALERT_REASON]: reasonMessage,
[ALERT_GROUPING]: groupingObject,
...sourceFields,
...groupByFields,
};
Expand Down Expand Up @@ -375,7 +377,7 @@ export function registerTransactionErrorRateRuleType({
threshold: ruleParams.threshold,
triggerValue: asDecimalOrInteger(alertHits?.[ALERT_EVALUATION_VALUE]),
viewInAppUrl,
grouping: groupingObject,
grouping: alertHits?.[ALERT_GROUPING],
...groupByActionVariables,
};

Expand Down