Skip to content

[8.17] Upgrade getos (#229166)#229516

Merged
afharo merged 1 commit intoelastic:8.17from
afharo:backport/8.17/pr-229166
Jul 25, 2025
Merged

[8.17] Upgrade getos (#229166)#229516
afharo merged 1 commit intoelastic:8.17from
afharo:backport/8.17/pr-229166

Conversation

@afharo
Copy link
Member

@afharo afharo commented Jul 25, 2025

Backport

This will backport the following commits from main to 8.17:

Questions ?

Please refer to the Backport tool documentation

(cherry picked from commit 0c6b884)

# Conflicts:
#	package.json
@afharo afharo requested a review from kibanamachine as a code owner July 25, 2025 19:24
@afharo afharo added the backport This PR is a backport of another PR label Jul 25, 2025
@afharo afharo enabled auto-merge (squash) July 25, 2025 19:24
@afharo afharo mentioned this pull request Jul 25, 2025
2 tasks
Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on CI green.

"get-port": "^5.0.0",
"getopts": "^2.2.5",
"getos": "^3.1.0",
"getos": "^3.2.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.2.1 was published 5 years ago and doesn't look like it's actively maintained, going against the recommended 3rd party dependency guidelines.
Can we not switch entirely to native node os?

@afharo afharo merged commit 28a4822 into elastic:8.17 Jul 25, 2025
11 checks passed
@afharo afharo deleted the backport/8.17/pr-229166 branch July 25, 2025 21:21
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants