[Discover] When creating a new tab, use the same data source and query mode #229482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jughosta
added
release_note:skip
Contributor
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#8964[✅] src/platform/test/functional/apps/discover/tabs/config.ts: 10/10 tests passed. |
Contributor
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
cc @jughosta |
kertal
approved these changes
Aug 6, 2025
Member
kertal
left a comment
kertal
left a comment
There was a problem hiding this comment.
Code LGTM, tested locally and works as expected, it's a nice UX enhancement 👍
gergoabraham
pushed a commit
to gergoabraham/kibana
that referenced
this pull request
Aug 7, 2025
…y mode (elastic#229482) - Closes elastic#228793 ## Summary When user creates a new tab, depending on the last active tab we can define the initial state for it: - if last active tab was in ES|QL mode, the new tab will be also in ES|QL mode with the same data source as before - if last active tab was in Classic mode, the new tab will be also in Classic mode with the same selected data view as before. So this logic was mainly based on how "New" action works for Discover Sessions in general. Now same for new tabs. ### Testing To enable tabs in Discover, run `localStorage.setItem('discoverExperimental:tabs', 'true')` in browser Console and refresh the page. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
NicholasPeretti
pushed a commit
to NicholasPeretti/kibana
that referenced
this pull request
Aug 18, 2025
…y mode (elastic#229482) - Closes elastic#228793 ## Summary When user creates a new tab, depending on the last active tab we can define the initial state for it: - if last active tab was in ES|QL mode, the new tab will be also in ES|QL mode with the same data source as before - if last active tab was in Classic mode, the new tab will be also in Classic mode with the same selected data view as before. So this logic was mainly based on how "New" action works for Discover Sessions in general. Now same for new tabs. ### Testing To enable tabs in Discover, run `localStorage.setItem('discoverExperimental:tabs', 'true')` in browser Console and refresh the page. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When user creates a new tab, depending on the last active tab we can define the initial state for it:
So this logic was mainly based on how "New" action works for Discover Sessions in general. Now same for new tabs.
Testing
To enable tabs in Discover, run
localStorage.setItem('discoverExperimental:tabs', 'true')in browser Console and refresh the page.Checklist
release_note:*label is applied per the guidelinesbackport:*labels.