perf(synthetics): improve use public location logic #229391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
Team:actionable-obs
Contributor
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
vigneshshanmugam
added
backport:prev-minor
release_note:skip
vigneshshanmugam
force-pushed
the
improve-synthetics-perf
branch
from
68bcfb6 to
622e0f0
Compare
|
💚 CLA has been signed |
Contributor
|
Starting backport for target branches: 8.17, 8.18, 8.19, 9.1 https://github.com/elastic/kibana/actions/runs/16762637984 |
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 5, 2025
## Summary + Optimize the heavy calls during rendering of Synthetics monitors overview page by memoizing the relevant calls and avoiding potential rerenders. Performance improvements speaks for themselves, attaching the context below ## Scenario With 5000 monitors - going to `app/synthetics` page - No scrolling - Just page load ### Before **M1 Mac - No throttle** <img width="787" height="166" alt="Screenshot 2025-07-24 at 5 39 02 PM" src="https://github.com/user-attachments/assets/8e48f060-ac13-4a64-88a3-48e9a4d1cda6" /> **Slowdown on 1x throttled M1 Mac** <img width="645" height="218" alt="Screenshot 2025-07-24 at 5 43 31 PM" src="https://github.com/user-attachments/assets/e9928a5d-da61-4ac2-b1bd-a99ca156eb7f" /> **Midtier desktop/ Highend Mobile** <img width="702" height="210" alt="Screenshot 2025-07-24 at 5 42 30 PM" src="https://github.com/user-attachments/assets/2c53c560-4f56-4182-9c5d-20a350c676f1" /> ### After **M1 Mac - No throttle** <img width="677" height="132" alt="Screenshot 2025-07-24 at 4 56 54 PM" src="https://github.com/user-attachments/assets/f35b61cd-91d0-4c43-8d73-068d498009cd" /> **Midtier desktop/ Highend Mobile / Slowdown on 1x throttled M1 Mac** <img width="509" height="126" alt="Screenshot 2025-07-24 at 6 01 38 PM" src="https://github.com/user-attachments/assets/0f5b6125-db31-49e5-a024-2629e8db55ca" /> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. --------- Co-authored-by: vigneshshanmugam <vignesh.shanmugam@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Shahzad <shahzad31comp@gmail.com> (cherry picked from commit 93daf0d)
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 5, 2025
## Summary + Optimize the heavy calls during rendering of Synthetics monitors overview page by memoizing the relevant calls and avoiding potential rerenders. Performance improvements speaks for themselves, attaching the context below ## Scenario With 5000 monitors - going to `app/synthetics` page - No scrolling - Just page load ### Before **M1 Mac - No throttle** <img width="787" height="166" alt="Screenshot 2025-07-24 at 5 39 02 PM" src="https://github.com/user-attachments/assets/8e48f060-ac13-4a64-88a3-48e9a4d1cda6" /> **Slowdown on 1x throttled M1 Mac** <img width="645" height="218" alt="Screenshot 2025-07-24 at 5 43 31 PM" src="https://github.com/user-attachments/assets/e9928a5d-da61-4ac2-b1bd-a99ca156eb7f" /> **Midtier desktop/ Highend Mobile** <img width="702" height="210" alt="Screenshot 2025-07-24 at 5 42 30 PM" src="https://github.com/user-attachments/assets/2c53c560-4f56-4182-9c5d-20a350c676f1" /> ### After **M1 Mac - No throttle** <img width="677" height="132" alt="Screenshot 2025-07-24 at 4 56 54 PM" src="https://github.com/user-attachments/assets/f35b61cd-91d0-4c43-8d73-068d498009cd" /> **Midtier desktop/ Highend Mobile / Slowdown on 1x throttled M1 Mac** <img width="509" height="126" alt="Screenshot 2025-07-24 at 6 01 38 PM" src="https://github.com/user-attachments/assets/0f5b6125-db31-49e5-a024-2629e8db55ca" /> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. --------- Co-authored-by: vigneshshanmugam <vignesh.shanmugam@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Shahzad <shahzad31comp@gmail.com> (cherry picked from commit 93daf0d)
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 5, 2025
## Summary + Optimize the heavy calls during rendering of Synthetics monitors overview page by memoizing the relevant calls and avoiding potential rerenders. Performance improvements speaks for themselves, attaching the context below ## Scenario With 5000 monitors - going to `app/synthetics` page - No scrolling - Just page load ### Before **M1 Mac - No throttle** <img width="787" height="166" alt="Screenshot 2025-07-24 at 5 39 02 PM" src="https://github.com/user-attachments/assets/8e48f060-ac13-4a64-88a3-48e9a4d1cda6" /> **Slowdown on 1x throttled M1 Mac** <img width="645" height="218" alt="Screenshot 2025-07-24 at 5 43 31 PM" src="https://github.com/user-attachments/assets/e9928a5d-da61-4ac2-b1bd-a99ca156eb7f" /> **Midtier desktop/ Highend Mobile** <img width="702" height="210" alt="Screenshot 2025-07-24 at 5 42 30 PM" src="https://github.com/user-attachments/assets/2c53c560-4f56-4182-9c5d-20a350c676f1" /> ### After **M1 Mac - No throttle** <img width="677" height="132" alt="Screenshot 2025-07-24 at 4 56 54 PM" src="https://github.com/user-attachments/assets/f35b61cd-91d0-4c43-8d73-068d498009cd" /> **Midtier desktop/ Highend Mobile / Slowdown on 1x throttled M1 Mac** <img width="509" height="126" alt="Screenshot 2025-07-24 at 6 01 38 PM" src="https://github.com/user-attachments/assets/0f5b6125-db31-49e5-a024-2629e8db55ca" /> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. --------- Co-authored-by: vigneshshanmugam <vignesh.shanmugam@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Shahzad <shahzad31comp@gmail.com> (cherry picked from commit 93daf0d)
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 5, 2025
## Summary + Optimize the heavy calls during rendering of Synthetics monitors overview page by memoizing the relevant calls and avoiding potential rerenders. Performance improvements speaks for themselves, attaching the context below ## Scenario With 5000 monitors - going to `app/synthetics` page - No scrolling - Just page load ### Before **M1 Mac - No throttle** <img width="787" height="166" alt="Screenshot 2025-07-24 at 5 39 02 PM" src="https://github.com/user-attachments/assets/8e48f060-ac13-4a64-88a3-48e9a4d1cda6" /> **Slowdown on 1x throttled M1 Mac** <img width="645" height="218" alt="Screenshot 2025-07-24 at 5 43 31 PM" src="https://github.com/user-attachments/assets/e9928a5d-da61-4ac2-b1bd-a99ca156eb7f" /> **Midtier desktop/ Highend Mobile** <img width="702" height="210" alt="Screenshot 2025-07-24 at 5 42 30 PM" src="https://github.com/user-attachments/assets/2c53c560-4f56-4182-9c5d-20a350c676f1" /> ### After **M1 Mac - No throttle** <img width="677" height="132" alt="Screenshot 2025-07-24 at 4 56 54 PM" src="https://github.com/user-attachments/assets/f35b61cd-91d0-4c43-8d73-068d498009cd" /> **Midtier desktop/ Highend Mobile / Slowdown on 1x throttled M1 Mac** <img width="509" height="126" alt="Screenshot 2025-07-24 at 6 01 38 PM" src="https://github.com/user-attachments/assets/0f5b6125-db31-49e5-a024-2629e8db55ca" /> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. --------- Co-authored-by: vigneshshanmugam <vignesh.shanmugam@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Shahzad <shahzad31comp@gmail.com> (cherry picked from commit 93daf0d)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
Aug 5, 2025
## Summary + Optimize the heavy calls during rendering of Synthetics monitors overview page by memoizing the relevant calls and avoiding potential rerenders. Performance improvements speaks for themselves, attaching the context below ## Scenario With 5000 monitors - going to `app/synthetics` page - No scrolling - Just page load ### Before **M1 Mac - No throttle** <img width="787" height="166" alt="Screenshot 2025-07-24 at 5 39 02 PM" src="https://github.com/user-attachments/assets/8e48f060-ac13-4a64-88a3-48e9a4d1cda6" /> **Slowdown on 1x throttled M1 Mac** <img width="645" height="218" alt="Screenshot 2025-07-24 at 5 43 31 PM" src="https://github.com/user-attachments/assets/e9928a5d-da61-4ac2-b1bd-a99ca156eb7f" /> **Midtier desktop/ Highend Mobile** <img width="702" height="210" alt="Screenshot 2025-07-24 at 5 42 30 PM" src="https://github.com/user-attachments/assets/2c53c560-4f56-4182-9c5d-20a350c676f1" /> ### After **M1 Mac - No throttle** <img width="677" height="132" alt="Screenshot 2025-07-24 at 4 56 54 PM" src="https://github.com/user-attachments/assets/f35b61cd-91d0-4c43-8d73-068d498009cd" /> **Midtier desktop/ Highend Mobile / Slowdown on 1x throttled M1 Mac** <img width="509" height="126" alt="Screenshot 2025-07-24 at 6 01 38 PM" src="https://github.com/user-attachments/assets/0f5b6125-db31-49e5-a024-2629e8db55ca" /> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. --------- Co-authored-by: vigneshshanmugam <vignesh.shanmugam@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Shahzad <shahzad31comp@gmail.com>
kibanamachine
added a commit
that referenced
this pull request
Aug 6, 2025
…230689) # Backport This will backport the following commits from `main` to `9.1`: - [perf(synthetics): improve use public location logic (#229391)](#229391) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Vignesh Shanmugam","email":"vignesh.shanmugam22@gmail.com"},"sourceCommit":{"committedDate":"2025-08-05T22:21:46Z","message":"perf(synthetics): improve use public location logic (#229391)\n\n## Summary\n\n+ Optimize the heavy calls during rendering of Synthetics monitors\noverview page by memoizing the relevant calls and avoiding potential\nrerenders. Performance improvements speaks for themselves, attaching the\ncontext below\n\n## Scenario \n\nWith 5000 monitors - going to `app/synthetics` page - No scrolling -\nJust page load\n\n### Before\n\n**M1 Mac - No throttle**\n<img width=\"787\" height=\"166\" alt=\"Screenshot 2025-07-24 at 5 39 02 PM\"\nsrc=\"https://github.com/user-attachments/assets/8e48f060-ac13-4a64-88a3-48e9a4d1cda6\"\n/>\n\n**Slowdown on 1x throttled M1 Mac**\n<img width=\"645\" height=\"218\" alt=\"Screenshot 2025-07-24 at 5 43 31 PM\"\nsrc=\"https://github.com/user-attachments/assets/e9928a5d-da61-4ac2-b1bd-a99ca156eb7f\"\n/>\n\n**Midtier desktop/ Highend Mobile**\n\n<img width=\"702\" height=\"210\" alt=\"Screenshot 2025-07-24 at 5 42 30 PM\"\nsrc=\"https://github.com/user-attachments/assets/2c53c560-4f56-4182-9c5d-20a350c676f1\"\n/>\n\n\n### After\n\n**M1 Mac - No throttle**\n<img width=\"677\" height=\"132\" alt=\"Screenshot 2025-07-24 at 4 56 54 PM\"\nsrc=\"https://github.com/user-attachments/assets/f35b61cd-91d0-4c43-8d73-068d498009cd\"\n/>\n\n**Midtier desktop/ Highend Mobile / Slowdown on 1x throttled M1 Mac**\n\n<img width=\"509\" height=\"126\" alt=\"Screenshot 2025-07-24 at 6 01 38 PM\"\nsrc=\"https://github.com/user-attachments/assets/0f5b6125-db31-49e5-a024-2629e8db55ca\"\n/>\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [ ] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n---------\n\nCo-authored-by: vigneshshanmugam <vignesh.shanmugam@elastic.co>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Shahzad <shahzad31comp@gmail.com>","sha":"93daf0db56f1e4d0bce80437cce9ba56e9ae00ee","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","backport:prev-major","Team:obs-ux-management","v9.2.0"],"title":"perf(synthetics): improve use public location logic","number":229391,"url":"https://github.com/elastic/kibana/pull/229391","mergeCommit":{"message":"perf(synthetics): improve use public location logic (#229391)\n\n## Summary\n\n+ Optimize the heavy calls during rendering of Synthetics monitors\noverview page by memoizing the relevant calls and avoiding potential\nrerenders. Performance improvements speaks for themselves, attaching the\ncontext below\n\n## Scenario \n\nWith 5000 monitors - going to `app/synthetics` page - No scrolling -\nJust page load\n\n### Before\n\n**M1 Mac - No throttle**\n<img width=\"787\" height=\"166\" alt=\"Screenshot 2025-07-24 at 5 39 02 PM\"\nsrc=\"https://github.com/user-attachments/assets/8e48f060-ac13-4a64-88a3-48e9a4d1cda6\"\n/>\n\n**Slowdown on 1x throttled M1 Mac**\n<img width=\"645\" height=\"218\" alt=\"Screenshot 2025-07-24 at 5 43 31 PM\"\nsrc=\"https://github.com/user-attachments/assets/e9928a5d-da61-4ac2-b1bd-a99ca156eb7f\"\n/>\n\n**Midtier desktop/ Highend Mobile**\n\n<img width=\"702\" height=\"210\" alt=\"Screenshot 2025-07-24 at 5 42 30 PM\"\nsrc=\"https://github.com/user-attachments/assets/2c53c560-4f56-4182-9c5d-20a350c676f1\"\n/>\n\n\n### After\n\n**M1 Mac - No throttle**\n<img width=\"677\" height=\"132\" alt=\"Screenshot 2025-07-24 at 4 56 54 PM\"\nsrc=\"https://github.com/user-attachments/assets/f35b61cd-91d0-4c43-8d73-068d498009cd\"\n/>\n\n**Midtier desktop/ Highend Mobile / Slowdown on 1x throttled M1 Mac**\n\n<img width=\"509\" height=\"126\" alt=\"Screenshot 2025-07-24 at 6 01 38 PM\"\nsrc=\"https://github.com/user-attachments/assets/0f5b6125-db31-49e5-a024-2629e8db55ca\"\n/>\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [ ] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n---------\n\nCo-authored-by: vigneshshanmugam <vignesh.shanmugam@elastic.co>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Shahzad <shahzad31comp@gmail.com>","sha":"93daf0db56f1e4d0bce80437cce9ba56e9ae00ee"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/229391","number":229391,"mergeCommit":{"message":"perf(synthetics): improve use public location logic (#229391)\n\n## Summary\n\n+ Optimize the heavy calls during rendering of Synthetics monitors\noverview page by memoizing the relevant calls and avoiding potential\nrerenders. Performance improvements speaks for themselves, attaching the\ncontext below\n\n## Scenario \n\nWith 5000 monitors - going to `app/synthetics` page - No scrolling -\nJust page load\n\n### Before\n\n**M1 Mac - No throttle**\n<img width=\"787\" height=\"166\" alt=\"Screenshot 2025-07-24 at 5 39 02 PM\"\nsrc=\"https://github.com/user-attachments/assets/8e48f060-ac13-4a64-88a3-48e9a4d1cda6\"\n/>\n\n**Slowdown on 1x throttled M1 Mac**\n<img width=\"645\" height=\"218\" alt=\"Screenshot 2025-07-24 at 5 43 31 PM\"\nsrc=\"https://github.com/user-attachments/assets/e9928a5d-da61-4ac2-b1bd-a99ca156eb7f\"\n/>\n\n**Midtier desktop/ Highend Mobile**\n\n<img width=\"702\" height=\"210\" alt=\"Screenshot 2025-07-24 at 5 42 30 PM\"\nsrc=\"https://github.com/user-attachments/assets/2c53c560-4f56-4182-9c5d-20a350c676f1\"\n/>\n\n\n### After\n\n**M1 Mac - No throttle**\n<img width=\"677\" height=\"132\" alt=\"Screenshot 2025-07-24 at 4 56 54 PM\"\nsrc=\"https://github.com/user-attachments/assets/f35b61cd-91d0-4c43-8d73-068d498009cd\"\n/>\n\n**Midtier desktop/ Highend Mobile / Slowdown on 1x throttled M1 Mac**\n\n<img width=\"509\" height=\"126\" alt=\"Screenshot 2025-07-24 at 6 01 38 PM\"\nsrc=\"https://github.com/user-attachments/assets/0f5b6125-db31-49e5-a024-2629e8db55ca\"\n/>\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [ ] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n---------\n\nCo-authored-by: vigneshshanmugam <vignesh.shanmugam@elastic.co>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Shahzad <shahzad31comp@gmail.com>","sha":"93daf0db56f1e4d0bce80437cce9ba56e9ae00ee"}}]}] BACKPORT--> Co-authored-by: Vignesh Shanmugam <vignesh.shanmugam22@gmail.com> Co-authored-by: vigneshshanmugam <vignesh.shanmugam@elastic.co> Co-authored-by: Shahzad <shahzad31comp@gmail.com>
kibanamachine
added a commit
that referenced
this pull request
Aug 6, 2025
…230686) # Backport This will backport the following commits from `main` to `8.17`: - [perf(synthetics): improve use public location logic (#229391)](#229391) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Vignesh Shanmugam","email":"vignesh.shanmugam22@gmail.com"},"sourceCommit":{"committedDate":"2025-08-05T22:21:46Z","message":"perf(synthetics): improve use public location logic (#229391)\n\n## Summary\n\n+ Optimize the heavy calls during rendering of Synthetics monitors\noverview page by memoizing the relevant calls and avoiding potential\nrerenders. Performance improvements speaks for themselves, attaching the\ncontext below\n\n## Scenario \n\nWith 5000 monitors - going to `app/synthetics` page - No scrolling -\nJust page load\n\n### Before\n\n**M1 Mac - No throttle**\n<img width=\"787\" height=\"166\" alt=\"Screenshot 2025-07-24 at 5 39 02 PM\"\nsrc=\"https://github.com/user-attachments/assets/8e48f060-ac13-4a64-88a3-48e9a4d1cda6\"\n/>\n\n**Slowdown on 1x throttled M1 Mac**\n<img width=\"645\" height=\"218\" alt=\"Screenshot 2025-07-24 at 5 43 31 PM\"\nsrc=\"https://github.com/user-attachments/assets/e9928a5d-da61-4ac2-b1bd-a99ca156eb7f\"\n/>\n\n**Midtier desktop/ Highend Mobile**\n\n<img width=\"702\" height=\"210\" alt=\"Screenshot 2025-07-24 at 5 42 30 PM\"\nsrc=\"https://github.com/user-attachments/assets/2c53c560-4f56-4182-9c5d-20a350c676f1\"\n/>\n\n\n### After\n\n**M1 Mac - No throttle**\n<img width=\"677\" height=\"132\" alt=\"Screenshot 2025-07-24 at 4 56 54 PM\"\nsrc=\"https://github.com/user-attachments/assets/f35b61cd-91d0-4c43-8d73-068d498009cd\"\n/>\n\n**Midtier desktop/ Highend Mobile / Slowdown on 1x throttled M1 Mac**\n\n<img width=\"509\" height=\"126\" alt=\"Screenshot 2025-07-24 at 6 01 38 PM\"\nsrc=\"https://github.com/user-attachments/assets/0f5b6125-db31-49e5-a024-2629e8db55ca\"\n/>\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [ ] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n---------\n\nCo-authored-by: vigneshshanmugam <vignesh.shanmugam@elastic.co>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Shahzad <shahzad31comp@gmail.com>","sha":"93daf0db56f1e4d0bce80437cce9ba56e9ae00ee","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","backport:prev-major","Team:obs-ux-management","v9.2.0"],"title":"perf(synthetics): improve use public location logic","number":229391,"url":"https://github.com/elastic/kibana/pull/229391","mergeCommit":{"message":"perf(synthetics): improve use public location logic (#229391)\n\n## Summary\n\n+ Optimize the heavy calls during rendering of Synthetics monitors\noverview page by memoizing the relevant calls and avoiding potential\nrerenders. Performance improvements speaks for themselves, attaching the\ncontext below\n\n## Scenario \n\nWith 5000 monitors - going to `app/synthetics` page - No scrolling -\nJust page load\n\n### Before\n\n**M1 Mac - No throttle**\n<img width=\"787\" height=\"166\" alt=\"Screenshot 2025-07-24 at 5 39 02 PM\"\nsrc=\"https://github.com/user-attachments/assets/8e48f060-ac13-4a64-88a3-48e9a4d1cda6\"\n/>\n\n**Slowdown on 1x throttled M1 Mac**\n<img width=\"645\" height=\"218\" alt=\"Screenshot 2025-07-24 at 5 43 31 PM\"\nsrc=\"https://github.com/user-attachments/assets/e9928a5d-da61-4ac2-b1bd-a99ca156eb7f\"\n/>\n\n**Midtier desktop/ Highend Mobile**\n\n<img width=\"702\" height=\"210\" alt=\"Screenshot 2025-07-24 at 5 42 30 PM\"\nsrc=\"https://github.com/user-attachments/assets/2c53c560-4f56-4182-9c5d-20a350c676f1\"\n/>\n\n\n### After\n\n**M1 Mac - No throttle**\n<img width=\"677\" height=\"132\" alt=\"Screenshot 2025-07-24 at 4 56 54 PM\"\nsrc=\"https://github.com/user-attachments/assets/f35b61cd-91d0-4c43-8d73-068d498009cd\"\n/>\n\n**Midtier desktop/ Highend Mobile / Slowdown on 1x throttled M1 Mac**\n\n<img width=\"509\" height=\"126\" alt=\"Screenshot 2025-07-24 at 6 01 38 PM\"\nsrc=\"https://github.com/user-attachments/assets/0f5b6125-db31-49e5-a024-2629e8db55ca\"\n/>\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [ ] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n---------\n\nCo-authored-by: vigneshshanmugam <vignesh.shanmugam@elastic.co>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Shahzad <shahzad31comp@gmail.com>","sha":"93daf0db56f1e4d0bce80437cce9ba56e9ae00ee"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/229391","number":229391,"mergeCommit":{"message":"perf(synthetics): improve use public location logic (#229391)\n\n## Summary\n\n+ Optimize the heavy calls during rendering of Synthetics monitors\noverview page by memoizing the relevant calls and avoiding potential\nrerenders. Performance improvements speaks for themselves, attaching the\ncontext below\n\n## Scenario \n\nWith 5000 monitors - going to `app/synthetics` page - No scrolling -\nJust page load\n\n### Before\n\n**M1 Mac - No throttle**\n<img width=\"787\" height=\"166\" alt=\"Screenshot 2025-07-24 at 5 39 02 PM\"\nsrc=\"https://github.com/user-attachments/assets/8e48f060-ac13-4a64-88a3-48e9a4d1cda6\"\n/>\n\n**Slowdown on 1x throttled M1 Mac**\n<img width=\"645\" height=\"218\" alt=\"Screenshot 2025-07-24 at 5 43 31 PM\"\nsrc=\"https://github.com/user-attachments/assets/e9928a5d-da61-4ac2-b1bd-a99ca156eb7f\"\n/>\n\n**Midtier desktop/ Highend Mobile**\n\n<img width=\"702\" height=\"210\" alt=\"Screenshot 2025-07-24 at 5 42 30 PM\"\nsrc=\"https://github.com/user-attachments/assets/2c53c560-4f56-4182-9c5d-20a350c676f1\"\n/>\n\n\n### After\n\n**M1 Mac - No throttle**\n<img width=\"677\" height=\"132\" alt=\"Screenshot 2025-07-24 at 4 56 54 PM\"\nsrc=\"https://github.com/user-attachments/assets/f35b61cd-91d0-4c43-8d73-068d498009cd\"\n/>\n\n**Midtier desktop/ Highend Mobile / Slowdown on 1x throttled M1 Mac**\n\n<img width=\"509\" height=\"126\" alt=\"Screenshot 2025-07-24 at 6 01 38 PM\"\nsrc=\"https://github.com/user-attachments/assets/0f5b6125-db31-49e5-a024-2629e8db55ca\"\n/>\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [ ] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n---------\n\nCo-authored-by: vigneshshanmugam <vignesh.shanmugam@elastic.co>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Shahzad <shahzad31comp@gmail.com>","sha":"93daf0db56f1e4d0bce80437cce9ba56e9ae00ee"}}]}] BACKPORT--> Co-authored-by: Vignesh Shanmugam <vignesh.shanmugam22@gmail.com> Co-authored-by: vigneshshanmugam <vignesh.shanmugam@elastic.co> Co-authored-by: Shahzad <shahzad31comp@gmail.com>
kibanamachine
added a commit
that referenced
this pull request
Aug 6, 2025
…230687) # Backport This will backport the following commits from `main` to `8.18`: - [perf(synthetics): improve use public location logic (#229391)](#229391) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Vignesh Shanmugam","email":"vignesh.shanmugam22@gmail.com"},"sourceCommit":{"committedDate":"2025-08-05T22:21:46Z","message":"perf(synthetics): improve use public location logic (#229391)\n\n## Summary\n\n+ Optimize the heavy calls during rendering of Synthetics monitors\noverview page by memoizing the relevant calls and avoiding potential\nrerenders. Performance improvements speaks for themselves, attaching the\ncontext below\n\n## Scenario \n\nWith 5000 monitors - going to `app/synthetics` page - No scrolling -\nJust page load\n\n### Before\n\n**M1 Mac - No throttle**\n<img width=\"787\" height=\"166\" alt=\"Screenshot 2025-07-24 at 5 39 02 PM\"\nsrc=\"https://github.com/user-attachments/assets/8e48f060-ac13-4a64-88a3-48e9a4d1cda6\"\n/>\n\n**Slowdown on 1x throttled M1 Mac**\n<img width=\"645\" height=\"218\" alt=\"Screenshot 2025-07-24 at 5 43 31 PM\"\nsrc=\"https://github.com/user-attachments/assets/e9928a5d-da61-4ac2-b1bd-a99ca156eb7f\"\n/>\n\n**Midtier desktop/ Highend Mobile**\n\n<img width=\"702\" height=\"210\" alt=\"Screenshot 2025-07-24 at 5 42 30 PM\"\nsrc=\"https://github.com/user-attachments/assets/2c53c560-4f56-4182-9c5d-20a350c676f1\"\n/>\n\n\n### After\n\n**M1 Mac - No throttle**\n<img width=\"677\" height=\"132\" alt=\"Screenshot 2025-07-24 at 4 56 54 PM\"\nsrc=\"https://github.com/user-attachments/assets/f35b61cd-91d0-4c43-8d73-068d498009cd\"\n/>\n\n**Midtier desktop/ Highend Mobile / Slowdown on 1x throttled M1 Mac**\n\n<img width=\"509\" height=\"126\" alt=\"Screenshot 2025-07-24 at 6 01 38 PM\"\nsrc=\"https://github.com/user-attachments/assets/0f5b6125-db31-49e5-a024-2629e8db55ca\"\n/>\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [ ] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n---------\n\nCo-authored-by: vigneshshanmugam <vignesh.shanmugam@elastic.co>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Shahzad <shahzad31comp@gmail.com>","sha":"93daf0db56f1e4d0bce80437cce9ba56e9ae00ee","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","backport:prev-major","Team:obs-ux-management","v9.2.0"],"title":"perf(synthetics): improve use public location logic","number":229391,"url":"https://github.com/elastic/kibana/pull/229391","mergeCommit":{"message":"perf(synthetics): improve use public location logic (#229391)\n\n## Summary\n\n+ Optimize the heavy calls during rendering of Synthetics monitors\noverview page by memoizing the relevant calls and avoiding potential\nrerenders. Performance improvements speaks for themselves, attaching the\ncontext below\n\n## Scenario \n\nWith 5000 monitors - going to `app/synthetics` page - No scrolling -\nJust page load\n\n### Before\n\n**M1 Mac - No throttle**\n<img width=\"787\" height=\"166\" alt=\"Screenshot 2025-07-24 at 5 39 02 PM\"\nsrc=\"https://github.com/user-attachments/assets/8e48f060-ac13-4a64-88a3-48e9a4d1cda6\"\n/>\n\n**Slowdown on 1x throttled M1 Mac**\n<img width=\"645\" height=\"218\" alt=\"Screenshot 2025-07-24 at 5 43 31 PM\"\nsrc=\"https://github.com/user-attachments/assets/e9928a5d-da61-4ac2-b1bd-a99ca156eb7f\"\n/>\n\n**Midtier desktop/ Highend Mobile**\n\n<img width=\"702\" height=\"210\" alt=\"Screenshot 2025-07-24 at 5 42 30 PM\"\nsrc=\"https://github.com/user-attachments/assets/2c53c560-4f56-4182-9c5d-20a350c676f1\"\n/>\n\n\n### After\n\n**M1 Mac - No throttle**\n<img width=\"677\" height=\"132\" alt=\"Screenshot 2025-07-24 at 4 56 54 PM\"\nsrc=\"https://github.com/user-attachments/assets/f35b61cd-91d0-4c43-8d73-068d498009cd\"\n/>\n\n**Midtier desktop/ Highend Mobile / Slowdown on 1x throttled M1 Mac**\n\n<img width=\"509\" height=\"126\" alt=\"Screenshot 2025-07-24 at 6 01 38 PM\"\nsrc=\"https://github.com/user-attachments/assets/0f5b6125-db31-49e5-a024-2629e8db55ca\"\n/>\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [ ] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n---------\n\nCo-authored-by: vigneshshanmugam <vignesh.shanmugam@elastic.co>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Shahzad <shahzad31comp@gmail.com>","sha":"93daf0db56f1e4d0bce80437cce9ba56e9ae00ee"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/229391","number":229391,"mergeCommit":{"message":"perf(synthetics): improve use public location logic (#229391)\n\n## Summary\n\n+ Optimize the heavy calls during rendering of Synthetics monitors\noverview page by memoizing the relevant calls and avoiding potential\nrerenders. Performance improvements speaks for themselves, attaching the\ncontext below\n\n## Scenario \n\nWith 5000 monitors - going to `app/synthetics` page - No scrolling -\nJust page load\n\n### Before\n\n**M1 Mac - No throttle**\n<img width=\"787\" height=\"166\" alt=\"Screenshot 2025-07-24 at 5 39 02 PM\"\nsrc=\"https://github.com/user-attachments/assets/8e48f060-ac13-4a64-88a3-48e9a4d1cda6\"\n/>\n\n**Slowdown on 1x throttled M1 Mac**\n<img width=\"645\" height=\"218\" alt=\"Screenshot 2025-07-24 at 5 43 31 PM\"\nsrc=\"https://github.com/user-attachments/assets/e9928a5d-da61-4ac2-b1bd-a99ca156eb7f\"\n/>\n\n**Midtier desktop/ Highend Mobile**\n\n<img width=\"702\" height=\"210\" alt=\"Screenshot 2025-07-24 at 5 42 30 PM\"\nsrc=\"https://github.com/user-attachments/assets/2c53c560-4f56-4182-9c5d-20a350c676f1\"\n/>\n\n\n### After\n\n**M1 Mac - No throttle**\n<img width=\"677\" height=\"132\" alt=\"Screenshot 2025-07-24 at 4 56 54 PM\"\nsrc=\"https://github.com/user-attachments/assets/f35b61cd-91d0-4c43-8d73-068d498009cd\"\n/>\n\n**Midtier desktop/ Highend Mobile / Slowdown on 1x throttled M1 Mac**\n\n<img width=\"509\" height=\"126\" alt=\"Screenshot 2025-07-24 at 6 01 38 PM\"\nsrc=\"https://github.com/user-attachments/assets/0f5b6125-db31-49e5-a024-2629e8db55ca\"\n/>\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [ ] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n---------\n\nCo-authored-by: vigneshshanmugam <vignesh.shanmugam@elastic.co>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Shahzad <shahzad31comp@gmail.com>","sha":"93daf0db56f1e4d0bce80437cce9ba56e9ae00ee"}}]}] BACKPORT--> Co-authored-by: Vignesh Shanmugam <vignesh.shanmugam22@gmail.com> Co-authored-by: vigneshshanmugam <vignesh.shanmugam@elastic.co> Co-authored-by: Shahzad <shahzad31comp@gmail.com>
kibanamachine
added
v8.18.5
backport missing
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
Member
Author
|
@justinkambic any clue what labels are missed for this PR? |
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
4 similar comments
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
NicholasPeretti
pushed a commit
to NicholasPeretti/kibana
that referenced
this pull request
Aug 18, 2025
## Summary + Optimize the heavy calls during rendering of Synthetics monitors overview page by memoizing the relevant calls and avoiding potential rerenders. Performance improvements speaks for themselves, attaching the context below ## Scenario With 5000 monitors - going to `app/synthetics` page - No scrolling - Just page load ### Before **M1 Mac - No throttle** <img width="787" height="166" alt="Screenshot 2025-07-24 at 5 39 02 PM" src="https://github.com/user-attachments/assets/8e48f060-ac13-4a64-88a3-48e9a4d1cda6" /> **Slowdown on 1x throttled M1 Mac** <img width="645" height="218" alt="Screenshot 2025-07-24 at 5 43 31 PM" src="https://github.com/user-attachments/assets/e9928a5d-da61-4ac2-b1bd-a99ca156eb7f" /> **Midtier desktop/ Highend Mobile** <img width="702" height="210" alt="Screenshot 2025-07-24 at 5 42 30 PM" src="https://github.com/user-attachments/assets/2c53c560-4f56-4182-9c5d-20a350c676f1" /> ### After **M1 Mac - No throttle** <img width="677" height="132" alt="Screenshot 2025-07-24 at 4 56 54 PM" src="https://github.com/user-attachments/assets/f35b61cd-91d0-4c43-8d73-068d498009cd" /> **Midtier desktop/ Highend Mobile / Slowdown on 1x throttled M1 Mac** <img width="509" height="126" alt="Screenshot 2025-07-24 at 6 01 38 PM" src="https://github.com/user-attachments/assets/0f5b6125-db31-49e5-a024-2629e8db55ca" /> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. --------- Co-authored-by: vigneshshanmugam <vignesh.shanmugam@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Shahzad <shahzad31comp@gmail.com>
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
kibanamachine
added a commit
that referenced
this pull request
Aug 19, 2025
…230688) # Backport This will backport the following commits from `main` to `8.19`: - [perf(synthetics): improve use public location logic (#229391)](#229391) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Vignesh Shanmugam","email":"vignesh.shanmugam22@gmail.com"},"sourceCommit":{"committedDate":"2025-08-05T22:21:46Z","message":"perf(synthetics): improve use public location logic (#229391)\n\n## Summary\n\n+ Optimize the heavy calls during rendering of Synthetics monitors\noverview page by memoizing the relevant calls and avoiding potential\nrerenders. Performance improvements speaks for themselves, attaching the\ncontext below\n\n## Scenario \n\nWith 5000 monitors - going to `app/synthetics` page - No scrolling -\nJust page load\n\n### Before\n\n**M1 Mac - No throttle**\n<img width=\"787\" height=\"166\" alt=\"Screenshot 2025-07-24 at 5 39 02 PM\"\nsrc=\"https://github.com/user-attachments/assets/8e48f060-ac13-4a64-88a3-48e9a4d1cda6\"\n/>\n\n**Slowdown on 1x throttled M1 Mac**\n<img width=\"645\" height=\"218\" alt=\"Screenshot 2025-07-24 at 5 43 31 PM\"\nsrc=\"https://github.com/user-attachments/assets/e9928a5d-da61-4ac2-b1bd-a99ca156eb7f\"\n/>\n\n**Midtier desktop/ Highend Mobile**\n\n<img width=\"702\" height=\"210\" alt=\"Screenshot 2025-07-24 at 5 42 30 PM\"\nsrc=\"https://github.com/user-attachments/assets/2c53c560-4f56-4182-9c5d-20a350c676f1\"\n/>\n\n\n### After\n\n**M1 Mac - No throttle**\n<img width=\"677\" height=\"132\" alt=\"Screenshot 2025-07-24 at 4 56 54 PM\"\nsrc=\"https://github.com/user-attachments/assets/f35b61cd-91d0-4c43-8d73-068d498009cd\"\n/>\n\n**Midtier desktop/ Highend Mobile / Slowdown on 1x throttled M1 Mac**\n\n<img width=\"509\" height=\"126\" alt=\"Screenshot 2025-07-24 at 6 01 38 PM\"\nsrc=\"https://github.com/user-attachments/assets/0f5b6125-db31-49e5-a024-2629e8db55ca\"\n/>\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [ ] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n---------\n\nCo-authored-by: vigneshshanmugam <vignesh.shanmugam@elastic.co>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Shahzad <shahzad31comp@gmail.com>","sha":"93daf0db56f1e4d0bce80437cce9ba56e9ae00ee","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","backport:prev-major","Team:obs-ux-management","v9.2.0"],"title":"perf(synthetics): improve use public location logic","number":229391,"url":"https://github.com/elastic/kibana/pull/229391","mergeCommit":{"message":"perf(synthetics): improve use public location logic (#229391)\n\n## Summary\n\n+ Optimize the heavy calls during rendering of Synthetics monitors\noverview page by memoizing the relevant calls and avoiding potential\nrerenders. Performance improvements speaks for themselves, attaching the\ncontext below\n\n## Scenario \n\nWith 5000 monitors - going to `app/synthetics` page - No scrolling -\nJust page load\n\n### Before\n\n**M1 Mac - No throttle**\n<img width=\"787\" height=\"166\" alt=\"Screenshot 2025-07-24 at 5 39 02 PM\"\nsrc=\"https://github.com/user-attachments/assets/8e48f060-ac13-4a64-88a3-48e9a4d1cda6\"\n/>\n\n**Slowdown on 1x throttled M1 Mac**\n<img width=\"645\" height=\"218\" alt=\"Screenshot 2025-07-24 at 5 43 31 PM\"\nsrc=\"https://github.com/user-attachments/assets/e9928a5d-da61-4ac2-b1bd-a99ca156eb7f\"\n/>\n\n**Midtier desktop/ Highend Mobile**\n\n<img width=\"702\" height=\"210\" alt=\"Screenshot 2025-07-24 at 5 42 30 PM\"\nsrc=\"https://github.com/user-attachments/assets/2c53c560-4f56-4182-9c5d-20a350c676f1\"\n/>\n\n\n### After\n\n**M1 Mac - No throttle**\n<img width=\"677\" height=\"132\" alt=\"Screenshot 2025-07-24 at 4 56 54 PM\"\nsrc=\"https://github.com/user-attachments/assets/f35b61cd-91d0-4c43-8d73-068d498009cd\"\n/>\n\n**Midtier desktop/ Highend Mobile / Slowdown on 1x throttled M1 Mac**\n\n<img width=\"509\" height=\"126\" alt=\"Screenshot 2025-07-24 at 6 01 38 PM\"\nsrc=\"https://github.com/user-attachments/assets/0f5b6125-db31-49e5-a024-2629e8db55ca\"\n/>\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [ ] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n---------\n\nCo-authored-by: vigneshshanmugam <vignesh.shanmugam@elastic.co>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Shahzad <shahzad31comp@gmail.com>","sha":"93daf0db56f1e4d0bce80437cce9ba56e9ae00ee"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/229391","number":229391,"mergeCommit":{"message":"perf(synthetics): improve use public location logic (#229391)\n\n## Summary\n\n+ Optimize the heavy calls during rendering of Synthetics monitors\noverview page by memoizing the relevant calls and avoiding potential\nrerenders. Performance improvements speaks for themselves, attaching the\ncontext below\n\n## Scenario \n\nWith 5000 monitors - going to `app/synthetics` page - No scrolling -\nJust page load\n\n### Before\n\n**M1 Mac - No throttle**\n<img width=\"787\" height=\"166\" alt=\"Screenshot 2025-07-24 at 5 39 02 PM\"\nsrc=\"https://github.com/user-attachments/assets/8e48f060-ac13-4a64-88a3-48e9a4d1cda6\"\n/>\n\n**Slowdown on 1x throttled M1 Mac**\n<img width=\"645\" height=\"218\" alt=\"Screenshot 2025-07-24 at 5 43 31 PM\"\nsrc=\"https://github.com/user-attachments/assets/e9928a5d-da61-4ac2-b1bd-a99ca156eb7f\"\n/>\n\n**Midtier desktop/ Highend Mobile**\n\n<img width=\"702\" height=\"210\" alt=\"Screenshot 2025-07-24 at 5 42 30 PM\"\nsrc=\"https://github.com/user-attachments/assets/2c53c560-4f56-4182-9c5d-20a350c676f1\"\n/>\n\n\n### After\n\n**M1 Mac - No throttle**\n<img width=\"677\" height=\"132\" alt=\"Screenshot 2025-07-24 at 4 56 54 PM\"\nsrc=\"https://github.com/user-attachments/assets/f35b61cd-91d0-4c43-8d73-068d498009cd\"\n/>\n\n**Midtier desktop/ Highend Mobile / Slowdown on 1x throttled M1 Mac**\n\n<img width=\"509\" height=\"126\" alt=\"Screenshot 2025-07-24 at 6 01 38 PM\"\nsrc=\"https://github.com/user-attachments/assets/0f5b6125-db31-49e5-a024-2629e8db55ca\"\n/>\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [ ] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n---------\n\nCo-authored-by: vigneshshanmugam <vignesh.shanmugam@elastic.co>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Shahzad <shahzad31comp@gmail.com>","sha":"93daf0db56f1e4d0bce80437cce9ba56e9ae00ee"}}]}] BACKPORT--> Co-authored-by: Vignesh Shanmugam <vignesh.shanmugam22@gmail.com> Co-authored-by: vigneshshanmugam <vignesh.shanmugam@elastic.co> Co-authored-by: Shahzad <shahzad31comp@gmail.com>
kibanamachine
added
v8.19.3
and removed
backport missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Scenario
With 5000 monitors - going to
app/syntheticspage - No scrolling - Just page loadBefore
M1 Mac - No throttle
Slowdown on 1x throttled M1 Mac
Midtier desktop/ Highend Mobile
After
M1 Mac - No throttle
Midtier desktop/ Highend Mobile / Slowdown on 1x throttled M1 Mac
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesbackport:*labels.