-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Automatic Import] Tell users about the log formats we support #229375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Automatic Import] Tell users about the log formats we support #229375
Conversation
|
Pinging @elastic/security-scalability (Team:Security-Scalability) |
x-pack/platform/plugins/shared/automatic_import/public/common/constants.ts
Outdated
Show resolved
Hide resolved
florent-leborgne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Hi, I left a comment inline with some suggestion to better place the link and at the very least not make it look like it's connected to the AI 3rd party information.
...components/create_integration/create_automatic_import/steps/data_stream_step/translations.ts
Outdated
Show resolved
Hide resolved
florent-leborgne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy LGTM, thank you!
As a last and optional improvement, I'd consider making this new text shorter. For example (from shortest to longest, pick or ignore according to your preference):
- Supported log formats
- View supported log formats
- View supported log formats in the documentation
0b82e7d to
d1c75a6
Compare
|
@elasticmachine merge upstream |
x-pack/platform/plugins/shared/automatic_import/public/common/hooks/use_doclinks.ts
Show resolved
Hide resolved
kgeller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
abb4d2b to
8cc50a3
Compare
… under title with better wording
8cc50a3 to
db4adce
Compare
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Page load bundle
History
|
|
@elasticmachine merge upstream |
|
Starting backport for target branches: 9.1 https://github.com/elastic/kibana/actions/runs/16760390097 |
…ic#229375) ## Release Notes Adds Automatic Import documentation links for users in log description and the error message so that users have better access to the data types that are valid. Closes elastic#196039 ## Summary <img width="727" height="279" alt="image" src="https://github.com/user-attachments/assets/01337a68-4684-4506-b927-e4cbbd6a06b4" /> <img width="756" height="179" alt="image" src="https://github.com/user-attachments/assets/09f4b291-39a8-4adb-8e58-52797fe2e7ca" /> ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [x] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit d83396f)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…229375) (#230671) # Backport This will backport the following commits from `main` to `9.1`: - [[Automatic Import] Tell users about the log formats we support (#229375)](#229375) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Robert So (robester0403)","email":"85914248+robester0403@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-08-05T20:19:04Z","message":"[Automatic Import] Tell users about the log formats we support (#229375)\n\n## Release Notes\n\nAdds Automatic Import documentation links for users in log description\nand the error message so that users have better access to the data types\nthat are valid.\n\nCloses https://github.com/elastic/kibana/issues/196039\n\n## Summary\n\n<img width=\"727\" height=\"279\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/01337a68-4684-4506-b927-e4cbbd6a06b4\"\n/>\n\n<img width=\"756\" height=\"179\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/09f4b291-39a8-4adb-8e58-52797fe2e7ca\"\n/>\n\n\n### Checklist\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [x]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [x] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"d83396f8a1f7b798aa85b97c45c8335f126a94bf","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["enhancement","release_note:feature","backport:prev-minor","Team:Security-Scalability","Feature:AutomaticImport","v9.2.0"],"title":"[Automatic Import] Tell users about the log formats we support","number":229375,"url":"https://github.com/elastic/kibana/pull/229375","mergeCommit":{"message":"[Automatic Import] Tell users about the log formats we support (#229375)\n\n## Release Notes\n\nAdds Automatic Import documentation links for users in log description\nand the error message so that users have better access to the data types\nthat are valid.\n\nCloses https://github.com/elastic/kibana/issues/196039\n\n## Summary\n\n<img width=\"727\" height=\"279\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/01337a68-4684-4506-b927-e4cbbd6a06b4\"\n/>\n\n<img width=\"756\" height=\"179\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/09f4b291-39a8-4adb-8e58-52797fe2e7ca\"\n/>\n\n\n### Checklist\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [x]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [x] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"d83396f8a1f7b798aa85b97c45c8335f126a94bf"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/229375","number":229375,"mergeCommit":{"message":"[Automatic Import] Tell users about the log formats we support (#229375)\n\n## Release Notes\n\nAdds Automatic Import documentation links for users in log description\nand the error message so that users have better access to the data types\nthat are valid.\n\nCloses https://github.com/elastic/kibana/issues/196039\n\n## Summary\n\n<img width=\"727\" height=\"279\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/01337a68-4684-4506-b927-e4cbbd6a06b4\"\n/>\n\n<img width=\"756\" height=\"179\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/09f4b291-39a8-4adb-8e58-52797fe2e7ca\"\n/>\n\n\n### Checklist\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [x]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [x] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"d83396f8a1f7b798aa85b97c45c8335f126a94bf"}}]}] BACKPORT--> Co-authored-by: Robert So (robester0403) <85914248+robester0403@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
…ic#229375) ## Release Notes Adds Automatic Import documentation links for users in log description and the error message so that users have better access to the data types that are valid. Closes elastic#196039 ## Summary <img width="727" height="279" alt="image" src="https://github.com/user-attachments/assets/01337a68-4684-4506-b927-e4cbbd6a06b4" /> <img width="756" height="179" alt="image" src="https://github.com/user-attachments/assets/09f4b291-39a8-4adb-8e58-52797fe2e7ca" /> ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [x] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
…ic#229375) ## Release Notes Adds Automatic Import documentation links for users in log description and the error message so that users have better access to the data types that are valid. Closes elastic#196039 ## Summary <img width="727" height="279" alt="image" src="https://github.com/user-attachments/assets/01337a68-4684-4506-b927-e4cbbd6a06b4" /> <img width="756" height="179" alt="image" src="https://github.com/user-attachments/assets/09f4b291-39a8-4adb-8e58-52797fe2e7ca" /> ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [x] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Release Notes
Adds Automatic Import documentation links for users in log description and the error message so that users have better access to the data types that are valid.
Closes #196039
Summary
Checklist
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesbackport:*labels.Identify risks
Very few risks.