[Lens] Extract secondary metric information as an utility #229323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariairiartef
force-pushed
the
lens/228964/secondary-metric-info
branch
from
0eb1456 to
73328b7
Compare
mariairiartef
force-pushed
the
lens/228964/secondary-metric-info
branch
from
73328b7 to
6a10597
Compare
mariairiartef
added
refactoring
Team:Visualizations
Contributor
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
dej611
reviewed
Jul 29, 2025
...rm/plugins/shared/chart_expressions/expression_metric/public/components/secondary_metric.tsx
Outdated
Show resolved
Hide resolved
...rm/plugins/shared/chart_expressions/expression_metric/public/components/secondary_metric.tsx
Outdated
Show resolved
Hide resolved
dej611
approved these changes
Jul 30, 2025
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Async chunks
History
|
kibanamachine
added
the
backport missing
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
1 similar comment
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
Aug 5, 2025
…9323) Part of elastic#228964 ## Summary As part of elastic#228964, this extracts secondary metric information into a utility function. The goal is to prepare for the adoption of the new metric chart version introduced in elastic/elastic-charts#2666, so we can use the default secondary metric component with the data provided by this utility. ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
1 similar comment
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
mariairiartef
added
backport:skip
kibanamachine
removed
the
backport missing
NicholasPeretti
pushed a commit
to NicholasPeretti/kibana
that referenced
this pull request
Aug 18, 2025
…9323) Part of elastic#228964 ## Summary As part of elastic#228964, this extracts secondary metric information into a utility function. The goal is to prepare for the adoption of the new metric chart version introduced in elastic/elastic-charts#2666, so we can use the default secondary metric component with the data provided by this utility. ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #228964
Summary
As part of #228964, this extracts secondary metric information into a utility function. The goal is to prepare for the adoption of the new metric chart version introduced in elastic/elastic-charts#2666, so we can use the default secondary metric component with the data provided by this utility.
Checklist
release_note:*label is applied per the guidelinesbackport:*labels.