fix: workflows management plugin bundle size #229309

Kiryous · 2025-07-24T12:06:36Z

Summary

Before

422K workflowsManagement.plugin.js

After

4.1K workflowsManagement.plugin.js

Root cause

Direct export of the WorkflowExecution component added 336kb
https://github.com/Kiryous/kibana/blob/main/src/platform/plugins/shared/workflows_management/public/index.ts#L18
import of generateYamlSchemaFromConnectors in common/index added another 82kb https://github.com/Kiryous/kibana/blob/5d05dd06aa40b75885cb5496f5af3ae825b1f773/src/platform/plugins/shared/workflows_management/common/index.ts#L10
Without these, the plugin bundle size is modest 4.1K

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
Flaky Test Runner was used on any tests changed
The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
Review the backport guidelines and apply applicable backport:* labels.

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

See some risk examples
...

…oid inclusion into bundle

talboren

lgtm

# Conflicts: # src/platform/plugins/shared/workflows_management/common/index.ts # src/platform/plugins/shared/workflows_management/public/pages/workflow_detail/index.tsx # src/platform/plugins/shared/workflows_management/server/workflows_management/workflows_management_service.ts

…ting/log_threshold/components/expression_editor/criterion.tsx` eslint autofix

elasticmachine · 2025-08-04T11:28:22Z

💚 Build Succeeded

Buildkite Build
Commit: 56c7465

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`workflowsManagement`	372	374	+2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`workflowsManagement`	20	17	-3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`workflowsManagement`	32.7KB	451.4KB	⚠️ +418.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`workflowsManagement`	422.0KB	4.3KB	-417.7KB

Unknown metric groups

API count

id	before	after	diff
`workflowsManagement`	20	18	-2

async chunk count

id	before	after	diff
`workflowsManagement`	1	3	+2

History

💔 Build #325869 failed 647d70e
💚 Build #323348 succeeded d2de34f
💔 Build #323186 failed 8750885
💔 Build #322853 failed 3cc8ba9
💔 Build #322816 failed 6c76169

## Summary ### Before 422K workflowsManagement.plugin.js ### After 4.1K workflowsManagement.plugin.js ### Root cause 1. Direct export of the `WorkflowExecution` component added 336kb https://github.com/Kiryous/kibana/blob/main/src/platform/plugins/shared/workflows_management/public/index.ts#L18 2. import of `generateYamlSchemaFromConnectors` in common/index added another 82kb https://github.com/Kiryous/kibana/blob/5d05dd06aa40b75885cb5496f5af3ae825b1f773/src/platform/plugins/shared/workflows_management/common/index.ts#L10 Without these, the plugin bundle size is modest 4.1K ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ...

Kiryous added 3 commits July 24, 2025 16:00

fix: move hardcoded schema from common index to a separate file to av…

84320a4

…oid inclusion into bundle

fix: lazy export of WorkflowExecution

b6fb5fe

fix: update limits.yml for workflowsManagement

6c76169

Kiryous added backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes labels Jul 24, 2025

Kiryous marked this pull request as ready for review July 24, 2025 12:15

Kiryous requested review from a team as code owners July 24, 2025 12:15

talboren approved these changes Jul 24, 2025

View reviewed changes

Kiryous added 2 commits July 24, 2025 17:06

fix: lazy import of visual and yaml editors

dccb388

fix: types

3cc8ba9

jbudz approved these changes Jul 24, 2025

View reviewed changes

Kiryous and others added 3 commits July 25, 2025 12:14

fix: add missing WorkflowExecutionProps export

4c3fcf8

Merge branch 'main' into fix/13318-workflows-management-plugin-bundle

8750885

Merge branch 'main' into fix/13318-workflows-management-plugin-bundle

d2de34f

tinnytintin10 added the Team:One Workflow Team label for One Workflow (Workflow automation) label Jul 29, 2025

Kiryous requested a review from a team as a code owner August 4, 2025 08:04

fix: revert `x-pack/solutions/observability/plugins/infra/public/aler…

647d70e

…ting/log_threshold/components/expression_editor/criterion.tsx` eslint autofix

Kiryous removed the request for review from a team August 4, 2025 08:09

Kiryous added 2 commits August 4, 2025 12:57

fix: types

89e1015

fix: do not include graph utils in common

56c7465

Kiryous merged commit ff36057 into elastic:main Aug 4, 2025
12 checks passed

kibanamachine added the v9.2.0 label Aug 4, 2025

wildemat mentioned this pull request Aug 7, 2025

pr 230826 #231022

Closed

10 tasks

Kiryous deleted the fix/13318-workflows-management-plugin-bundle branch August 11, 2025 09:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: workflows management plugin bundle size #229309

fix: workflows management plugin bundle size #229309

Uh oh!

Kiryous commented Jul 24, 2025 •

edited

Loading

Uh oh!

talboren left a comment

Uh oh!

elasticmachine commented Aug 4, 2025

API count

async chunk count

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

fix: workflows management plugin bundle size #229309

fix: workflows management plugin bundle size #229309

Uh oh!

Conversation

Kiryous commented Jul 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Before

After

Root cause

Checklist

Identify risks

Uh oh!

talboren left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Aug 4, 2025

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Page load bundle

API count

async chunk count

History

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Kiryous commented Jul 24, 2025 •

edited

Loading