Upgrade puppeteer to v24.14.0 #229045
Merged
JiaweiWu merged 9 commits intoelastic:mainfrom Aug 21, 2025
Merged
Conversation
JiaweiWu
added
release_note:skip
Contributor
|
Pinging @elastic/response-ops (Team:ResponseOps) |
…urce-definitions/scripts/fix-location-collection.ts'
Contributor
|
I noticed some other packages got upgraded because of the puppeteer upgrade: In these cases, we need to make sure that these upgrades didn't break anything else. By making sure all the FT pass, or we know that the upgrade did not cause the failure. I'm guessing these upgrades are not the cause of the security FT failures, but let's make sure. |
Contributor
Author
|
Yea, it should be ok I tested it a few times, also the first CI run was successful, I'll rerun the tests |
Contributor
Author
|
/ci |
Contributor
|
I assume you tested locally, and on the cloud deploy. Did you also test on Windows? That's the hard one, unless you happen to have a Windows machine ... |
Contributor
Author
|
@pmuellr how were you able to test on windows when you upgraded puppeteer? just use your own machine? I could do that but I prefer not using my personal PC unless absolutely required. |
Contributor
|
I responded in Slack, just realized the Windows testing question was asked here as well. There are some instructions in our "big doc" of how to do these upgrades, near the bottom. I believe everyone has gone the "run Windows on a GCloud VM", so you will probably want to go that way. Testing on real hardware is fine as well, basically just want to make sure a PDF can be produced (actually runs the same code as PNG, but then converts the PNG to a PDF at the end). |
Contributor
Author
|
Validated windows: Validated linux: |
Contributor
⏳ Build in-progress
History
|
Contributor
|
Starting backport for target branches: 8.18, 8.19, 9.1 https://github.com/elastic/kibana/actions/runs/17136200590 |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 21, 2025
## Summary Resolves issue: elastic/response-ops-team#362 ### local testing: #### On kibana startup: <img width="737" height="76" alt="Screenshot 2025-07-22 at 7 48 52 PM" src="https://github.com/user-attachments/assets/211bcf43-1e14-412b-9f23-f2dcc9a0acad" /> --- <img width="950" height="351" alt="Screenshot 2025-07-22 at 7 51 05 PM" src="https://github.com/user-attachments/assets/23fcb782-fb1b-46cc-8831-bd4ad908a855" /> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 33b318a)
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 21, 2025
## Summary Resolves issue: elastic/response-ops-team#362 ### local testing: #### On kibana startup: <img width="737" height="76" alt="Screenshot 2025-07-22 at 7 48 52 PM" src="https://github.com/user-attachments/assets/211bcf43-1e14-412b-9f23-f2dcc9a0acad" /> --- <img width="950" height="351" alt="Screenshot 2025-07-22 at 7 51 05 PM" src="https://github.com/user-attachments/assets/23fcb782-fb1b-46cc-8831-bd4ad908a855" /> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 33b318a)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Aug 21, 2025
# Backport This will backport the following commits from `main` to `9.1`: - [Upgrade puppeteer to v24.14.0 (#229045)](#229045) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Jiawei Wu","email":"74562234+JiaweiWu@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-08-21T18:53:22Z","message":"Upgrade puppeteer to v24.14.0 (#229045)\n\n## Summary\nResolves issue: https://github.com/elastic/response-ops-team/issues/362\n\n### local testing:\n\n#### On kibana startup:\n<img width=\"737\" height=\"76\" alt=\"Screenshot 2025-07-22 at 7 48 52 PM\"\nsrc=\"https://github.com/user-attachments/assets/211bcf43-1e14-412b-9f23-f2dcc9a0acad\"\n/>\n\n---\n\n<img width=\"950\" height=\"351\" alt=\"Screenshot 2025-07-22 at 7 51 05 PM\"\nsrc=\"https://github.com/user-attachments/assets/23fcb782-fb1b-46cc-8831-bd4ad908a855\"\n/>\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"33b318ad14130c8909899f2535444c8c4c7a82a9","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","ci:cloud-deploy","backport:version","v9.1.0","v8.18.2","v8.18.3","v9.2.0","v8.18.4","v9.1.1","v8.18.5","v8.19.1"],"title":"Upgrade puppeteer to v24.14.0 ","number":229045,"url":"https://github.com/elastic/kibana/pull/229045","mergeCommit":{"message":"Upgrade puppeteer to v24.14.0 (#229045)\n\n## Summary\nResolves issue: https://github.com/elastic/response-ops-team/issues/362\n\n### local testing:\n\n#### On kibana startup:\n<img width=\"737\" height=\"76\" alt=\"Screenshot 2025-07-22 at 7 48 52 PM\"\nsrc=\"https://github.com/user-attachments/assets/211bcf43-1e14-412b-9f23-f2dcc9a0acad\"\n/>\n\n---\n\n<img width=\"950\" height=\"351\" alt=\"Screenshot 2025-07-22 at 7 51 05 PM\"\nsrc=\"https://github.com/user-attachments/assets/23fcb782-fb1b-46cc-8831-bd4ad908a855\"\n/>\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"33b318ad14130c8909899f2535444c8c4c7a82a9"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.18","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/229045","number":229045,"mergeCommit":{"message":"Upgrade puppeteer to v24.14.0 (#229045)\n\n## Summary\nResolves issue: https://github.com/elastic/response-ops-team/issues/362\n\n### local testing:\n\n#### On kibana startup:\n<img width=\"737\" height=\"76\" alt=\"Screenshot 2025-07-22 at 7 48 52 PM\"\nsrc=\"https://github.com/user-attachments/assets/211bcf43-1e14-412b-9f23-f2dcc9a0acad\"\n/>\n\n---\n\n<img width=\"950\" height=\"351\" alt=\"Screenshot 2025-07-22 at 7 51 05 PM\"\nsrc=\"https://github.com/user-attachments/assets/23fcb782-fb1b-46cc-8831-bd4ad908a855\"\n/>\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"33b318ad14130c8909899f2535444c8c4c7a82a9"}},{"branch":"8.19","label":"v8.19.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Jiawei Wu <74562234+JiaweiWu@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Aug 21, 2025
# Backport This will backport the following commits from `main` to `8.19`: - [Upgrade puppeteer to v24.14.0 (#229045)](#229045) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Jiawei Wu","email":"74562234+JiaweiWu@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-08-21T18:53:22Z","message":"Upgrade puppeteer to v24.14.0 (#229045)\n\n## Summary\nResolves issue: https://github.com/elastic/response-ops-team/issues/362\n\n### local testing:\n\n#### On kibana startup:\n<img width=\"737\" height=\"76\" alt=\"Screenshot 2025-07-22 at 7 48 52 PM\"\nsrc=\"https://github.com/user-attachments/assets/211bcf43-1e14-412b-9f23-f2dcc9a0acad\"\n/>\n\n---\n\n<img width=\"950\" height=\"351\" alt=\"Screenshot 2025-07-22 at 7 51 05 PM\"\nsrc=\"https://github.com/user-attachments/assets/23fcb782-fb1b-46cc-8831-bd4ad908a855\"\n/>\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"33b318ad14130c8909899f2535444c8c4c7a82a9","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","ci:cloud-deploy","backport:version","v9.1.0","v8.18.2","v8.18.3","v9.2.0","v8.18.4","v9.1.1","v8.18.5","v8.19.1"],"title":"Upgrade puppeteer to v24.14.0 ","number":229045,"url":"https://github.com/elastic/kibana/pull/229045","mergeCommit":{"message":"Upgrade puppeteer to v24.14.0 (#229045)\n\n## Summary\nResolves issue: https://github.com/elastic/response-ops-team/issues/362\n\n### local testing:\n\n#### On kibana startup:\n<img width=\"737\" height=\"76\" alt=\"Screenshot 2025-07-22 at 7 48 52 PM\"\nsrc=\"https://github.com/user-attachments/assets/211bcf43-1e14-412b-9f23-f2dcc9a0acad\"\n/>\n\n---\n\n<img width=\"950\" height=\"351\" alt=\"Screenshot 2025-07-22 at 7 51 05 PM\"\nsrc=\"https://github.com/user-attachments/assets/23fcb782-fb1b-46cc-8831-bd4ad908a855\"\n/>\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"33b318ad14130c8909899f2535444c8c4c7a82a9"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.18","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/229045","number":229045,"mergeCommit":{"message":"Upgrade puppeteer to v24.14.0 (#229045)\n\n## Summary\nResolves issue: https://github.com/elastic/response-ops-team/issues/362\n\n### local testing:\n\n#### On kibana startup:\n<img width=\"737\" height=\"76\" alt=\"Screenshot 2025-07-22 at 7 48 52 PM\"\nsrc=\"https://github.com/user-attachments/assets/211bcf43-1e14-412b-9f23-f2dcc9a0acad\"\n/>\n\n---\n\n<img width=\"950\" height=\"351\" alt=\"Screenshot 2025-07-22 at 7 51 05 PM\"\nsrc=\"https://github.com/user-attachments/assets/23fcb782-fb1b-46cc-8831-bd4ad908a855\"\n/>\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"33b318ad14130c8909899f2535444c8c4c7a82a9"}},{"branch":"8.19","label":"v8.19.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Jiawei Wu <74562234+JiaweiWu@users.noreply.github.com>
qn895
pushed a commit
to qn895/kibana
that referenced
this pull request
Aug 26, 2025
## Summary Resolves issue: elastic/response-ops-team#362 ### local testing: #### On kibana startup: <img width="737" height="76" alt="Screenshot 2025-07-22 at 7 48 52 PM" src="https://github.com/user-attachments/assets/211bcf43-1e14-412b-9f23-f2dcc9a0acad" /> --- <img width="950" height="351" alt="Screenshot 2025-07-22 at 7 51 05 PM" src="https://github.com/user-attachments/assets/23fcb782-fb1b-46cc-8831-bd4ad908a855" /> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
1 task
KodeRad
pushed a commit
to KodeRad/kibana
that referenced
this pull request
Aug 28, 2025
## Summary Resolves issue: elastic/response-ops-team#362 ### local testing: #### On kibana startup: <img width="737" height="76" alt="Screenshot 2025-07-22 at 7 48 52 PM" src="https://github.com/user-attachments/assets/211bcf43-1e14-412b-9f23-f2dcc9a0acad" /> --- <img width="950" height="351" alt="Screenshot 2025-07-22 at 7 51 05 PM" src="https://github.com/user-attachments/assets/23fcb782-fb1b-46cc-8831-bd4ad908a855" /> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This was referenced Aug 28, 2025
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves issue: https://github.com/elastic/response-ops-team/issues/362
local testing:
On kibana startup: