Skip to content

[Console] Fix different error code in status badge#228889

Merged
sabarasaba merged 3 commits intoelastic:mainfrom
sabarasaba:console-fix_different_error_code_in_status
Jul 22, 2025
Merged

[Console] Fix different error code in status badge#228889
sabarasaba merged 3 commits intoelastic:mainfrom
sabarasaba:console-fix_different_error_code_in_status

Conversation

@sabarasaba
Copy link
Member

@sabarasaba sabarasaba commented Jul 22, 2025

Fix #219257

Summary

Resolves an issue where Console showed different status codes in the response badge vs response body when sending requests with invalid HTTP methods.

@sabarasaba sabarasaba self-assigned this Jul 22, 2025
@sabarasaba sabarasaba added Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// release_note:skip Skip the PR/issue when compiling release notes backport:prev-major v9.2.0 labels Jul 22, 2025
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
console 193.9KB 194.0KB +140.0B

History

cc @sabarasaba

@sabarasaba sabarasaba marked this pull request as ready for review July 22, 2025 10:23
@sabarasaba sabarasaba requested a review from a team as a code owner July 22, 2025 10:23
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

Copy link
Contributor

@SoniaSanzV SoniaSanzV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally, lgtm

@sabarasaba sabarasaba merged commit f157896 into elastic:main Jul 22, 2025
13 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.17, 8.18, 8.19

https://github.com/elastic/kibana/actions/runs/16444646235

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 22, 2025
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 22, 2025
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
8.17 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.17:
- Relocked form-data to 4.0.4 (#228770)
- [Lens] Fix Firefox inline editor scroll (#228625)
- [Synthetics] Fix escape vars template literal inline script !! (#228696)
8.18
8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 228889

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 22, 2025
…228960)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[Console] Fix different error code in status badge
(#228889)](#228889)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Ignacio
Rivas","email":"rivasign@gmail.com"},"sourceCommit":{"committedDate":"2025-07-22T12:43:30Z","message":"[Console]
Fix different error code in status badge
(#228889)","sha":"f15789615961e8cf3f6302702db1620c2ec3c4e6","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Console","Team:Kibana
Management","release_note:skip","backport:prev-major","v9.2.0"],"title":"[Console]
Fix different error code in status
badge","number":228889,"url":"https://github.com/elastic/kibana/pull/228889","mergeCommit":{"message":"[Console]
Fix different error code in status badge
(#228889)","sha":"f15789615961e8cf3f6302702db1620c2ec3c4e6"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/228889","number":228889,"mergeCommit":{"message":"[Console]
Fix different error code in status badge
(#228889)","sha":"f15789615961e8cf3f6302702db1620c2ec3c4e6"}}]}]
BACKPORT-->

Co-authored-by: Ignacio Rivas <rivasign@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
tiansivive pushed a commit to tiansivive/kibana that referenced this pull request Jul 22, 2025
kibanamachine added a commit that referenced this pull request Jul 23, 2025
…228959)

# Backport

This will backport the following commits from `main` to `8.18`:
- [[Console] Fix different error code in status badge
(#228889)](#228889)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Ignacio
Rivas","email":"rivasign@gmail.com"},"sourceCommit":{"committedDate":"2025-07-22T12:43:30Z","message":"[Console]
Fix different error code in status badge
(#228889)","sha":"f15789615961e8cf3f6302702db1620c2ec3c4e6","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Console","Team:Kibana
Management","release_note:skip","backport:prev-major","v9.2.0"],"title":"[Console]
Fix different error code in status
badge","number":228889,"url":"https://github.com/elastic/kibana/pull/228889","mergeCommit":{"message":"[Console]
Fix different error code in status badge
(#228889)","sha":"f15789615961e8cf3f6302702db1620c2ec3c4e6"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/228889","number":228889,"mergeCommit":{"message":"[Console]
Fix different error code in status badge
(#228889)","sha":"f15789615961e8cf3f6302702db1620c2ec3c4e6"}}]}]
BACKPORT-->

Co-authored-by: Ignacio Rivas <rivasign@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
kdelemme pushed a commit to kdelemme/kibana that referenced this pull request Jul 23, 2025
kertal pushed a commit to kertal/kibana that referenced this pull request Jul 25, 2025
crespocarlos pushed a commit to crespocarlos/kibana that referenced this pull request Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Console Dev Tools Console Feature release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v8.18.5 v8.19.0 v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Console] Status code in badge is different from status code in response

4 participants