Skip to content

[8.17] [Lens] Fix Firefox inline editor scroll (#228625) #228851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickofthyme merged 4 commits into from
Jul 24, 2025
Merged

[8.17] [Lens] Fix Firefox inline editor scroll (#228625) #228851

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
db72043
[Lens] Fix Firefox inline editor scroll (#228625)
nickofthyme Jul 21, 2025
a41b56c
Merge branch '8.17' into backport/8.17/pr-228625
nickofthyme Jul 23, 2025
c0cade7
chore: whoops fixed wrong file
nickofthyme Jul 23, 2025
56279a5
Merge branch '8.17' into backport/8.17/pr-228625
nickofthyme Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x-pack/plugins/lens/public/app_plugin/shared/edit_on_the_fly/get_edit_lens_configuration.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ export async function getEditLensConfiguration(
size="s"
hideCloseButton
css={css`
clip-path: polygon(-100% 0, 100% 0, 100% 100%, -100% 100%);
clip-path: none; // need to override the eui-flyout clip-path for dnd outside of the flyout
`}
>
{children}
Expand Down
8 changes: 3 additions & 5 deletions x-pack/plugins/lens/public/trigger_actions/open_lens_config/helpers.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
// styles needed to display extra drop targets that are outside of the config panel main area while also allowing to scroll vertically
.lnsConfigPanel__overlay {
clip-path: polygon(-100% 0, 100% 0, 100% 100%, -100% 100%);
clip-path:none; // need to override the eui-flyout clip-path
max-inline-size: $euiSizeXXL * 20;
min-inline-size: $euiSizeXXL * 8;
background: $euiColorLightestShade;
@include euiBreakpoint('xs', 's', 'm') {
clip-path: none;
}

.kbnOverlayMountWrapper {
padding-left: $euiFormMaxWidth;
margin-left: -$euiFormMaxWidth;
Expand All @@ -21,4 +19,4 @@
.euiFlyoutBody__overflow {
transform: initial;
}
}
}