[scout] support log level override by dmlemeshko · Pull Request #228841 · elastic/kibana

dmlemeshko · 2025-07-21T17:40:39Z

Summary

default log level for Playwright fixtures is info , afaik default for FTR and other scripts (but for now to better understand performance issues we pass debug through node scripts/scout, to be reverted for GA)
node scripts/scout will propagate log level from cli flag (e.g. --debug) with SCOUT_LOG_LEVEL env variable to playwright exec command
since some Team may not use scripts/scout command, they can set LOG_LEVEL variable to override to whatever level is needed
if both LOG_LEVEL and SCOUT_LOG_LEVEL are set, the later has priority (important for us, shouldn't block others)

Playwright Integration:

Replaced the use of getLogger with the updated ScoutLogger call in Playwright worker fixtures, enabling log level configuration via environment variables.
Modified the Playwright test runner to propagate the log level to the test environment using the SCOUT_LOG_LEVEL variable.

…not for Kibana/ES

dmlemeshko · 2025-07-22T10:05:26Z

src/platform/packages/shared/kbn-scout/src/playwright/global_hooks/synthtrace_ingestion.ts

 export async function ingestSynthtraceDataHook(config: FullConfig, data: SynthtraceIngestionData) {
-  const log = getLogger();
+  const log = new ScoutLogger('scout: global hook', getScoutLogLevel());


These functions are for parallel test run, that requires data ingestion to be done in advance.

dgieselaar · 2025-07-22T10:45:14Z

src/platform/packages/shared/kbn-scout/src/common/services/logger.ts

-export function getLogger(workerContext: string = 'scout'): ScoutLogger {
-  if (!loggerInstances.has(workerContext)) {
-    loggerInstances.set(workerContext, new ScoutLogger(workerContext));
+function resolveLogLevel(envValue: string | undefined): LogLevel | undefined {


any chance we can move (the bulk of) this into new ToolingLog()?

we'd end up with something like new ScoutLogger(loggerContext, process.env.SCOUT_PW_LOG_LEVEL) and then in the ToolingLog constructor we default to { level: process.env.LOG_LEVEL || 'info' } ?

changed in 072146f , I added comment about priority and changed variable name to SCOUT_LOG_LEVEL because it has zero connection with the playwright internal logging (only our custom fixtures/hooks call it). cc @dolaru @dgieselaar

src/platform/packages/shared/kbn-scout/src/common/services/logger.ts

dolaru

LGTM 👍🏽

Just one nit in one of the code comments.

src/platform/packages/shared/kbn-scout/src/playwright/fixtures/worker/core_fixtures.ts

…/worker/core_fixtures.ts Co-authored-by: David Olaru <dolaru@vaevixen.com>

elasticmachine · 2025-07-22T16:45:11Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 2c62ec3

Failed CI Steps

FTR Configs #87

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/scout`	125	123	-2
`@kbn/scout-oblt`	76	74	-2
`@kbn/scout-security`	67	65	-2
total			-6

Unknown metric groups

API count

id	before	after	diff
`@kbn/scout`	450	451	+1
`@kbn/scout-oblt`	370	371	+1
`@kbn/scout-security`	360	361	+1
total			+3

History

cc @dmlemeshko

dgieselaar · 2025-07-22T17:09:54Z

src/platform/packages/shared/kbn-scout/src/playwright/runner/run_tests.ts

+  });
+  // Temporarily use `debug` log level for Playwright tests to better understand performance issues;
+  // We are going to change it to `info` in the future. This change doesn't affect Test Servers logging.
+  const logsLevel = pickLevelFromFlags(globalFlags, { default: 'debug' });


does this need to default to debug? for whom are these debug logs useful atm?

Mostly for appex-qa to evaluate parallel testing with Kibana spaces and spot some slow API calls. If we see a repetitive API calls taking 10 seconds to setup env, we usually ask to consider improvement. The end goal is not only move to playwright, but finally start writing stable, fast and reliable tests.

mistic

After the fact we might want to summarise our logging ideas we discussed async so this can become a standard in the codebase. LGTM

kibanamachine · 2025-07-22T20:26:12Z

Starting backport for target branches: 8.19, 9.1

https://github.com/elastic/kibana/actions/runs/16454773113

kibanamachine · 2025-07-22T20:32:38Z

💔 All backports failed

Status	Branch	Result
❌	8.19	Backport failed because of merge conflicts
❌	9.1	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 228841

Questions ?

Please refer to the Backport tool documentation

kibanamachine · 2025-07-24T20:48:56Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 228841 locally
cc: @dmlemeshko

## Summary - default log level for Playwright fixtures is `info` , afaik default for FTR and other scripts (but for now to better understand performance issues we pass `debug` through `node scripts/scout`, to be reverted for GA) - `node scripts/scout` will propagate log level from cli flag (e.g. --debug) with `SCOUT_LOG_LEVEL` env variable to playwright exec command - since some Team may not use `scripts/scout` command, they can set `LOG_LEVEL` variable to override to whatever level is needed if both `LOG_LEVEL` and `SCOUT_LOG_LEVEL` are set, the later has priority (important for us, shouldn't block others) ### Playwright Integration: * Replaced the use of `getLogger` with the updated `ScoutLogger` call in Playwright worker fixtures, enabling log level configuration via environment variables. * Modified the Playwright test runner to propagate the log level to the test environment using the `SCOUT_LOG_LEVEL` variable. --------- Co-authored-by: David Olaru <dolaru@vaevixen.com>

kibanamachine · 2025-07-25T20:49:35Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 228841 locally
cc: @dmlemeshko

## Summary - default log level for Playwright fixtures is `info` , afaik default for FTR and other scripts (but for now to better understand performance issues we pass `debug` through `node scripts/scout`, to be reverted for GA) - `node scripts/scout` will propagate log level from cli flag (e.g. --debug) with `SCOUT_LOG_LEVEL` env variable to playwright exec command - since some Team may not use `scripts/scout` command, they can set `LOG_LEVEL` variable to override to whatever level is needed if both `LOG_LEVEL` and `SCOUT_LOG_LEVEL` are set, the later has priority (important for us, shouldn't block others) ### Playwright Integration: * Replaced the use of `getLogger` with the updated `ScoutLogger` call in Playwright worker fixtures, enabling log level configuration via environment variables. * Modified the Playwright test runner to propagate the log level to the test environment using the `SCOUT_LOG_LEVEL` variable. --------- Co-authored-by: David Olaru <dolaru@vaevixen.com> (cherry picked from commit d76a5be) # Conflicts: # src/platform/packages/shared/kbn-scout/src/playwright/global_hooks/synthtrace_ingestion.ts

dmlemeshko · 2025-07-28T07:30:04Z

💚 All backports created successfully

Status	Branch	Result
✅	9.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

# Backport This will backport the following commits from `main` to `9.1`: - [[scout] support log level override (#228841)](#228841)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)

## Summary - default log level for Playwright fixtures is `info` , afaik default for FTR and other scripts (but for now to better understand performance issues we pass `debug` through `node scripts/scout`, to be reverted for GA) - `node scripts/scout` will propagate log level from cli flag (e.g. --debug) with `SCOUT_LOG_LEVEL` env variable to playwright exec command - since some Team may not use `scripts/scout` command, they can set `LOG_LEVEL` variable to override to whatever level is needed if both `LOG_LEVEL` and `SCOUT_LOG_LEVEL` are set, the later has priority (important for us, shouldn't block others) ### Playwright Integration: * Replaced the use of `getLogger` with the updated `ScoutLogger` call in Playwright worker fixtures, enabling log level configuration via environment variables. * Modified the Playwright test runner to propagate the log level to the test environment using the `SCOUT_LOG_LEVEL` variable. --------- Co-authored-by: David Olaru <dolaru@vaevixen.com> (cherry picked from commit d76a5be) # Conflicts: # src/platform/packages/shared/kbn-scout/src/playwright/global_hooks/synthtrace_ingestion.ts

dmlemeshko · 2025-08-04T10:11:35Z

💚 All backports created successfully

Status	Branch	Result
✅	8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

# Backport This will backport the following commits from `main` to `8.19`: - [[scout] support log level override (#228841)](#228841)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)

dmlemeshko · 2025-10-16T07:37:53Z

💚 All backports created successfully

Status	Branch	Result
✅	9.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

## Summary - default log level for Playwright fixtures is `info` , afaik default for FTR and other scripts (but for now to better understand performance issues we pass `debug` through `node scripts/scout`, to be reverted for GA) - `node scripts/scout` will propagate log level from cli flag (e.g. --debug) with `SCOUT_LOG_LEVEL` env variable to playwright exec command - since some Team may not use `scripts/scout` command, they can set `LOG_LEVEL` variable to override to whatever level is needed if both `LOG_LEVEL` and `SCOUT_LOG_LEVEL` are set, the later has priority (important for us, shouldn't block others) ### Playwright Integration: * Replaced the use of `getLogger` with the updated `ScoutLogger` call in Playwright worker fixtures, enabling log level configuration via environment variables. * Modified the Playwright test runner to propagate the log level to the test environment using the `SCOUT_LOG_LEVEL` variable. --------- Co-authored-by: David Olaru <dolaru@vaevixen.com> (cherry picked from commit d76a5be) # Conflicts: # src/platform/packages/shared/kbn-scout/src/playwright/global_hooks/synthtrace_ingestion.ts

[scout] support log level override

fb6a413

dmlemeshko added the ci:scout-ui-tests Run Scout UI tests label Jul 21, 2025

dmlemeshko added 3 commits July 22, 2025 11:23

support LOG_LEVEL ...

a1d8b1e

temp pass 'debug' to Scout playwright call to see extended logs, but …

5cba5e6

…not for Kibana/ES

update logger call

0fd5423

dmlemeshko requested review from dgieselaar, dolaru and pheyos July 22, 2025 10:02

Merge branch 'main' into scout/support-logger-level-override

3588e26

dmlemeshko marked this pull request as ready for review July 22, 2025 10:02

dmlemeshko requested a review from a team as a code owner July 22, 2025 10:02

dmlemeshko added v9.1.0 v8.19.0 v9.2.0 release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels labels Jul 22, 2025

dmlemeshko commented Jul 22, 2025

View reviewed changes

dgieselaar reviewed Jul 22, 2025

View reviewed changes

dolaru reviewed Jul 22, 2025

View reviewed changes

src/platform/packages/shared/kbn-scout/src/common/services/logger.ts Outdated Show resolved Hide resolved

dmlemeshko added 2 commits July 22, 2025 14:21

refactor ScoutLogger constructor

072146f

Merge branch 'main' into scout/support-logger-level-override

deb7f34

dmlemeshko requested review from dgieselaar and dolaru July 22, 2025 12:38

dolaru approved these changes Jul 22, 2025

View reviewed changes

src/platform/packages/shared/kbn-scout/src/playwright/fixtures/worker/core_fixtures.ts Outdated Show resolved Hide resolved

Update src/platform/packages/shared/kbn-scout/src/playwright/fixtures…

c1c777a

…/worker/core_fixtures.ts Co-authored-by: David Olaru <dolaru@vaevixen.com>

dmlemeshko self-assigned this Jul 22, 2025

Merge branch 'main' into scout/support-logger-level-override

2c62ec3

dgieselaar reviewed Jul 22, 2025

View reviewed changes

dgieselaar approved these changes Jul 22, 2025

View reviewed changes

mistic approved these changes Jul 22, 2025

View reviewed changes

dmlemeshko merged commit d76a5be into elastic:main Jul 22, 2025
13 checks passed

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 24, 2025

dmlemeshko mentioned this pull request Jul 28, 2025

[9.1] [scout] support log level override (#228841) #229557

Merged

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 28, 2025

mistic added v9.1.1 and removed v9.1.0 labels Jul 29, 2025

kibanamachine mentioned this pull request Jul 31, 2025

[Scout] Capture test run target, mode and parallel info #229846

Merged

dmlemeshko mentioned this pull request Aug 4, 2025

[8.19] [scout] support log level override (#228841) #230381

Merged

kibanamachine added the v8.19.1 label Aug 4, 2025

dmlemeshko mentioned this pull request Oct 16, 2025

[9.0] [scout] support log level override (#228841) #239267

Closed

dmlemeshko added the v9.0.9 label Oct 16, 2025

Conversation

dmlemeshko commented Jul 21, 2025 • edited by kibanamachine Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Playwright Integration:

Uh oh!

dmlemeshko Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dgieselaar Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

dgieselaar Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

dmlemeshko Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dolaru left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

elasticmachine commented Jul 22, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Public APIs missing comments

API count

History

Uh oh!

dgieselaar Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

dmlemeshko Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

mistic left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kibanamachine commented Jul 22, 2025

Uh oh!

kibanamachine commented Jul 22, 2025

💔 All backports failed

Manual backport

Questions ?

Uh oh!

kibanamachine commented Jul 24, 2025

Uh oh!

kibanamachine commented Jul 25, 2025

Uh oh!

dmlemeshko commented Jul 28, 2025

💚 All backports created successfully

Questions ?

Uh oh!

dmlemeshko commented Aug 4, 2025

💚 All backports created successfully

Questions ?

Uh oh!

dmlemeshko commented Oct 16, 2025

💚 All backports created successfully

Questions ?

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

dmlemeshko commented Jul 21, 2025 •

edited by kibanamachine

Loading

dmlemeshko Jul 22, 2025 •

edited

Loading

dmlemeshko Jul 22, 2025 •

edited

Loading