Skip to content

[Index Management] Hide Edit data retention bulk action for ILM managed data streams #228802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
damian-polewski merged 1 commit into from
Jul 22, 2025
Merged

[Index Management] Hide Edit data retention bulk action for ILM managed data streams #228802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions ...plugins/shared/index_management/__jest__/client_integration/home/data_streams_tab.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -969,6 +969,28 @@ describe('Data Streams tab', () => {
expect(exists('editDataRetentionButton')).toBe(false);
});

test('displays/hides bulk edit data retention depending if data stream fully managed by ILM is selected', async () => {
const {
find,
actions: { selectDataStream, clickManageDataStreamsButton },
} = testBed;

// Select data stream fully managed by ILM
selectDataStream('dataStream1', true);
clickManageDataStreamsButton();
expect(find('bulkEditDataRetentionButton').exists()).toBeFalsy();

// Select data stream managed by DSL
selectDataStream('dataStream2', true);
clickManageDataStreamsButton();
expect(find('bulkEditDataRetentionButton').exists()).toBeFalsy();

// Unselect data stream fully managed by ILM
selectDataStream('dataStream1', false);
clickManageDataStreamsButton();
expect(find('bulkEditDataRetentionButton').exists()).toBeTruthy();
});

test('when partially managed by dsl but has backing indices managed by ILM should show a warning', async () => {
const { setLoadDataStreamResponse } = httpRequestsMockHelpers;

Expand Down
6 changes: 5 additions & 1 deletion ...public/application/sections/home/data_stream_list/data_stream_table/data_stream_table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,11 @@ export const DataStreamTable: React.FunctionComponent<Props> = ({
const dataStreamActions: EuiContextMenuPanelItemDescriptor[] = [];

if (
selection.every((dataStream: DataStream) => dataStream.privileges.manage_data_stream_lifecycle)
selection.every(
(dataStream: DataStream) =>
dataStream.privileges.manage_data_stream_lifecycle &&
!isDataStreamFullyManagedByILM(dataStream)
)
) {
dataStreamActions.push({
name: i18n.translate('xpack.idxMgmt.dataStreamList.table.bulkEditDataRetentionButtonLabel', {
Expand Down