Skip to content

[ILM] Remove immer dependency#228727

Merged
sabarasaba merged 4 commits intoelastic:mainfrom
sabarasaba:ilm-remove_immer_dependency
Jul 22, 2025
Merged

[ILM] Remove immer dependency#228727
sabarasaba merged 4 commits intoelastic:mainfrom
sabarasaba:ilm-remove_immer_dependency

Conversation

@sabarasaba
Copy link
Copy Markdown
Member

@sabarasaba sabarasaba commented Jul 21, 2025

Partially addresses #208213

Summary

This PR removes the plugins dependency on immer's produce function from the policy serialization and deserialization logic. The produce calls have been replaced with lodash's cloneDeep function (already imported) followed by direct object mutations. This maintains the exact same functionality while avoiding the extra dependency.

@sabarasaba sabarasaba self-assigned this Jul 21, 2025
@sabarasaba sabarasaba added Feature:ILM Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels v9.2.0 labels Jul 21, 2025
@sabarasaba sabarasaba marked this pull request as ready for review July 21, 2025 10:46
@sabarasaba sabarasaba requested a review from a team as a code owner July 21, 2025 10:46
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 21, 2025

Pinging @elastic/kibana-management (Team:Kibana Management)

SoniaSanzV
SoniaSanzV approved these changes Jul 21, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@SoniaSanzV SoniaSanzV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, lgtm :)

@sabarasaba
Copy link
Copy Markdown
Member Author

sabarasaba commented Jul 22, 2025

@elasticmachine run docs-build

@sabarasaba
Copy link
Copy Markdown
Member Author

sabarasaba commented Jul 22, 2025

@elasticmachine merge upstream

@sabarasaba sabarasaba enabled auto-merge (squash) July 22, 2025 04:45
@sabarasaba sabarasaba merged commit 7575bee into elastic:main Jul 22, 2025
13 checks passed
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 22, 2025

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
indexLifecycleManagement 161.9KB 161.9KB -9.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
indexLifecycleManagement 26.5KB 26.5KB -57.0B

History

cc @sabarasaba

Bluefinger pushed a commit to Bluefinger/kibana that referenced this pull request Jul 22, 2025
@sabarasaba @Bluefinger
[ILM] Remove immer dependency (elastic#228727)
198e9d8
maxcold pushed a commit that referenced this pull request Jul 22, 2025
@sabarasaba @maxcold
[ILM] Remove immer dependency (#228727)
244ce6b
kdelemme pushed a commit to kdelemme/kibana that referenced this pull request Jul 23, 2025
@sabarasaba @kdelemme
[ILM] Remove immer dependency (elastic#228727)
e2dabf8
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 24, 2025
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jul 24, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 228727 locally
cc: @sabarasaba

1 similar comment
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jul 25, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 228727 locally
cc: @sabarasaba

kertal pushed a commit to kertal/kibana that referenced this pull request Jul 25, 2025
@sabarasaba @kertal
[ILM] Remove immer dependency (elastic#228727)
32290ef
crespocarlos pushed a commit to crespocarlos/kibana that referenced this pull request Jul 25, 2025
@sabarasaba @crespocarlos
[ILM] Remove immer dependency (elastic#228727)
d754f70
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jul 28, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 228727 locally
cc: @sabarasaba

@sabarasaba sabarasaba removed backport missing Added to PRs automatically when the are determined to be missing a backport. backport:version Backport to applied version labels labels Jul 28, 2025
@sabarasaba sabarasaba added the backport:skip This PR does not require backporting label Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SoniaSanzV SoniaSanzV SoniaSanzV approved these changes

Assignees

@sabarasaba sabarasaba

Labels

backport:skip This PR does not require backporting Feature:ILM release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v9.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sabarasaba @elasticmachine @kibanamachine @SoniaSanzV