[Ingest Pipelines] Fix empty string bug

[sabarasaba]

Fix: #219184

Summary

This PR fixes a bug in which if a given processor has an empty string value it will get removed before submitting causing errors with the API.

In order to test, create the following pipeline through console and make sure that cloning it or editing it allows you to save it.

PUT _ingest/pipeline/test
{
  "processors": [
    {
      "set": {
        "field": "source.address",
        "value": "",
        "if": "ctx.source?.address == null"
      }
    }
  ]
}

[elasticmachine]

Pinging @elastic/kibana-management (Team:Kibana Management)

[sabarasaba]

/ci

[SoniaSanzV]

tested locally, works well.

I wonder if we should allow in the UI that the value is empty. With the changes you have made it is possible to open the pipeline and clone the processor, which fixes the bug. But if I want to edit the processor, it requires that the value is not empty (which makes our UI useless in this case because that processor will have to be edited with the console). It doesn't have to be fixed here, we can open an issue to do it in the future.

Another question: why not backporting this change?

[sabarasaba]

Thanks for having a look!

I wonder if we should allow in the UI that the value is empty. With the changes you have made it is possible to open the pipeline and clone the processor, which fixes the bug. But if I want to edit the processor, it requires that the value is not empty (which makes our UI useless in this case because that processor will have to be edited with the console). It doesn't have to be fixed here, we can open an issue to do it in the future.

Maybe! That would require a larger effort as if a textinput is empty, we assume its not set so we dont send it.. making it support empty spaces will complicate things slightly and might require a more specific solution applied at a larger level (all processors). I think for now to address these specific case in which can be generated through console is enough 🤔

[sabarasaba]

@elasticmachine merge upstream

[kibanamachine]

Starting backport for target branches: 8.17, 8.18, 8.19

https://github.com/elastic/kibana/actions/runs/16436352319

[elasticmachine]

💚 Build Succeeded

• Buildkite Build
• Commit: ec2ff52

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
ingestPipelines	361.5KB	361.5KB	+27.0B

History

• 💚 Build #321242 succeeded d9c4385

cc @sabarasaba

[kibanamachine]

💚 All backports created successfully

Status	Branch	Result
✅	8.17
✅	8.18
✅	8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation