[9.1] [ska] relocate fleet api integration tests (#227769)

.buildkite/ftr_platform_stateful_configs.yml

@@ -13,7 +13,7 @@ disabled:
   - x-pack/platform/test/functional_with_es_ssl/config.base.ts
   - x-pack/test/api_integration/config.ts
   - x-pack/platform/test/api_integration/config.ts
-  - x-pack/test/fleet_api_integration/config.base.ts
+  - x-pack/platform/test/fleet_api_integration/config.base.ts
   - x-pack/platform/test/functional_basic/apps/ml/config.base.ts
   - x-pack/platform/test/functional_basic/apps/transform/config.base.ts
   - x-pack/platform/test/api_integration_basic/config.basic_license.ts
@@ -164,12 +164,15 @@ enabled:
   - x-pack/platform/test/disable_ems/config.ts
   - x-pack/platform/test/examples/config.ts
   - x-pack/test/fleet_api_integration/config.agent.ts
-  - x-pack/test/fleet_api_integration/config.agent_policy.ts
   - x-pack/test/fleet_api_integration/config.epm.ts
-  - x-pack/test/fleet_api_integration/config.event_ingested.ts
-  - x-pack/test/fleet_api_integration/config.fleet.ts
   - x-pack/test/fleet_api_integration/config.package_policy.ts
-  - x-pack/test/fleet_api_integration/config.space_awareness.ts
+  - x-pack/platform/test/fleet_api_integration/config.agent.ts
+  - x-pack/platform/test/fleet_api_integration/config.agent_policy.ts
+  - x-pack/platform/test/fleet_api_integration/config.epm.ts
+  - x-pack/platform/test/fleet_api_integration/config.event_ingested.ts
+  - x-pack/platform/test/fleet_api_integration/config.fleet.ts
+  - x-pack/platform/test/fleet_api_integration/config.package_policy.ts
+  - x-pack/platform/test/fleet_api_integration/config.space_awareness.ts
   - x-pack/test/fleet_functional/config.ts
   - x-pack/platform/test/fleet_tasks/config.ts
   - x-pack/platform/test/ftr_apis/security_and_spaces/config.ts

.github/CODEOWNERS

@@ -1508,6 +1508,7 @@ x-pack/solutions/observability/plugins/observability/server/lib/esql_extensions
 /x-pack/test/functional/es_archives/fleet @elastic/fleet
 /x-pack/test/api_integration/services/fleet_and_agents.ts @elastic/fleet
 /x-pack/test/fleet_api_integration @elastic/fleet
+/x-pack/platform/test/fleet_api_integration @elastic/fleet
 /x-pack/platform/test/fleet_packages @elastic/fleet
 /x-pack/platform/test/fleet_tasks @elastic/fleet
 /src/platform/test/api_integration/apis/custom_integration/*.ts @elastic/fleet

.github/paths-labeller.yml

@@ -17,7 +17,7 @@
     - 'x-pack/solutions/observability/plugins/ux/**/*.*'
 - 'Team:Fleet':
     - 'x-pack/platform/plugins/shared/fleet/**/*.*'
-    - 'x-pack/test/fleet_api_integration/**/*.*'
+    - 'x-pack/platform/test/fleet_api_integration/**/*.*'
 - 'Team:obs-ux-management':
     - 'x-pack/solutions/observability/plugins/observability/**/*.*'
     - 'x-pack/solutions/observability/plugins/slo/**/*.*'

x-pack/platform/plugins/shared/fleet/README.md

@@ -26,9 +26,10 @@ Running a [self-managed stack](https://www.elastic.co/guide/en/fleet/current/add
 
 Refer to the [Contributing to Kibana](https://github.com/elastic/kibana/blob/main/CONTRIBUTING.md) documentation for getting started with developing for Kibana. As detailed under the Contributing section of the documentation, we follow the pattern of developing feature branches under your personal fork of Kibana.
 
-Fleet development usually requires running Kibana from source alongside a snapshot of Elasticsearch, as detailed in the  [Contributing to Kibana](https://github.com/elastic/kibana/blob/main/CONTRIBUTING.md) documentation. The next section provides an overview of this process.
+Fleet development usually requires running Kibana from source alongside a snapshot of Elasticsearch, as detailed in the [Contributing to Kibana](https://github.com/elastic/kibana/blob/main/CONTRIBUTING.md) documentation. The next section provides an overview of this process.
 
 In addition, it is typically needed to set up a Fleet Server and enroll Elastic Agents in Fleet. Refer to one of the following guides depending on your requirements for details:
+
 - [Running a local Fleet Server and enrolling Elastic Agents](dev_docs/local_setup/enrolling_agents.md) for developing Kibana in stateful (not serverless) mode
 - [Developing Kibana in serverless mode](dev_docs/local_setup/developing_kibana_in_serverless.md) for developing Kibana in serverless mode
 - [Developing Kibana and Fleet Server simultaneously](dev_docs/local_setup/developing_kibana_and_fleet_server.md) for doing simultaneous Kibana and Fleet Server development
@@ -37,10 +38,12 @@ In addition, it is typically needed to set up a Fleet Server and enroll Elastic
 ### Running Fleet locally in stateful mode
 
 Prerequisites:
+
 - Fork the Kibana repository and clone it locally
 - Install the `node` and `yarn` versions required by `.nvmrc`
 
 Once that is set up, the high level steps are:
+
 - Run Elasticsearch from snapshot
 - Configure Kibana settings
 - Run Kibana from source
@@ -52,13 +55,15 @@ Once that is set up, the high level steps are:
 As detailed in [Running Elasticsearch during development](https://www.elastic.co/guide/en/kibana/current/running-elasticsearch.html), there are different ways to run Elasticsearch when developing Kibana, with snapshot being the most common.
 
 To do this, run the following from the Kibana root folder:
+
 ```sh
 yarn es snapshot --license trial
 ```
 
 The `--license trial` flag provides the equivalent of a Platinum license (defaults to Basic).
 
 In addition, it can be useful to set a folder for preserving data between runs (by default, data is stored inside the snapshot and lost on exit) with the `-E path.data=<pathToSavedData>` setting. Common path choices are:
+
 - `../data` (or any other name, e.g. `../mycluster`), which saves the data in the `.es` folder (in the Kibana root folder)
 - `/tmp/es-data`
 
@@ -67,6 +72,7 @@ Note: the required API key service and token service (cf. [Security settings in
 Finally, setting up a Fleet Server requires setting the HTTP host to Fleet Server default host with `-E http.host=0.0.0.0`.
 
 The complete command usually looks like:
+
 ```sh
 yarn es snapshot --license trial -E path.data=../data -E http.host=0.0.0.0
 ```
@@ -78,17 +84,21 @@ Create a `config/kibana.dev.yml` file if you don't have one by copying the exist
 To get started, it is recommended to set the following settings:
 
 1\. The URL at which Kibana is available for end users: unless explicitly specified, this path is randomized in dev mode (refer to [Considerations for basepath](https://www.elastic.co/guide/en/kibana/current/development-basepath.html) for details). To set it, add the following to your `kibana.dev.yml`:
+
 ```yml
 server.basePath: /yourPath
 ```
+
 where `yourPath` is a path of your choice (e.g. your name; must not end with a slash).
 
 2\. The API version resolution: in dev mode, a version is required for all API requests. In other environements (e.g. production), the version falls back to `oldest` in stateful mode and `newest` in serverless mode for public APIs, while internal APIs always require a version. Set the API version resolution with:
+
 ```yml
 server.versioned.versionResolution: oldest
 ```
 
 3\. Fleet logging:
+
 ```yml
 logging:
   loggers:
@@ -140,6 +150,7 @@ yarn jest --config x-pack/platform/plugins/shared/fleet/jest.config.dev.js x-pac
 ```
 
 Or alternatively:
+
 ```sh
 yarn test:jest x-pack/platform/plugins/shared/fleet/common/services/validate_package_policy.test.ts
 ```
@@ -152,28 +163,29 @@ Note: Docker needs to be running to run these tests.
 
 1\. In one terminal, run the server from the Kibana root folder with
 
-   ```sh
-   FLEET_PACKAGE_REGISTRY_PORT=12345 yarn test:ftr:server --config x-pack/test/fleet_api_integration/<configFile>
-   ```
+```sh
+FLEET_PACKAGE_REGISTRY_PORT=12345 yarn test:ftr:server --config x-pack/platform/test/fleet_api_integration/<configFile>
+```
 
-   where `configFile` is the relevant config file relevant from the following:
-   - config.agent.ts
-   - config.agent_policy.ts
-   - config.epm.ts
-   - config.fleet.ts
-   - config.package_policy.ts
+where `configFile` is the relevant config file relevant from the following:
+
+- config.agent.ts
+- config.agent_policy.ts
+- config.epm.ts
+- config.fleet.ts
+- config.package_policy.ts
 
 2\. In a second terminal, run the tests from the Kibana root folder with
 
-   ```sh
-   FLEET_PACKAGE_REGISTRY_PORT=12345 yarn test:ftr:runner --config x-pack/test/fleet_api_integration/<configFile>
-   ```
+```sh
+FLEET_PACKAGE_REGISTRY_PORT=12345 yarn test:ftr:runner --config x-pack/platform/test/fleet_api_integration/<configFile>
+```
 
-   Optionally, you can filter which tests you want to run using `--grep`
+Optionally, you can filter which tests you want to run using `--grep`
 
-   ```sh
-   FLEET_PACKAGE_REGISTRY_PORT=12345 yarn test:ftr:runner --config x-pack/test/fleet_api_integration/<configFile> --grep='my filter string'
-   ```
+```sh
+FLEET_PACKAGE_REGISTRY_PORT=12345 yarn test:ftr:runner --config x-pack/platform/test/fleet_api_integration/<configFile> --grep='my filter string'
+```
 
 Note: you can supply which Docker image to use for the Package Registry via the `FLEET_PACKAGE_REGISTRY_DOCKER_IMAGE` env variable. For example,
 
@@ -192,12 +204,14 @@ FLEET_SKIP_RUNNING_PACKAGE_REGISTRY=true FLEET_PACKAGE_REGISTRY_PORT=12345 yarn
 The process for running serverless API integration tests is similar to above. Security and observability project types have Fleet enabled. At the time of writing, the same tests exist for Fleet under these two project types.
 
 Security:
+
 ```sh
 FLEET_PACKAGE_REGISTRY_PORT=12345 yarn test:ftr:server --config x-pack/test_serverless/api_integration/test_suites/security/fleet/config.ts
 FLEET_PACKAGE_REGISTRY_PORT=12345 yarn test:ftr:runner --config  x-pack/test_serverless/api_integration/test_suites/security/fleet/config.ts
 ```
 
 Observability:
+
 ```sh
 FLEET_PACKAGE_REGISTRY_PORT=12345 yarn test:ftr:server --config x-pack/test_serverless/api_integration/test_suites/observability/fleet/config.ts
 FLEET_PACKAGE_REGISTRY_PORT=12345 yarn test:ftr:runner --config  x-pack/test_serverless/api_integration/test_suites/observability/fleet/config.ts
@@ -255,14 +269,14 @@ The projects below are dependent on Fleet, most using Fleet API as well. In case
 
 Fleet supports shipping integrations as `.zip` archives with Kibana's source code through a concept referred to as _bundled packages_. This allows integrations like APM, which is enabled by default in Cloud, to reliably provide upgrade paths without internet access, and generally improves stability around Fleet's installation/setup processes for several common integrations.
 
-The set of bundled packages included with Kibana is dictated by a top-level `fleet_packages.json` file in the Kibana repo. This file includes a list of packages with a pinned version that Kibana will consider bundled. When the Kibana distributable is built, a [build task](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/bundle_fleet_packages.ts) will resolve these packages from the Elastic Package Registry, download the appropriate version as a `.zip` archive, and place it in a directory configurable by a `xpack.fleet.bundledPackageLocation` value in `kibana.yml`. By default, these archives are stored in `x-pack/platform/plugins/shared/fleet/.target/bundled_packages/`. In CI/CD, we [override](https://github.com/elastic/kibana/blob/main/x-pack/test/fleet_api_integration/config.base.ts#L19) this default with `/tmp/fleet_bundled_packages`.
+The set of bundled packages included with Kibana is dictated by a top-level `fleet_packages.json` file in the Kibana repo. This file includes a list of packages with a pinned version that Kibana will consider bundled. When the Kibana distributable is built, a [build task](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/bundle_fleet_packages.ts) will resolve these packages from the Elastic Package Registry, download the appropriate version as a `.zip` archive, and place it in a directory configurable by a `xpack.fleet.bundledPackageLocation` value in `kibana.yml`. By default, these archives are stored in `x-pack/platform/plugins/shared/fleet/.target/bundled_packages/`. In CI/CD, we [override](https://github.com/elastic/kibana/blob/main/x-pack/platform/test/fleet_api_integration/config.base.ts#L19) this default with `/tmp/fleet_bundled_packages`.
 
 Until further automation is added, this `fleet_packages.json` file should be updated as part of the release process to ensure the latest compatible version of each bundled package is included with that Kibana version. **This must be done before the final BC for a release is built.**
 Tracking issues should be opened and tracked by the Fleet UI team. See https://github.com/elastic/kibana/issues/129309 as an example.
 
 As part of the bundled package update process, we'll likely also need to update the pinned Docker image that runs in Kibana's test environment. We configure this pinned registry image in
 
-- `x-pack/test/fleet_api_integration/config.ts`
+- `x-pack/platform/test/fleet_api_integration/config.ts`
 - `x-pack/platform/plugins/shared/fleet/server/integration_tests/helpers/docker_registry_helper.ts`
 - `x-pack/test/functional/config.base.js`
 

x-pack/platform/plugins/shared/fleet/dev_docs/api_integration_tests.md

@@ -5,29 +5,29 @@ Many API integration tests for Ingest Manager trigger at some point a connection
 - the deployed registry is temporarily unavailable
 - the packages served by the registry do not match the expectation of the code under test
 
-For that reason, we run a dockerized version of the package registry in Kibana CI. For this to work, our tests must run against a custom test configuration and be kept in a custom directory, `x-pack/test/fleet_api_integration`.
+For that reason, we run a dockerized version of the package registry in Kibana CI. For this to work, our tests must run against a custom test configuration and be kept in a custom directory, `x-pack/platform/test/fleet_api_integration`.
 
 ## How to run the tests locally
 
 Usually, having the test server and the test runner in two different shells is most efficient, as it is possible to keep the server running and only rerun the test runner as often as needed. To do so, in one shell in the main `kibana` directory, run:
 
 ```
 $ export FLEET_PACKAGE_REGISTRY_PORT=12345
-$ yarn test:ftr:server --config x-pack/test/fleet_api_integration/config.ts
+$ yarn test:ftr:server --config x-pack/platform/test/fleet_api_integration/config.ts
 ```
 
 In another shell in the same directory, run
 
 ```
 $ export FLEET_PACKAGE_REGISTRY_PORT=12345
-$ yarn test:ftr:runner --config x-pack/test/fleet_api_integration/config.ts
+$ yarn test:ftr:runner --config x-pack/platform/test/fleet_api_integration/config.ts
 ```
 
 However, it is also possible to **alternatively** run everything in one go, again from the main `kibana` directory:
 
 ```
 $ export FLEET_PACKAGE_REGISTRY_PORT=12345
-$ yarn test:ftr --config x-pack/test/fleet_api_integration/config.ts
+$ yarn test:ftr --config x-pack/platform/test/fleet_api_integration/config.ts
 ```
 
 Port `12345` is used as an example here, it can be anything, but the environment variable has to be present for the tests to run at all.
@@ -37,7 +37,7 @@ Port `12345` is used as an example here, it can be anything, but the environment
 We use the `DockerServers` service provided by `kbn-test`. The documentation for this functionality can be found here:
 https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-test/src/functional_test_runner/lib/docker_servers/README.md
 
-The main configuration for the `DockerServers` service for our tests can be found in `x-pack/test/fleet_api_integration/config.ts`:
+The main configuration for the `DockerServers` service for our tests can be found in `x-pack/platform/test/fleet_api_integration/config.ts`:
 
 ### Specify the arguments to pass to `docker run`:
 
@@ -74,7 +74,7 @@ The containerized package registry contains a set of packages which should be su
 docker run -p 8080:8080 docker.elastic.co/package-registry/package-registry:kibana-testing-1
 ```
 
-Additional packages for testing certain corner cases or error conditions can be put into `x-pack/test/fleet_api_integration/apis/fixtures/test_packages`. A package `filetest` has been added there as an example.
+Additional packages for testing certain corner cases or error conditions can be put into `x-pack/platform/test/fleet_api_integration/apis/fixtures/test_packages`. A package `filetest` has been added there as an example.
 
 ## Some DockerServers background
 

x-pack/platform/plugins/shared/fleet/dev_docs/space_awareness.md

@@ -77,4 +77,4 @@ appContextService.getInternalUserSOClientWithoutSpaceExtension().find({
 
 ## Testing
 
-As we need the feature flag enabled there is a special test config for space awareness in `x-pack/test/fleet_api_integration/apis/space_awareness` it's important to have test coverage that entities that should only be accessible in a space are not accessible in a other one.
+As we need the feature flag enabled there is a special test config for space awareness in `x-pack/platform/test/fleet_api_integration/apis/space_awareness` it's important to have test coverage that entities that should only be accessible in a space are not accessible in a other one.

x-pack/platform/plugins/shared/fleet/scripts/verify_test_packages/verify_test_packages.ts

@@ -22,9 +22,9 @@ import {
 const readFileAsync = promisify(readFile);
 
 export const TEST_PACKAGE_DIRECTORIES = [
-  '../../../../../../test/fleet_api_integration/apis/fixtures/bundled_packages',
-  '../../../../../../test/fleet_api_integration/apis/fixtures/test_packages',
-  '../../../../../../test/fleet_api_integration/apis/fixtures/package_verification/packages',
+  '../../../../../test/fleet_api_integration/apis/fixtures/bundled_packages',
+  '../../../../../test/fleet_api_integration/apis/fixtures/test_packages',
+  '../../../../../test/fleet_api_integration/apis/fixtures/package_verification/packages',
 ];
 
 const getAllPathsFromDir = (dir: string): string[] =>

x-pack/platform/plugins/shared/fleet/server/services/epm/archive/parse.test.ts

@@ -323,10 +323,10 @@ describe('parseAndVerifyArchive', () => {
   it('should parse package successfully', async () => {
     const packageInfo: ArchivePackage = await _generatePackageInfoFromPaths(
       [
-        'x-pack/test/fleet_api_integration/apis/fixtures/package_verification/packages/src/input_only-0.1.0/docs/README.md',
-        'x-pack/test/fleet_api_integration/apis/fixtures/package_verification/packages/src/input_only-0.1.0/manifest.yml',
+        'x-pack/platform/test/fleet_api_integration/apis/fixtures/package_verification/packages/src/input_only-0.1.0/docs/README.md',
+        'x-pack/platform/test/fleet_api_integration/apis/fixtures/package_verification/packages/src/input_only-0.1.0/manifest.yml',
       ],
-      'x-pack/test/fleet_api_integration/apis/fixtures/package_verification/packages/src/input_only-0.1.0'
+      'x-pack/platform/test/fleet_api_integration/apis/fixtures/package_verification/packages/src/input_only-0.1.0'
     );
 
     expect(packageInfo).toEqual({

x-pack/platform/test/fleet_api_integration/apis/agents/index.js

@@ -0,0 +1,32 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0; you may not use this file except in compliance with the Elastic License
+ * 2.0.
+ */
+
+import { setupTestUsers } from '../test_users';
+
+export default function loadTests({ loadTestFile, getService }) {
+  describe('Agents', () => {
+    before(async () => {
+      await setupTestUsers(getService('security'));
+    });
+    loadTestFile(require.resolve('./delete'));
+    loadTestFile(require.resolve('./list'));
+    loadTestFile(require.resolve('./unenroll'));
+    loadTestFile(require.resolve('./actions'));
+    loadTestFile(require.resolve('./upgrade'));
+    loadTestFile(require.resolve('./action_status'));
+    loadTestFile(require.resolve('./reassign'));
+    loadTestFile(require.resolve('./status'));
+    loadTestFile(require.resolve('./update'));
+    loadTestFile(require.resolve('./update_agent_tags'));
+    loadTestFile(require.resolve('./available_versions'));
+    loadTestFile(require.resolve('./request_diagnostics'));
+    loadTestFile(require.resolve('./uploads'));
+    loadTestFile(require.resolve('./get_agents_by_actions'));
+    loadTestFile(require.resolve('./privileges'));
+    loadTestFile(require.resolve('./migrate'));
+  });
+}