Skip to content

Comments

[9.1] [Security Solution] Prebuilt rule customizations flyout refactor (#227355)#228350

Merged
dplumlee merged 1 commit intoelastic:9.1from
dplumlee:backport/9.1/pr-227355
Jul 17, 2025
Merged

[9.1] [Security Solution] Prebuilt rule customizations flyout refactor (#227355)#228350
dplumlee merged 1 commit intoelastic:9.1from
dplumlee:backport/9.1/pr-227355

Conversation

@dplumlee
Copy link
Contributor

Backport

This will backport the following commits from main to 9.1:

Questions ?

Please refer to the Backport tool documentation

…stic#227355)

**Fixes: elastic#227805
**Follow-up to:** elastic#225939

## Summary

Addresses comments from previous PR and refactors code to a more
readable structure and adds labels to the "Investigation guide" and
"Setup guide" sections of the Rule Details page for better displays to
the user.

### Screenshots

**Rule details panel**

<img width="1492" height="1030" alt="Screenshot 2025-07-15 at 11 39
07 AM"
src="https://github.com/user-attachments/assets/9844f89e-c23c-4065-af6a-44d670387f94"
/>

<img width="1484" height="792" alt="Screenshot 2025-07-15 at 1 44 52 PM"
src="https://github.com/user-attachments/assets/bb97a219-c1ed-4654-8b8f-04ac76b9d7c1"
/>

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed

---------

Co-authored-by: Maxim Palenov <maxim.palenov@elastic.co>
(cherry picked from commit 74c030a)
@dplumlee dplumlee requested a review from kibanamachine as a code owner July 16, 2025 23:55
@dplumlee dplumlee added the backport This PR is a backport of another PR label Jul 16, 2025
@dplumlee dplumlee enabled auto-merge (squash) July 16, 2025 23:55
@dplumlee dplumlee merged commit 589f11a into elastic:9.1 Jul 17, 2025
16 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.8MB 9.8MB -769.0B

@dplumlee dplumlee deleted the backport/9.1/pr-227355 branch July 17, 2025 02:01
dplumlee added a commit that referenced this pull request Jul 17, 2025
…or (#227355) (#228367)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[Security Solution] Prebuilt rule customizations flyout refactor
(#227355)](#227355)

<!--- Backport version: 10.0.0 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Davis
Plumlee","email":"56367316+dplumlee@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-07-16T21:09:38Z","message":"[Security
Solution] Prebuilt rule customizations flyout refactor
(#227355)\n\n**Fixes:
https://github.com/elastic/kibana/issues/227805**\n**Follow-up to:**
https://github.com/elastic/kibana/pull/225939\n\n## Summary\n\nAddresses
comments from previous PR and refactors code to a more\nreadable
structure and adds labels to the \"Investigation guide\" and\n\"Setup
guide\" sections of the Rule Details page for better displays to\nthe
user.\n\n\n### Screenshots\n\n**Rule details panel**\n\n<img
width=\"1492\" height=\"1030\" alt=\"Screenshot 2025-07-15 at 11
39\n07 AM\"\nsrc=\"https://github.com/user-attachments/assets/9844f89e-c23c-4065-af6a-44d670387f94\"\n/>\n\n\n<img
width=\"1484\" height=\"792\" alt=\"Screenshot 2025-07-15 at 1 44
52 PM\"\nsrc=\"https://github.com/user-attachments/assets/bb97a219-c1ed-4654-8b8f-04ac76b9d7c1\"\n/>\n\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [x] Any text
added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n-
[x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common scenarios\n- [ ] [Flaky
Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\nused on any tests changed\n\n---------\n\nCo-authored-by: Maxim
Palenov
<maxim.palenov@elastic.co>","sha":"74c030ad8544df9559dc8fb92320221f5930634d","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Detections
and Resp","Team: SecuritySolution","Team:Detection Rule
Management","Feature:Prebuilt Detection
Rules","ci:cloud-deploy","ci:project-deploy-security","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[Security
Solution] Prebuilt rule customizations flyout
refactor","number":227355,"url":"https://github.com/elastic/kibana/pull/227355","mergeCommit":{"message":"[Security
Solution] Prebuilt rule customizations flyout refactor
(#227355)\n\n**Fixes:
https://github.com/elastic/kibana/issues/227805**\n**Follow-up to:**
https://github.com/elastic/kibana/pull/225939\n\n## Summary\n\nAddresses
comments from previous PR and refactors code to a more\nreadable
structure and adds labels to the \"Investigation guide\" and\n\"Setup
guide\" sections of the Rule Details page for better displays to\nthe
user.\n\n\n### Screenshots\n\n**Rule details panel**\n\n<img
width=\"1492\" height=\"1030\" alt=\"Screenshot 2025-07-15 at 11
39\n07 AM\"\nsrc=\"https://github.com/user-attachments/assets/9844f89e-c23c-4065-af6a-44d670387f94\"\n/>\n\n\n<img
width=\"1484\" height=\"792\" alt=\"Screenshot 2025-07-15 at 1 44
52 PM\"\nsrc=\"https://github.com/user-attachments/assets/bb97a219-c1ed-4654-8b8f-04ac76b9d7c1\"\n/>\n\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [x] Any text
added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n-
[x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common scenarios\n- [ ] [Flaky
Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\nused on any tests changed\n\n---------\n\nCo-authored-by: Maxim
Palenov
<maxim.palenov@elastic.co>","sha":"74c030ad8544df9559dc8fb92320221f5930634d"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/228350","number":228350,"state":"MERGED","mergeCommit":{"sha":"589f11adeff0832acb9043c08041ce578323fa51","message":"[9.1]
[Security Solution] Prebuilt rule customizations flyout refactor
(#227355) (#228350)\n\n# Backport\n\nThis will backport the following
commits from `main` to `9.1`:\n- [[Security Solution] Prebuilt rule
customizations flyout
refactor\n(#227355)](https://github.com/elastic/kibana/pull/227355)\n\n\n\n###
Questions ?\nPlease refer to the [Backport
tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by:
Maxim Palenov
<maxim.palenov@elastic.co>"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/227355","number":227355,"mergeCommit":{"message":"[Security
Solution] Prebuilt rule customizations flyout refactor
(#227355)\n\n**Fixes:
https://github.com/elastic/kibana/issues/227805**\n**Follow-up to:**
https://github.com/elastic/kibana/pull/225939\n\n## Summary\n\nAddresses
comments from previous PR and refactors code to a more\nreadable
structure and adds labels to the \"Investigation guide\" and\n\"Setup
guide\" sections of the Rule Details page for better displays to\nthe
user.\n\n\n### Screenshots\n\n**Rule details panel**\n\n<img
width=\"1492\" height=\"1030\" alt=\"Screenshot 2025-07-15 at 11
39\n07 AM\"\nsrc=\"https://github.com/user-attachments/assets/9844f89e-c23c-4065-af6a-44d670387f94\"\n/>\n\n\n<img
width=\"1484\" height=\"792\" alt=\"Screenshot 2025-07-15 at 1 44
52 PM\"\nsrc=\"https://github.com/user-attachments/assets/bb97a219-c1ed-4654-8b8f-04ac76b9d7c1\"\n/>\n\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [x] Any text
added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n-
[x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common scenarios\n- [ ] [Flaky
Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\nused on any tests changed\n\n---------\n\nCo-authored-by: Maxim
Palenov
<maxim.palenov@elastic.co>","sha":"74c030ad8544df9559dc8fb92320221f5930634d"}}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants