[ci] use es snapshots on non pull requests#22834
Merged
jbudz merged 3 commits intoelastic:masterfrom Sep 10, 2018
Merged
Conversation
Contributor
💔 Build Failed |
tylersmalley
reviewed
Sep 7, 2018
| function checkout_clone_target { | ||
| pick_clone_target | ||
| if [[ $cloneBranch = "master" && $cloneAuthor = "elastic" ]]; then | ||
| export TEST_ES_FROM=snapshot |
Member
There was a problem hiding this comment.
Do we need to checkout the es branch if we are running from a snapshot? Might be good time savings.
Contributor
Author
There was a problem hiding this comment.
yeah i was hoping to do that, we reference a dotfile in the repo for setting up the correct java version. i'll see if there's someone else we can find it
Member
There was a problem hiding this comment.
Ah, that's right - that's fine for now.
Member
There was a problem hiding this comment.
This also is only for master - I am fine with that for now. We can always add 6.x to the list.
Contributor
💚 Build Succeeded |
tylersmalley
approved these changes
Sep 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.