[8.19] [Attack discovery] Update Attack discovery call to action buttons and flyout (#228150)#228313
Merged
andrew-goldstein merged 2 commits intoelastic:8.19from Jul 17, 2025
Conversation
spong
approved these changes
Jul 16, 2025
25e8aea to
84e1ef5
Compare
Contributor
Author
|
It appears this may depend on the following open backport: #228346 |
84e1ef5 to
986e2a2
Compare
Contributor
Author
|
/ci |
This comment was marked as outdated.
This comment was marked as outdated.
… flyout (elastic#228150) ## [Attack discovery] Update Attack discovery call to action buttons and flyout This PR updates the Attack discovery call to action buttons and flyout, as illustrated by the animated gif below:  Highlights include: - `Schedule` is the new primary call to action - The `Generate` button is renamed to `Run` - The settings gear is restyled as a split button, associated with the `Run` button - `Save and run` is a new default action available the settings flyout - It's no longer possible to tab between Settings and Schedules in the flyout - The Show anonymized values toggle button is restyled as a switch - A confirmation dialog is displayed when users attempt to close an unsaved schedule**  See the screenshots in the _Details_ section below for additional style and text updates. ** Users will only be prompted when the `Connector`, `Custom query`, `Date range`, or `Set number of alerts to analyze` schedule properties are modified ### Details The following before and after screenshots detail the changes in this PR: **Header** | Before | After | |--------|-------| |  |  | The tooltips for the call to action buttons in the header are illustrated by the following animated gif:  **Settings** | Before | After | |--------|-------| |  |  | **Schedule list** | Before | After | |--------|-------| |  |  | **Schedule preview** | Before | After | |--------|-------| |  |  | **Edit schedule** | Before | After | |--------|-------| |  |  | **Schedule empty state** | Before | After | |--------|-------| |  |  | **Create new schedule** | Before | After | |--------|-------| |  |  | **Discard unsaved changes**   ### Feature flags The following feature flags must be enabled in `config/kibana.dev.yml` to view the changes in this PR. ```yaml feature_flags.overrides: securitySolution.attackDiscoveryAlertsEnabled: true securitySolution.assistantAttackDiscoverySchedulingEnabled: true ``` (cherry picked from commit 18bf4de) # Conflicts: # x-pack/solutions/security/plugins/security_solution/public/attack_discovery/pages/results/summary/index.tsx
986e2a2 to
9791655
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.19:Questions ?
Please refer to the Backport tool documentation