Skip to content

Comments

[8.19] [Attack discovery] Update Attack discovery call to action buttons and flyout (#228150)#228313

Merged
andrew-goldstein merged 2 commits intoelastic:8.19from
andrew-goldstein:backport/8.19/pr-228150
Jul 17, 2025
Merged

[8.19] [Attack discovery] Update Attack discovery call to action buttons and flyout (#228150)#228313
andrew-goldstein merged 2 commits intoelastic:8.19from
andrew-goldstein:backport/8.19/pr-228150

Conversation

@andrew-goldstein
Copy link
Contributor

Backport

This will backport the following commits from main to 8.19:

Questions ?

Please refer to the Backport tool documentation

@andrew-goldstein andrew-goldstein force-pushed the backport/8.19/pr-228150 branch from 25e8aea to 84e1ef5 Compare July 17, 2025 01:33
@andrew-goldstein
Copy link
Contributor Author

It appears this may depend on the following open backport: #228346

@andrew-goldstein andrew-goldstein force-pushed the backport/8.19/pr-228150 branch from 84e1ef5 to 986e2a2 Compare July 17, 2025 03:25
@andrew-goldstein
Copy link
Contributor Author

/ci

@elasticmachine

This comment was marked as outdated.

andrew-goldstein and others added 2 commits July 17, 2025 00:53
… flyout (elastic#228150)

## [Attack discovery] Update Attack discovery call to action buttons and flyout

This PR updates the Attack discovery call to action buttons and flyout, as illustrated by the animated gif below:

![03_cta_tooltips](https://github.com/user-attachments/assets/f43b39dc-a184-43db-a812-16e97798186f)

 Highlights include:

- `Schedule` is the new primary call to action
- The `Generate` button is renamed to `Run`
- The settings gear is restyled as a split button, associated with the `Run` button
- `Save and run` is a new default action available the settings flyout
- It's no longer possible to tab between Settings and Schedules in the flyout
- The Show anonymized values toggle button is restyled as a switch
- A confirmation dialog is displayed when users attempt to close an unsaved schedule**

![17_discard_unsaved_changes](https://github.com/user-attachments/assets/0c288036-7599-4051-bd17-0ceccf6c273c)

See the screenshots in the _Details_ section below for additional style and text updates.

** Users will only be prompted when the `Connector`, `Custom query`, `Date range`, or `Set number of alerts to analyze` schedule properties are modified

### Details

The following before and after screenshots detail the changes in this PR:

**Header**

| Before | After |
|--------|-------|
| ![01_header_before](https://github.com/user-attachments/assets/424e7c97-6cd6-4dd8-8d1b-936ce4bd7aa1)       | ![02_header_after](https://github.com/user-attachments/assets/b3ace302-d641-4fde-9848-a00603d7c46c)      |

The tooltips for the call to action buttons in the header are illustrated by the following animated gif:

![03_cta_tooltips](https://github.com/user-attachments/assets/f43b39dc-a184-43db-a812-16e97798186f)

**Settings**

| Before | After |
|--------|-------|
| ![04_settings_before](https://github.com/user-attachments/assets/dc6a6783-08b3-420f-96fd-69de62e2939b)       | ![05_settings_after](https://github.com/user-attachments/assets/13d55965-3b36-4e5a-8cc7-7b3a283d01ed)      |

**Schedule list**

| Before | After |
|--------|-------|
| ![06_schedule_list_before](https://github.com/user-attachments/assets/de6df104-3cd0-43da-8b86-51b4257a5549)       | ![07_schedule_list_after](https://github.com/user-attachments/assets/37fe980a-88f9-4e2f-96c0-1a00f06a6693)      |

**Schedule preview**

| Before | After |
|--------|-------|
| ![08_schedule_preview_before](https://github.com/user-attachments/assets/7e8d7814-b84f-4d88-93d3-776662ea7d6a)       | ![09_schedule_preview_after](https://github.com/user-attachments/assets/190e93c3-a9eb-4f81-a463-24a21dacad21)      |

**Edit schedule**

| Before | After |
|--------|-------|
| ![10_edit_before](https://github.com/user-attachments/assets/aa3dedd1-6b93-4d89-960f-d436aff0eaab)       | ![11_edit_after](https://github.com/user-attachments/assets/38294d80-e27b-419e-a56c-567ead0995c3)      |

**Schedule empty state**

| Before | After |
|--------|-------|
| ![12_schedule_empty_state_before](https://github.com/user-attachments/assets/32ae309a-61e6-45bd-bb38-766477878b05)       | ![13_schedule_empty_state_after](https://github.com/user-attachments/assets/3b72a289-5749-45b6-b5f4-fe5117047351)      |

**Create new schedule**

| Before | After |
|--------|-------|
| ![14_create_new_schedule_before](https://github.com/user-attachments/assets/6ca666b6-c013-484c-98d3-bc9a44b8c237)       | ![15_create_new_schedule_after](https://github.com/user-attachments/assets/f5c86749-0e1f-4caa-976e-61355381af66)      |

**Discard unsaved changes**

![16_discard_unsaved_changes](https://github.com/user-attachments/assets/79400951-7186-464b-b86b-ff8e85c29dce)

![17_discard_unsaved_changes](https://github.com/user-attachments/assets/0c288036-7599-4051-bd17-0ceccf6c273c)

### Feature flags

The following feature flags must be enabled in `config/kibana.dev.yml` to view the changes in this PR.

```yaml
feature_flags.overrides:
  securitySolution.attackDiscoveryAlertsEnabled: true
  securitySolution.assistantAttackDiscoverySchedulingEnabled: true
```

(cherry picked from commit 18bf4de)

# Conflicts:
#	x-pack/solutions/security/plugins/security_solution/public/attack_discovery/pages/results/summary/index.tsx
@andrew-goldstein andrew-goldstein force-pushed the backport/8.19/pr-228150 branch from 986e2a2 to 9791655 Compare July 17, 2025 04:54
@andrew-goldstein andrew-goldstein merged commit 7935923 into elastic:8.19 Jul 17, 2025
9 checks passed
@andrew-goldstein andrew-goldstein deleted the backport/8.19/pr-228150 branch July 17, 2025 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants