Skip to content

Comments

[9.1] [SecuritySolution] [Bug] Hide timeline for priv mon onboarding (#225442)#228252

Merged
machadoum merged 1 commit intoelastic:9.1from
machadoum:backport/9.1/pr-225442
Jul 16, 2025
Merged

[9.1] [SecuritySolution] [Bug] Hide timeline for priv mon onboarding (#225442)#228252
machadoum merged 1 commit intoelastic:9.1from
machadoum:backport/9.1/pr-225442

Conversation

@machadoum
Copy link
Member

Backport

This will backport the following commits from main to 9.1:

Questions ?

Please refer to the Backport tool documentation

…ic#225442)

## Summary

Fix the bug that caused the timeline to overlap with the onboarding
components on the privileged user monitoring page.
Since the timeline is not required on an onboarding page, we decided to
hide it.

For now, I decided to implement the simplest change to fix the bug,
which is adding a URL param (`hideTimeline`) exclusively for hiding the
timeline. I also considered updating the existing `timeline` URL
parameter, but that seems too complicated for a bug fix, especially
since it would require updating the timeline Redux store, which already
has a `show` property used for other purposes. If this use case becomes
widely used, we can refactor it to be part of the timeline core
implementation.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Sergi Massaneda <sergi.massaneda@elastic.co>
(cherry picked from commit fbbef67)
@machadoum machadoum requested a review from kibanamachine as a code owner July 16, 2025 15:28
@machadoum machadoum added the backport This PR is a backport of another PR label Jul 16, 2025
@machadoum machadoum enabled auto-merge (squash) July 16, 2025 15:28
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.8MB 9.8MB +638.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 94.3KB 94.7KB +402.0B

Copy link
Contributor

@jaredburgettelastic jaredburgettelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that changes are exactly the same as https://github.com/elastic/kibana/pull/225442/files, looks good!

@machadoum machadoum merged commit 2b35056 into elastic:9.1 Jul 16, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants