Skip to content

[AI4SOC] Added support for the new promotion rule tag #228232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xcrzx merged 2 commits into from
Jul 17, 2025
Merged

[AI4SOC] Added support for the new promotion rule tag #228232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4b7c75
Added support for the new promotion rule tag
Jul 16, 2025
45c0496
Merge branch 'main' into promotion-rule-tag-update
maximpn Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion x-pack/solutions/security/plugins/security_solution/common/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,4 +516,7 @@ export const JEST_ENVIRONMENT = typeof jest !== 'undefined';
/*
* The tag to mark promotion rules that are related to the AI for SOC integrations
*/
export const PROMOTION_RULE_TAG = 'Promotion';
export const PROMOTION_RULE_TAGS = [
'Promotion', // This is the legacy tag for promotion rules and can be safely removed once promotion rules go live
'Promotion: External Alerts',
];
9 changes: 7 additions & 2 deletions .../server/lib/detection_engine/prebuilt_rules/logic/integrations/install_promotion_rules.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ import type {
} from '../../../../../../common/api/detection_engine/prebuilt_rules/bootstrap_prebuilt_rules/bootstrap_prebuilt_rules.gen';
import { getErrorMessage } from '../../../../../utils/error_helpers';
import type { EndpointInternalFleetServicesInterface } from '../../../../../endpoint/services/fleet';
import { PROMOTION_RULE_TAG } from '../../../../../../common/constants';
import { PROMOTION_RULE_TAGS } from '../../../../../../common/constants';
import type { PrebuiltRuleAsset } from '../../model/rule_assets/prebuilt_rule_asset';

interface InstallPromotionRulesParams {
rulesClient: RulesClient;
Expand Down Expand Up @@ -70,7 +71,7 @@ export async function installPromotionRules({
const latestPromotionRules = latestRuleAssets.filter((rule) => {
// Rule should be tagged as 'Promotion' and should be related to an enabled integration
return (
(rule.tags ?? []).includes(PROMOTION_RULE_TAG) &&
isPromotionRule(rule) &&
rule.related_integrations?.some((integration) =>
installedIntegrations.has(integration.package)
)
Expand Down Expand Up @@ -146,3 +147,7 @@ export async function installPromotionRules({
errors: allErrors.size > 0 ? Array.from(allErrors.values()) : [],
};
}

function isPromotionRule(rule: PrebuiltRuleAsset): boolean {
return (rule.tags ?? []).some((tag) => PROMOTION_RULE_TAGS.includes(tag));
}