Merged
Conversation
Contributor
|
Pinging @elastic/apm-ui |
sorenlouv
commented
Sep 7, 2018
Contributor
Author
There was a problem hiding this comment.
@jasonrhodes At least now it is based on the KibanaLink component. Is that ok with you?
Member
There was a problem hiding this comment.
Totally fine with me -- sorry I missed this not working in the other PR!
Contributor
Author
There was a problem hiding this comment.
No worries. I should have manually tested it after making the change.
Contributor
💔 Build Failed |
Contributor
Author
|
retest |
Contributor
💔 Build Failed |
sorenlouv
force-pushed
the
fix-ml-links
branch
from
8981818 to
f4fd3eb
Compare
Contributor
💚 Build Succeeded |
sorenlouv
added a commit
to sorenlouv/kibana
that referenced
this pull request
Sep 8, 2018
sorenlouv
added a commit
to sorenlouv/kibana
that referenced
this pull request
Sep 8, 2018
sorenlouv
added a commit
that referenced
this pull request
Sep 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fix in #22592 which was supposed to fix links to ML jobs, didn't work.