[8.19] [Cases] Reverts the introduction of the incremental_id service (#228002)

src/platform/plugins/private/kibana_usage_collection/server/collectors/management/schema.ts

@@ -659,10 +659,4 @@ export const stackManagementSchema: MakeSchemaFrom<UsageStats> = {
       description: 'Enable the new logs overview component.',
     },
   },
-  'cases:incrementalIdDisplay:enabled': {
-    type: 'boolean',
-    _meta: {
-      description: 'Display the incremental id of a case in the relevant pages',
-    },
-  },
 };

src/platform/plugins/private/kibana_usage_collection/server/collectors/management/types.ts

@@ -171,5 +171,4 @@ export interface UsageStats {
   'securitySolution:excludedDataTiersForRuleExecution': string[];
   'securitySolution:maxUnassociatedNotes': number;
   'observability:searchExcludedDataTiers': string[];
-  'cases:incrementalIdDisplay:enabled': boolean;
 }

src/platform/plugins/shared/telemetry/schema/oss_platform.json

@@ -11403,12 +11403,6 @@
           "_meta": {
             "description": "Enable the new logs overview component."
           }
-        },
-        "cases:incrementalIdDisplay:enabled": {
-          "type": "boolean",
-          "_meta": {
-            "description": "Display the incremental id of a case in the relevant pages"
-          }
         }
       }
     },

src/platform/test/plugin_functional/test_suites/core_plugins/rendering.ts

@@ -228,7 +228,6 @@ export default function ({ getService }: PluginFunctionalProviderContext) {
         'xpack.cases.files.maxSize (number?)',
         'xpack.cases.markdownPlugins.lens (boolean?)',
         'xpack.cases.stack.enabled (boolean?)',
-        'xpack.cases.incrementalId.enabled (boolean?)',
         'xpack.ccr.ui.enabled (boolean?)',
         'xpack.cloud.base_url (string?)',
         'xpack.cloud.cname (string?)',

x-pack/platform/plugins/shared/cases/common/constants/index.ts

@@ -27,12 +27,6 @@ export const CASE_CONFIGURE_SAVED_OBJECT = 'cases-configure' as const;
 export const CASE_RULES_SAVED_OBJECT = 'cases-rules' as const;
 export const CASE_ID_INCREMENTER_SAVED_OBJECT = 'cases-incrementing-id' as const;
 
-/**
- * UI settings
- */
-
-export const CASES_UI_SETTING_ID_DISPLAY_INCREMENTAL_ID = 'cases:incrementalIdDisplay:enabled';
-
 /**
  * If more values are added here please also add them here: x-pack/platform/test/cases_api_integration/common/plugins
  */

x-pack/platform/plugins/shared/cases/common/types/api/case/v1.ts

@@ -246,7 +246,6 @@ export const BulkCreateCasesResponseRt = rt.strict({
 export const CasesFindRequestSearchFieldsRt = rt.keyof({
   description: null,
   title: null,
-  incremental_id: null,
 });
 
 export const CasesFindRequestSortFieldsRt = rt.keyof({

x-pack/platform/plugins/shared/cases/common/ui/types.ts

@@ -72,9 +72,6 @@ export interface CasesUiConfigType {
   stack: {
     enabled: boolean;
   };
-  incrementalId: {
-    enabled: boolean;
-  };
 }
 
 export const UserActionTypeAll = 'all' as const;
@@ -345,7 +342,3 @@ export interface CasesCapabilities {
   [CASES_REOPEN_CAPABILITY]: boolean;
   [ASSIGN_CASE_CAPABILITY]: boolean;
 }
-
-export interface CasesSettings {
-  displayIncrementalCaseId: boolean;
-}

x-pack/platform/plugins/shared/cases/public/common/mock/test_providers.tsx

@@ -23,7 +23,7 @@ import { KibanaRenderContextProvider } from '@kbn/react-kibana-context-render';
 
 import type { CoreStart } from '@kbn/core/public';
 import type { BaseFilesClient } from '@kbn/shared-ux-file-types';
-import type { CasesFeatures, CasesPermissions, CasesSettings } from '../../../common/ui/types';
+import type { CasesFeatures, CasesPermissions } from '../../../common/ui/types';
 import type { ReleasePhase } from '../../components/types';
 import { SECURITY_SOLUTION_OWNER } from '../../../common/constants';
 import type { CasesContextProps } from '../../components/cases_context';
@@ -47,7 +47,6 @@ interface TestProviderProps {
   queryClient?: QueryClient;
   coreStart?: CoreStart;
   filesClient?: BaseFilesClient;
-  settings?: CasesSettings;
 }
 
 window.scrollTo = jest.fn();
@@ -93,7 +92,6 @@ const TestProvidersComponent: React.FC<TestProviderProps> = ({
   services,
   queryClient,
   filesClient,
-  settings,
 }) => {
   const finalCoreStart = useMemo(() => coreStart ?? coreMock.createStart(), [coreStart]);
   const finalServices = useMemo(
@@ -140,9 +138,6 @@ const TestProvidersComponent: React.FC<TestProviderProps> = ({
       permissions: permissions ?? defaultPermissions,
       releasePhase: releasePhase ?? 'ga',
       getFilesClient: getFilesClientFinal,
-      settings: settings ?? {
-        displayIncrementalCaseId: false,
-      },
     }),
     [
       defaultExternalReferenceAttachmentTypeRegistry,
@@ -155,7 +150,6 @@ const TestProvidersComponent: React.FC<TestProviderProps> = ({
       permissions,
       persistableStateAttachmentTypeRegistry,
       releasePhase,
-      settings,
     ]
   );
 

x-pack/platform/plugins/shared/cases/public/components/all_cases/all_cases_list.test.tsx

@@ -144,20 +144,14 @@ describe('AllCasesListGeneric', () => {
     userProfiles: new Map(),
     currentUserProfile: undefined,
     selectedColumns: [],
-    settings: {
-      displayIncrementalCaseId: false,
-    },
   };
 
   const removeMsFromDate = (value: string) => moment(value).format('YYYY-MM-DDTHH:mm:ss[Z]');
 
   beforeAll(() => {
     patchGetComputedStyle();
     mockKibana();
-    const {
-      triggersActionsUi: { actionTypeRegistry },
-    } = useKibanaMock().services;
-
+    const actionTypeRegistry = useKibanaMock().services.triggersActionsUi.actionTypeRegistry;
     registerConnectorsToMockActionRegistry(actionTypeRegistry, connectorsMock);
   });
 
@@ -189,9 +183,7 @@ describe('AllCasesListGeneric', () => {
 
   it('should render AllCasesList', async () => {
     useLicenseMock.mockReturnValue({ isAtLeastPlatinum: () => true });
-    renderWithTestingProviders(<AllCasesList />, {
-      wrapperProps: { settings: { displayIncrementalCaseId: true } },
-    });
+    renderWithTestingProviders(<AllCasesList />);
 
     const caseDetailsLinks = await screen.findAllByTestId('case-details-link');
 
@@ -201,10 +193,6 @@ describe('AllCasesListGeneric', () => {
       (await screen.findAllByTestId('case-user-profile-avatar-damaged_raccoon'))[0]
     ).toHaveTextContent('DR');
 
-    const incrementalIdTextElements = screen.getAllByTestId('cases-incremental-id-text');
-    expect(incrementalIdTextElements).toHaveLength(1);
-    expect(incrementalIdTextElements[0]).toHaveTextContent('#1');
-
     expect((await screen.findAllByTestId('case-table-column-tags-coke'))[0]).toHaveAttribute(
       'title',
       useGetCasesMockState.data.cases[0].tags[0]
@@ -226,18 +214,6 @@ describe('AllCasesListGeneric', () => {
     expect(screen.queryByTestId('all-cases-clear-filters-link-icon')).not.toBeInTheDocument();
   });
 
-  it('should not render incremental id if setting is disabled', async () => {
-    useLicenseMock.mockReturnValue({ isAtLeastPlatinum: () => true });
-    renderWithTestingProviders(<AllCasesList />, {
-      wrapperProps: { settings: { displayIncrementalCaseId: false } },
-    });
-
-    await screen.findAllByTestId('case-details-link');
-
-    const incrementalIdTextElements = screen.queryAllByTestId('cases-incremental-id-text');
-    expect(incrementalIdTextElements).toHaveLength(0);
-  });
-
   it("should show a tooltip with the assignee's email when hover over the assignee avatar", async () => {
     useLicenseMock.mockReturnValue({ isAtLeastPlatinum: () => true });
 
@@ -539,6 +515,7 @@ describe('AllCasesListGeneric', () => {
       expect(useGetCasesMock).toHaveBeenLastCalledWith({
         filterOptions: {
           ...DEFAULT_FILTER_OPTIONS,
+          searchFields: ['title', 'description'],
           category: ['twix'],
         },
         queryParams: DEFAULT_QUERY_PARAMS,

x-pack/platform/plugins/shared/cases/public/components/all_cases/all_cases_list.tsx

@@ -46,7 +46,7 @@ export interface AllCasesListProps {
 
 export const AllCasesList = React.memo<AllCasesListProps>(
   ({ hiddenStatuses = [], isSelectorView = false, onRowClick }) => {
-    const { owner, permissions, settings } = useCasesContext();
+    const { owner, permissions } = useCasesContext();
 
     const availableSolutions = useAvailableCasesOwners(getAllPermissionsExceptFrom('delete'));
     const isLoading = useIsLoadingCases();
@@ -141,7 +141,6 @@ export const AllCasesList = React.memo<AllCasesListProps>(
       onRowClick,
       disableActions: selectedCases.length > 0,
       selectedColumns,
-      settings,
     });
 
     const pagination = useMemo(

x-pack/platform/plugins/shared/cases/public/components/all_cases/selector_modal/use_cases_add_to_existing_case_modal.test.tsx

@@ -79,7 +79,6 @@ describe('use cases add to existing case modal hook', () => {
             observables: { enabled: true },
           },
           releasePhase: 'ga',
-          settings: { displayIncrementalCaseId: false },
         }}
       >
         {children}

x-pack/platform/plugins/shared/cases/public/components/all_cases/use_cases_columns.test.tsx

@@ -6,6 +6,7 @@
  */
 
 import React from 'react';
+import { mount } from 'enzyme';
 import { licensingMock } from '@kbn/licensing-plugin/public/mocks';
 
 import type { GetCasesColumn } from './use_cases_columns';
@@ -45,7 +46,6 @@ describe('useCasesColumns ', () => {
     userProfiles: userProfilesMap,
     isSelectorView: false,
     selectedColumns: DEFAULT_SELECTED_COLUMNS,
-    settings: { displayIncrementalCaseId: true },
   };
 
   beforeEach(() => {
@@ -630,56 +630,70 @@ describe('useCasesColumns ', () => {
 
   describe('ExternalServiceColumn ', () => {
     it('Not pushed render', () => {
-      renderWithTestingProviders(
-        <ExternalServiceColumn
-          theCase={useGetCasesMockState.data.cases[0]}
-          connectors={connectors}
-        />
+      const wrapper = mount(
+        <TestProviders>
+          <ExternalServiceColumn
+            theCase={useGetCasesMockState.data.cases[0]}
+            connectors={connectors}
+          />
+        </TestProviders>
       );
 
-      expect(screen.getByTestId('case-table-column-external-notPushed')).toBeInTheDocument();
+      expect(
+        wrapper.find(`[data-test-subj="case-table-column-external-notPushed"]`).last().exists()
+      ).toBeTruthy();
     });
 
     it('Up to date', () => {
-      renderWithTestingProviders(
-        <ExternalServiceColumn
-          theCase={useGetCasesMockState.data.cases[1]}
-          connectors={connectors}
-        />
+      const wrapper = mount(
+        <TestProviders>
+          <ExternalServiceColumn
+            theCase={useGetCasesMockState.data.cases[1]}
+            connectors={connectors}
+          />
+        </TestProviders>
       );
 
-      expect(screen.getByTestId('case-table-column-external-upToDate')).toBeInTheDocument();
+      expect(
+        wrapper.find(`[data-test-subj="case-table-column-external-upToDate"]`).last().exists()
+      ).toBeTruthy();
     });
 
     it('Needs update', () => {
-      renderWithTestingProviders(
-        <ExternalServiceColumn
-          theCase={useGetCasesMockState.data.cases[2]}
-          connectors={connectors}
-        />
+      const wrapper = mount(
+        <TestProviders>
+          <ExternalServiceColumn
+            theCase={useGetCasesMockState.data.cases[2]}
+            connectors={connectors}
+          />
+        </TestProviders>
       );
 
-      expect(screen.getByTestId('case-table-column-external-requiresUpdate')).toBeInTheDocument();
+      expect(
+        wrapper.find(`[data-test-subj="case-table-column-external-requiresUpdate"]`).last().exists()
+      ).toBeTruthy();
     });
 
     it('it does not throw when accessing the icon if the connector type is not registered', () => {
       // If the component throws the test will fail
       expect(() =>
-        renderWithTestingProviders(
-          <ExternalServiceColumn
-            theCase={useGetCasesMockState.data.cases[2]}
-            connectors={[
-              {
-                id: 'none',
-                actionTypeId: '.none',
-                name: 'None',
-                config: {},
-                isPreconfigured: false,
-                isSystemAction: false,
-                isDeprecated: false,
-              },
-            ]}
-          />
+        mount(
+          <TestProviders>
+            <ExternalServiceColumn
+              theCase={useGetCasesMockState.data.cases[2]}
+              connectors={[
+                {
+                  id: 'none',
+                  actionTypeId: '.none',
+                  name: 'None',
+                  config: {},
+                  isPreconfigured: false,
+                  isSystemAction: false,
+                  isDeprecated: false,
+                },
+              ]}
+            />
+          </TestProviders>
         )
       ).not.toThrowError();
     });