-
Notifications
You must be signed in to change notification settings - Fork 8.6k
Handle is_partial in ES|QL query responses in Elasticsearch query rule #228118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ersin-erdal
merged 14 commits into
elastic:main
from
ersin-erdal:209408-handle-is-partial
Jul 23, 2025
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
8a80259
Handle is_partial in ES|QL query responses in Elasticsearch query rule
ersin-erdal ffd2732
use i18
ersin-erdal 48e78f6
Merge branch 'main' into 209408-handle-is-partial
ersin-erdal abd382b
[CI] Auto-commit changed files from 'node scripts/eslint_all_files --…
kibanamachine 83df48f
Remove throwing error
ersin-erdal 3604717
Merge branch '209408-handle-is-partial' of github.com:ersin-erdal/kib…
ersin-erdal d2c3d5e
fix test name
ersin-erdal 8de3e37
Merge branch 'main' into 209408-handle-is-partial
ersin-erdal 93e48c8
Improve the warning message
ersin-erdal 4ca3da0
Merge branch '209408-handle-is-partial' of github.com:ersin-erdal/kib…
ersin-erdal 34e8381
[CI] Auto-commit changed files from 'node scripts/eslint_all_files --…
kibanamachine d3a2bb9
Fix the warning message
ersin-erdal fd61f89
Merge branch '209408-handle-is-partial' of github.com:ersin-erdal/kib…
ersin-erdal e7e72ff
Merge branch 'main' into 209408-handle-is-partial
ersin-erdal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since failures can be an empty array, it would be nice to optionally show
Failures:in the message since then the warning will look incomplete. So if we can't extract any useful message from the details, it will just showThe query returned partial results. Some clusters may have been skipped due to timeouts or other issues.