Skip to content

Comments

[Spaces] - code cleanup#22802

Merged
legrego merged 9 commits intoelastic:spaces-phase-1from
legrego:more-spaces-typescript
Sep 14, 2018
Merged

[Spaces] - code cleanup#22802
legrego merged 9 commits intoelastic:spaces-phase-1from
legrego:more-spaces-typescript

Conversation

@legrego
Copy link
Member

@legrego legrego commented Sep 7, 2018

[skip ci]

import { SavedObjectsClient } from './saved_objects_client_types';
import { SpacesSavedObjectsClient } from './spaces_saved_objects_client';

interface SOCWrapperOptions {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we move this to the saved_objects_client_types?

@elastic elastic deleted a comment from elasticmachine Sep 7, 2018
@cjcenizal cjcenizal added the Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// label Sep 7, 2018
Copy link

@ctrlaltvikas ctrlaltvikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@legrego
Copy link
Member Author

legrego commented Sep 14, 2018

@kobelb I'm merging this to spaces-phase-1 to move forward with final testing, but feel free to re-review at your leisure

@legrego legrego merged commit 79bff57 into elastic:spaces-phase-1 Sep 14, 2018
@legrego legrego deleted the more-spaces-typescript branch September 14, 2018 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t//

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants