[AI Infra] Fix inference id missing LLM task retrieval documentation function#228009
Merged
qn895 merged 7 commits intoelastic:mainfrom Jul 17, 2025
Merged
[AI Infra] Fix inference id missing LLM task retrieval documentation function#228009qn895 merged 7 commits intoelastic:mainfrom
qn895 merged 7 commits intoelastic:mainfrom
Conversation
botelastic
bot
added
the
ci:project-deploy-observability
Contributor
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
qn895
added
release_note:skip
viduni94
reviewed
Jul 15, 2025
| const esClient = (await resources.context.core).elasticsearch.client; | ||
| const inferenceId = | ||
| (await getInferenceIdFromWriteIndex(esClient, resources.logger)) ?? | ||
| defaultInferenceEndpoints.ELSER; |
Contributor
There was a problem hiding this comment.
Do we need a fallback here?
Since the fallback is added in x-pack/platform/plugins/shared/ai_infra/llm_tasks/server/plugin.ts --> retrieveDocumentationAvailable
Member
Author
There was a problem hiding this comment.
Left the fallback here cause I made inference ID a required param here acb8478 (#228009)
| To check if documentation is available fora different Inference ID: | ||
|
|
||
| ```ts | ||
| if (await llmTasksStart.retrieveDocumentationAvailable({inferenceId})) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if (await llmTasksStart.retrieveDocumentationAvailable({inferenceId})) { | |
| if (await llmTasksStart.retrieveDocumentationAvailable({ inferenceId })) { |
viduni94
reviewed
Jul 15, 2025
| retrieveDocumentationAvailable: async (options?: { inferenceId?: string }) => { | ||
| const docBaseStatus = await startDependencies.productDocBase.management.getStatus({ | ||
| inferenceId: defaultInferenceEndpoints.ELSER, | ||
| inferenceId: options?.inferenceId ?? defaultInferenceEndpoints.ELSER, |
Contributor
There was a problem hiding this comment.
Can we make inferenceId a required property?
And always pass the current inference ID in all places this is used.
cc: @dgieselaar
viduni94
approved these changes
Jul 15, 2025
elastic-vault-github-plugin-prod
bot
requested a review
from a team
as a code owner
…when the KB is installed
Contributor
⏳ Build in-progress
History
cc @qn895 |
spong
approved these changes
Jul 16, 2025
Contributor
|
Starting backport for target branches: 8.19, 9.1 https://github.com/elastic/kibana/actions/runs/16338253023 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
qn895
added a commit
to qn895/kibana
that referenced
this pull request
Jul 17, 2025
…function (elastic#228009) This PR addresses elastic#227906 and fixes Inference id missing LLM task retrieval documentation function. By default, it will use the default ELSER endpoint. With the E5 model: <img width="1410" height="881" alt="Screenshot 2025-07-15 at 08 10 40" src="https://github.com/user-attachments/assets/43813d8e-011d-4a64-86cc-0e03e93c4c7f" /> Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Viduni Wickramarachchi <viduni.wickramarachchi@elastic.co> (cherry picked from commit 03bb564)
Member
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
qn895
added a commit
to qn895/kibana
that referenced
this pull request
Jul 17, 2025
…function (elastic#228009) This PR addresses elastic#227906 and fixes Inference id missing LLM task retrieval documentation function. By default, it will use the default ELSER endpoint. With the E5 model: <img width="1410" height="881" alt="Screenshot 2025-07-15 at 08 10 40" src="https://github.com/user-attachments/assets/43813d8e-011d-4a64-86cc-0e03e93c4c7f" /> Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Viduni Wickramarachchi <viduni.wickramarachchi@elastic.co> (cherry picked from commit 03bb564)
qn895
added a commit
that referenced
this pull request
Jul 18, 2025
…ation function (#228009) (#228419) # Backport This will backport the following commits from `main` to `9.1`: - [[AI Infra] Fix inference id missing LLM task retrieval documentation function (#228009)](#228009) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Quynh Nguyen (Quinn)","email":"43350163+qn895@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-07-17T06:50:42Z","message":"[AI Infra] Fix inference id missing LLM task retrieval documentation function (#228009)\n\n## Summary\n\nThis PR addresses #227906 and\nfixes Inference id missing LLM task retrieval documentation function. By\ndefault, it will use the default ELSER endpoint.\n\nWith the E5 model:\n\n<img width=\"1410\" height=\"881\" alt=\"Screenshot 2025-07-15 at 08 10 40\"\nsrc=\"https://github.com/user-attachments/assets/43813d8e-011d-4a64-86cc-0e03e93c4c7f\"\n/>\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [ ] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n### Identify risks\n\nDoes this PR introduce any risks? For example, consider risks like hard\nto test bugs, performance regression, potential of data loss.\n\nDescribe the risk, its severity, and mitigation for each identified\nrisk. Invite stakeholders and evaluate how to proceed before merging.\n\n- [ ] [See some risk\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)\n- [ ] ...\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Viduni Wickramarachchi <viduni.wickramarachchi@elastic.co>","sha":"03bb564e4d178e35e513c1119f721ebaf937b9d9","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","ci:project-deploy-observability","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[AI Infra] Fix inference id missing LLM task retrieval documentation function","number":228009,"url":"https://github.com/elastic/kibana/pull/228009","mergeCommit":{"message":"[AI Infra] Fix inference id missing LLM task retrieval documentation function (#228009)\n\n## Summary\n\nThis PR addresses #227906 and\nfixes Inference id missing LLM task retrieval documentation function. By\ndefault, it will use the default ELSER endpoint.\n\nWith the E5 model:\n\n<img width=\"1410\" height=\"881\" alt=\"Screenshot 2025-07-15 at 08 10 40\"\nsrc=\"https://github.com/user-attachments/assets/43813d8e-011d-4a64-86cc-0e03e93c4c7f\"\n/>\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [ ] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n### Identify risks\n\nDoes this PR introduce any risks? For example, consider risks like hard\nto test bugs, performance regression, potential of data loss.\n\nDescribe the risk, its severity, and mitigation for each identified\nrisk. Invite stakeholders and evaluate how to proceed before merging.\n\n- [ ] [See some risk\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)\n- [ ] ...\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Viduni Wickramarachchi <viduni.wickramarachchi@elastic.co>","sha":"03bb564e4d178e35e513c1119f721ebaf937b9d9"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/228009","number":228009,"mergeCommit":{"message":"[AI Infra] Fix inference id missing LLM task retrieval documentation function (#228009)\n\n## Summary\n\nThis PR addresses #227906 and\nfixes Inference id missing LLM task retrieval documentation function. By\ndefault, it will use the default ELSER endpoint.\n\nWith the E5 model:\n\n<img width=\"1410\" height=\"881\" alt=\"Screenshot 2025-07-15 at 08 10 40\"\nsrc=\"https://github.com/user-attachments/assets/43813d8e-011d-4a64-86cc-0e03e93c4c7f\"\n/>\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [ ] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n### Identify risks\n\nDoes this PR introduce any risks? For example, consider risks like hard\nto test bugs, performance regression, potential of data loss.\n\nDescribe the risk, its severity, and mitigation for each identified\nrisk. Invite stakeholders and evaluate how to proceed before merging.\n\n- [ ] [See some risk\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)\n- [ ] ...\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Viduni Wickramarachchi <viduni.wickramarachchi@elastic.co>","sha":"03bb564e4d178e35e513c1119f721ebaf937b9d9"}}]}] BACKPORT--> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Viduni Wickramarachchi <viduni.wickramarachchi@elastic.co> Co-authored-by: Dzmitry Lemechko <dzmitry.lemechko@elastic.co>
kibanamachine
added
the
backport missing
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
delanni
pushed a commit
that referenced
this pull request
Jul 21, 2025
## Summary I just spotted that #228009 made an import from deprecated `x-pack/test` helper. It usually leads to circular dependencies issue, so I updated the import to the same helper already in solution directory and removed duplicated directory (it was temp solution to avoid circular deps when moving tests around, sorry for confusion) I moved a few oblt helpers directly to Search solution search_playground test dir, but we probably need to decouple "platform" part of it and move to `kbn/test-suites-xpack-platform` --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
dmlemeshko
added a commit
to dmlemeshko/kibana
that referenced
this pull request
Jul 21, 2025
## Summary I just spotted that elastic#228009 made an import from deprecated `x-pack/test` helper. It usually leads to circular dependencies issue, so I updated the import to the same helper already in solution directory and removed duplicated directory (it was temp solution to avoid circular deps when moving tests around, sorry for confusion) I moved a few oblt helpers directly to Search solution search_playground test dir, but we probably need to decouple "platform" part of it and move to `kbn/test-suites-xpack-platform` --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 122cd9a) # Conflicts: # x-pack/test/api_integration/deployment_agnostic/apis/observability/ai_assistant/utils/knowledge_base.ts # x-pack/test/tsconfig.json
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
Bluefinger
pushed a commit
to Bluefinger/kibana
that referenced
this pull request
Jul 22, 2025
…function (elastic#228009) ## Summary This PR addresses elastic#227906 and fixes Inference id missing LLM task retrieval documentation function. By default, it will use the default ELSER endpoint. With the E5 model: <img width="1410" height="881" alt="Screenshot 2025-07-15 at 08 10 40" src="https://github.com/user-attachments/assets/43813d8e-011d-4a64-86cc-0e03e93c4c7f" /> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Viduni Wickramarachchi <viduni.wickramarachchi@elastic.co>
Bluefinger
pushed a commit
to Bluefinger/kibana
that referenced
this pull request
Jul 22, 2025
## Summary I just spotted that elastic#228009 made an import from deprecated `x-pack/test` helper. It usually leads to circular dependencies issue, so I updated the import to the same helper already in solution directory and removed duplicated directory (it was temp solution to avoid circular deps when moving tests around, sorry for confusion) I moved a few oblt helpers directly to Search solution search_playground test dir, but we probably need to decouple "platform" part of it and move to `kbn/test-suites-xpack-platform` --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
dmlemeshko
added a commit
that referenced
this pull request
Jul 22, 2025
… (#228767) # Backport This will backport the following commits from `main` to `9.1`: - [[ai_assistant] remove import from kbn/test-suites-xpack (#228650)](#228650) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Dzmitry Lemechko","email":"dzmitry.lemechko@elastic.co"},"sourceCommit":{"committedDate":"2025-07-21T09:56:40Z","message":"[ai_assistant] remove import from kbn/test-suites-xpack (#228650)\n\n## Summary\n\nI just spotted that #228009 made\nan import from deprecated `x-pack/test` helper.\n\nIt usually leads to circular dependencies issue, so I updated the import\nto the same helper already in solution directory and removed duplicated\ndirectory (it was temp solution to avoid circular deps when moving tests\naround, sorry for confusion)\n\nI moved a few oblt helpers directly to Search solution search_playground\ntest dir, but we probably need to decouple \"platform\" part of it and\nmove to `kbn/test-suites-xpack-platform`\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"122cd9a7f7936a4385835f74e70166670f8e73a6","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:version","v9.1.0","v9.2.0"],"title":"[ai_assistant] remove import from kbn/test-suites-xpack","number":228650,"url":"https://github.com/elastic/kibana/pull/228650","mergeCommit":{"message":"[ai_assistant] remove import from kbn/test-suites-xpack (#228650)\n\n## Summary\n\nI just spotted that #228009 made\nan import from deprecated `x-pack/test` helper.\n\nIt usually leads to circular dependencies issue, so I updated the import\nto the same helper already in solution directory and removed duplicated\ndirectory (it was temp solution to avoid circular deps when moving tests\naround, sorry for confusion)\n\nI moved a few oblt helpers directly to Search solution search_playground\ntest dir, but we probably need to decouple \"platform\" part of it and\nmove to `kbn/test-suites-xpack-platform`\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"122cd9a7f7936a4385835f74e70166670f8e73a6"}},"sourceBranch":"main","suggestedTargetBranches":["9.1"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/228650","number":228650,"mergeCommit":{"message":"[ai_assistant] remove import from kbn/test-suites-xpack (#228650)\n\n## Summary\n\nI just spotted that #228009 made\nan import from deprecated `x-pack/test` helper.\n\nIt usually leads to circular dependencies issue, so I updated the import\nto the same helper already in solution directory and removed duplicated\ndirectory (it was temp solution to avoid circular deps when moving tests\naround, sorry for confusion)\n\nI moved a few oblt helpers directly to Search solution search_playground\ntest dir, but we probably need to decouple \"platform\" part of it and\nmove to `kbn/test-suites-xpack-platform`\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"122cd9a7f7936a4385835f74e70166670f8e73a6"}}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
qn895
added a commit
that referenced
this pull request
Jul 23, 2025
…tation function (#228009) (#228422) # Backport This will backport the following commits from `main` to `8.19`: - [[AI Infra] Fix inference id missing LLM task retrieval documentation function (#228009)](#228009) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Quynh Nguyen (Quinn)","email":"43350163+qn895@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-07-17T06:50:42Z","message":"[AI Infra] Fix inference id missing LLM task retrieval documentation function (#228009)\n\n## Summary\n\nThis PR addresses #227906 and\nfixes Inference id missing LLM task retrieval documentation function. By\ndefault, it will use the default ELSER endpoint.\n\nWith the E5 model:\n\n<img width=\"1410\" height=\"881\" alt=\"Screenshot 2025-07-15 at 08 10 40\"\nsrc=\"https://github.com/user-attachments/assets/43813d8e-011d-4a64-86cc-0e03e93c4c7f\"\n/>\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [ ] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n### Identify risks\n\nDoes this PR introduce any risks? For example, consider risks like hard\nto test bugs, performance regression, potential of data loss.\n\nDescribe the risk, its severity, and mitigation for each identified\nrisk. Invite stakeholders and evaluate how to proceed before merging.\n\n- [ ] [See some risk\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)\n- [ ] ...\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Viduni Wickramarachchi <viduni.wickramarachchi@elastic.co>","sha":"03bb564e4d178e35e513c1119f721ebaf937b9d9","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","ci:project-deploy-observability","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[AI Infra] Fix inference id missing LLM task retrieval documentation function","number":228009,"url":"https://github.com/elastic/kibana/pull/228009","mergeCommit":{"message":"[AI Infra] Fix inference id missing LLM task retrieval documentation function (#228009)\n\n## Summary\n\nThis PR addresses #227906 and\nfixes Inference id missing LLM task retrieval documentation function. By\ndefault, it will use the default ELSER endpoint.\n\nWith the E5 model:\n\n<img width=\"1410\" height=\"881\" alt=\"Screenshot 2025-07-15 at 08 10 40\"\nsrc=\"https://github.com/user-attachments/assets/43813d8e-011d-4a64-86cc-0e03e93c4c7f\"\n/>\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [ ] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n### Identify risks\n\nDoes this PR introduce any risks? For example, consider risks like hard\nto test bugs, performance regression, potential of data loss.\n\nDescribe the risk, its severity, and mitigation for each identified\nrisk. Invite stakeholders and evaluate how to proceed before merging.\n\n- [ ] [See some risk\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)\n- [ ] ...\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Viduni Wickramarachchi <viduni.wickramarachchi@elastic.co>","sha":"03bb564e4d178e35e513c1119f721ebaf937b9d9"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/228009","number":228009,"mergeCommit":{"message":"[AI Infra] Fix inference id missing LLM task retrieval documentation function (#228009)\n\n## Summary\n\nThis PR addresses #227906 and\nfixes Inference id missing LLM task retrieval documentation function. By\ndefault, it will use the default ELSER endpoint.\n\nWith the E5 model:\n\n<img width=\"1410\" height=\"881\" alt=\"Screenshot 2025-07-15 at 08 10 40\"\nsrc=\"https://github.com/user-attachments/assets/43813d8e-011d-4a64-86cc-0e03e93c4c7f\"\n/>\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [ ] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n### Identify risks\n\nDoes this PR introduce any risks? For example, consider risks like hard\nto test bugs, performance regression, potential of data loss.\n\nDescribe the risk, its severity, and mitigation for each identified\nrisk. Invite stakeholders and evaluate how to proceed before merging.\n\n- [ ] [See some risk\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)\n- [ ] ...\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Viduni Wickramarachchi <viduni.wickramarachchi@elastic.co>","sha":"03bb564e4d178e35e513c1119f721ebaf937b9d9"}}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Viduni Wickramarachchi <viduni.wickramarachchi@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
kibanamachine
removed
the
backport missing
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
Jul 25, 2025
…function (elastic#228009) ## Summary This PR addresses elastic#227906 and fixes Inference id missing LLM task retrieval documentation function. By default, it will use the default ELSER endpoint. With the E5 model: <img width="1410" height="881" alt="Screenshot 2025-07-15 at 08 10 40" src="https://github.com/user-attachments/assets/43813d8e-011d-4a64-86cc-0e03e93c4c7f" /> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Viduni Wickramarachchi <viduni.wickramarachchi@elastic.co>
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
Jul 25, 2025
## Summary I just spotted that elastic#228009 made an import from deprecated `x-pack/test` helper. It usually leads to circular dependencies issue, so I updated the import to the same helper already in solution directory and removed duplicated directory (it was temp solution to avoid circular deps when moving tests around, sorry for confusion) I moved a few oblt helpers directly to Search solution search_playground test dir, but we probably need to decouple "platform" part of it and move to `kbn/test-suites-xpack-platform` --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
crespocarlos
pushed a commit
to crespocarlos/kibana
that referenced
this pull request
Jul 25, 2025
## Summary I just spotted that elastic#228009 made an import from deprecated `x-pack/test` helper. It usually leads to circular dependencies issue, so I updated the import to the same helper already in solution directory and removed duplicated directory (it was temp solution to avoid circular deps when moving tests around, sorry for confusion) I moved a few oblt helpers directly to Search solution search_playground test dir, but we probably need to decouple "platform" part of it and move to `kbn/test-suites-xpack-platform` --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
dmlemeshko
added a commit
to dmlemeshko/kibana
that referenced
this pull request
Aug 8, 2025
## Summary I just spotted that elastic#228009 made an import from deprecated `x-pack/test` helper. It usually leads to circular dependencies issue, so I updated the import to the same helper already in solution directory and removed duplicated directory (it was temp solution to avoid circular deps when moving tests around, sorry for confusion) I moved a few oblt helpers directly to Search solution search_playground test dir, but we probably need to decouple "platform" part of it and move to `kbn/test-suites-xpack-platform` --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 122cd9a) # Conflicts: # x-pack/solutions/observability/test/api_integration_deployment_agnostic/apis/ai_assistant/complete/functions/retrieve_elastic_doc.spec.ts # x-pack/solutions/observability/test/tsconfig.json # x-pack/solutions/search/test/functional/apps/search_playground/utils/create_llm_proxy.ts # x-pack/solutions/search/test/functional/apps/search_playground/utils/create_openai_chunk.ts # x-pack/test/api_integration/deployment_agnostic/apis/observability/ai_assistant/utils/knowledge_base.ts # x-pack/test/api_integration/deployment_agnostic/apis/observability/ai_assistant/utils/model_and_inference.ts # x-pack/test/functional/apps/search_playground/playground_overview.ess.ts # x-pack/test/tsconfig.json
dmlemeshko
added a commit
that referenced
this pull request
Aug 11, 2025
…) (#231211) # Backport This will backport the following commits from `main` to `8.19`: - [[ai_assistant] remove import from kbn/test-suites-xpack (#228650)](#228650) <!--- Backport version: 10.0.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Dzmitry Lemechko","email":"dzmitry.lemechko@elastic.co"},"sourceCommit":{"committedDate":"2025-07-21T09:56:40Z","message":"[ai_assistant] remove import from kbn/test-suites-xpack (#228650)\n\n## Summary\n\nI just spotted that #228009 made\nan import from deprecated `x-pack/test` helper.\n\nIt usually leads to circular dependencies issue, so I updated the import\nto the same helper already in solution directory and removed duplicated\ndirectory (it was temp solution to avoid circular deps when moving tests\naround, sorry for confusion)\n\nI moved a few oblt helpers directly to Search solution search_playground\ntest dir, but we probably need to decouple \"platform\" part of it and\nmove to `kbn/test-suites-xpack-platform`\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"122cd9a7f7936a4385835f74e70166670f8e73a6","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:version","v9.1.0","v9.2.0","v8.19.1"],"title":"[ai_assistant] remove import from kbn/test-suites-xpack","number":228650,"url":"https://github.com/elastic/kibana/pull/228650","mergeCommit":{"message":"[ai_assistant] remove import from kbn/test-suites-xpack (#228650)\n\n## Summary\n\nI just spotted that #228009 made\nan import from deprecated `x-pack/test` helper.\n\nIt usually leads to circular dependencies issue, so I updated the import\nto the same helper already in solution directory and removed duplicated\ndirectory (it was temp solution to avoid circular deps when moving tests\naround, sorry for confusion)\n\nI moved a few oblt helpers directly to Search solution search_playground\ntest dir, but we probably need to decouple \"platform\" part of it and\nmove to `kbn/test-suites-xpack-platform`\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"122cd9a7f7936a4385835f74e70166670f8e73a6"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/228767","number":228767,"state":"MERGED","mergeCommit":{"sha":"78e85e4734463560866d83ec81481a14d8634cae","message":"[9.1] [ai_assistant] remove import from kbn/test-suites-xpack (#228650) (#228767)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.1`:\n- [[ai_assistant] remove import from kbn/test-suites-xpack\n(#228650)](https://github.com/elastic/kibana/pull/228650)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>"}},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/228650","number":228650,"mergeCommit":{"message":"[ai_assistant] remove import from kbn/test-suites-xpack (#228650)\n\n## Summary\n\nI just spotted that #228009 made\nan import from deprecated `x-pack/test` helper.\n\nIt usually leads to circular dependencies issue, so I updated the import\nto the same helper already in solution directory and removed duplicated\ndirectory (it was temp solution to avoid circular deps when moving tests\naround, sorry for confusion)\n\nI moved a few oblt helpers directly to Search solution search_playground\ntest dir, but we probably need to decouple \"platform\" part of it and\nmove to `kbn/test-suites-xpack-platform`\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"122cd9a7f7936a4385835f74e70166670f8e73a6"}},{"branch":"8.19","label":"v8.19.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses #227906 and fixes Inference id missing LLM task retrieval documentation function. By default, it will use the default ELSER endpoint.
With the E5 model:
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesbackport:*labels.Identify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.