Skip to content

Fix _source formatting#22800

Merged
markov00 merged 4 commits intoelastic:masterfrom
markov00:fix/22770
Sep 10, 2018
Merged

Fix _source formatting#22800
markov00 merged 4 commits intoelastic:masterfrom
markov00:fix/22770

Conversation

@markov00
Copy link
Copy Markdown
Contributor

@markov00 markov00 commented Sep 7, 2018

Fix ESA-2018-14 / CVE-2018-3830

This PR fixes #22770

@markov00 markov00 added bug Fixes for quality problems that affect the customer experience :Management v7.0.0 v6.5.0 v6.4.1 labels Sep 7, 2018
@markov00 markov00 requested review from epixa and timroes September 7, 2018 10:00
Copy link
Copy Markdown
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the described behavior

@elasticmachine

This comment has been minimized.

@elasticmachine

This comment has been minimized.

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Copy link
Copy Markdown
Contributor

@epixa epixa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markov00 markov00 merged commit 45e4791 into elastic:master Sep 10, 2018
markov00 added a commit to markov00/kibana that referenced this pull request Sep 10, 2018
* Fix _source formatting

* Update unit test

* Add functional test

* Fix CI error, move functional test to the end
markov00 added a commit to markov00/kibana that referenced this pull request Sep 10, 2018
* Fix _source formatting

* Update unit test

* Add functional test

* Fix CI error, move functional test to the end
markov00 added a commit that referenced this pull request Sep 10, 2018
* Fix _source formatting

* Update unit test

* Add functional test

* Fix CI error, move functional test to the end
markov00 added a commit that referenced this pull request Sep 10, 2018
* Fix _source formatting

* Update unit test

* Add functional test

* Fix CI error, move functional test to the end
epixa pushed a commit that referenced this pull request Sep 10, 2018
* Backport fix to 5.6 structure

* Fix CI error, update functional test to use 5.6 visualize page objects

* removed async and anon function
@LeeDr LeeDr added the v5.6.12 label Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Fixes for quality problems that affect the customer experience v5.6.12 v6.4.1 v6.5.0 v7.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Configuring a Top Hit metric on _source throws fatal error

5 participants