Skip to content

[8.18] Fixes FIPS test skips in ML Disabled suite (#227677) #227985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kibanamachine merged 1 commit into from
Jul 15, 2025
Merged

[8.18] Fixes FIPS test skips in ML Disabled suite (#227677) #227985

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .../rules_management/prebuilt_rules/ml_disabled/perform_installation/perform_installation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,9 @@ export default ({ getService }: FtrProviderContext): void => {
const es = getService('es');
const supertest = getService('supertest');
const log = getService('log');
const config = getService('config');
const basic = config.get('esTestCluster.license') === 'basic';

describe('@ess @serverless @skipInServerlessMKI Prebuilt rules installation perform', function () {
if (basic) {
this.tags('skipFIPS');
}
this.tags('skipFIPS');

beforeEach(async () => {
await deleteAllRules(supertest, log);
Expand Down
10 changes: 2 additions & 8 deletions ...s_response/rules_management/prebuilt_rules/ml_disabled/perform_upgrade/perform_upgrade.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ export default ({ getService }: FtrProviderContext): void => {
const es = getService('es');
const supertest = getService('supertest');
const log = getService('log');
const config = getService('config');
const basic = config.get('esTestCluster.license') === 'basic';
const deps = {
es,
supertest,
Expand All @@ -39,9 +37,7 @@ export default ({ getService }: FtrProviderContext): void => {
const ruleId = 'ml-rule';

describe('ALL_RULES mode', function () {
if (basic) {
this.tags('skipFIPS');
}
this.tags('skipFIPS');

it('silently skips ML rules in ALL_RULES mode', async () => {
await setUpRuleUpgrade({
Expand Down Expand Up @@ -76,9 +72,7 @@ export default ({ getService }: FtrProviderContext): void => {

describe('SPECIFIC_RULES mode', function () {
describe(`doesn't upgrade`, function () {
if (basic) {
this.tags('skipFIPS');
}
this.tags('skipFIPS');

it(`if target is an ML rule`, async () => {
await createMlRuleThroughAlertingEndpoint(supertest, {
Expand Down
6 changes: 1 addition & 5 deletions ...se/rules_management/prebuilt_rules/ml_disabled/review_installation/review_installation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,9 @@ export default ({ getService }: FtrProviderContext): void => {
const es = getService('es');
const supertest = getService('supertest');
const log = getService('log');
const config = getService('config');
const basic = config.get('esTestCluster.license') === 'basic';

describe('@ess @serverless @skipInServerlessMKI Prebuilt rules installation review', function () {
if (basic) {
this.tags('skipFIPS');
}
this.tags('skipFIPS');

beforeEach(async () => {
await deleteAllRules(supertest, log);
Expand Down
6 changes: 1 addition & 5 deletions ...ons_response/rules_management/prebuilt_rules/ml_disabled/review_upgrade/review_upgrade.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@ export default ({ getService }: FtrProviderContext): void => {
const es = getService('es');
const supertest = getService('supertest');
const log = getService('log');
const config = getService('config');
const basic = config.get('esTestCluster.license') === 'basic';
const deps = {
es,
supertest,
Expand All @@ -38,9 +36,7 @@ export default ({ getService }: FtrProviderContext): void => {
const ruleId = 'ml-rule';

describe(`rule is excluded from response`, function () {
if (basic) {
this.tags('skipFIPS');
}
this.tags('skipFIPS');

it('if target is an ML rule', async () => {
await createMlRuleThroughAlertingEndpoint(supertest, {
Expand Down
6 changes: 1 addition & 5 deletions ...t_suites/detections_response/rules_management/prebuilt_rules/ml_disabled/status/status.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,9 @@ export default ({ getService }: FtrProviderContext): void => {
const es = getService('es');
const supertest = getService('supertest');
const log = getService('log');
const config = getService('config');
const basic = config.get('esTestCluster.license') === 'basic';

describe('@ess @serverless @skipInServerlessMKI Prebuilt rules status', function () {
if (basic) {
this.tags('skipFIPS');
}
this.tags('skipFIPS');

beforeEach(async () => {
await deleteAllRules(supertest, log);
Expand Down